ioeric added inline comments.
> hokein wrote in ChangeNamespace.cpp:187 > I think the statement doesn't compile here, since `consume_front` return a > `bool`. It should be `if (DeclName.consume_front((NsName + "::")))`? > > Looks like we can also put this judge into the above `while` statement? Note that `str()` is called on `(NsName + "::")` instead of `consume_front`. But you are right, we can put the check into the while loop. https://reviews.llvm.org/D25065 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
