aaron.ballman added a comment. Generally looks good to me, sorry I missed these tiny nits last time around.
> ProTypeMemberInitCheck.h:49 > void checkMissingMemberInitializer(ASTContext &Context, > + const CXXRecordDecl *ClassDecl, > const CXXConstructorDecl *Ctor); Since this is not allowed to be a null pointer, would it make more sense to use a reference instead (same below)? > cppcoreguidelines-pro-type-member-init.cpp:409 > + > +template struct NegativeTemplateVirtualDestructor<int>; > + Sorry, I missed one bit to my test (my fault), can you also add `int F;` to ensure that it still triggers the diagnostic? https://reviews.llvm.org/D24965 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
