vbyakovlcl added inline comments.
> aaron.ballman wrote in DiagnosticGroups.td:522 > I would not add this as a diagnostic group, but instead use an ad-hoc group > on the diagnostic itself. I don't think this is going to see very many > diagnostics covered by the same group, but if that turns out to be the case, > we can switch then. Ok, done > aaron.ballman wrote in DiagnosticSemaKinds.td:2306 > I'm not the best one to answer that question, but we typically avoid adding > new off-by-default diagnostics. Since GCC prints this as an error message and > this patch is for GCC compatibility, it seems weird to me to add this as an > off-by-default warning. I did similar to GCC - error by default. https://reviews.llvm.org/D24669 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
