[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein created this revision. hokein added a subscriber: cfe-commits. This patch introduces a new tool which moves a specific class definition from files (.h, .cc) to new files (.h, .cc), which mostly acts like "Extract class defintion". In the long term, this tool should be merged in to clang-ref

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 70362. hokein added a comment. Minor cleanup. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt clang-move/tool/ClangMoveMain.cpp unitt

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 70363. hokein added a comment. Fix function name style. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt clang-move/tool/ClangMoveMain.c

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

omtcyfz added inline comments. Comment at: clang-move/ClangMove.h:25 @@ +24,3 @@ + +// TODO(hokein): Make it support more types, e.g. function definitions. +// Currently only support moving class definition. `FIXME`? https://reviews.llvm.org/D24243 __

RE: r275095 - [NFC] Reorder fields of VersionTuple to reduce size

Hi Erik, would you mind reverting this temporarily? It broke our recursive builds buildbot because the re-ordering of VersionTuple's bitfields generates an i128 which our MIPS backend erroneously accepts for the o32 ABI. - V. Kalintiris From: cfe-commits

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

hokein added a comment. some initial comments. Comment at: change-namespace/CMakeLists.txt:9 @@ +8,3 @@ + LINK_LIBS + clangAST + clangBasic I think `clangASTMatchers` is needed here. Comment at: change-namespace/ChangeNamespace.cpp:21 @@ +20

[PATCH] D24245: [ARM] ARM-specific attributes should be accepted for big-endian

olista01 created this revision. olista01 added reviewers: rengolin, t.p.northover. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: samparker, rengolin, aemerson. The ARM-specific C attributes (currently just interrupt) n

Re: [PATCH] D23992: [OpenCL] Augment pipe built-ins with pipe packet size and alignment.

bader updated this revision to Diff 70366. bader added a comment. Applied code review comment from Anastasia. Use getTypeSizeInChars instead of getTypeSize to get type size in bytes. Assume that char size is always one byte. https://reviews.llvm.org/D23992 Files: lib/CodeGen/CGBuiltin.cpp

Re: [PATCH] D24136: [OpenCL] Fix pipe built-in functions return type.

bader updated this revision to Diff 70368. bader added a comment. Added get_pipe_num_packets and get_pipe_max_packets test cases. https://reviews.llvm.org/D24136 Files: lib/Sema/SemaChecking.cpp test/CodeGenOpenCL/pipe_builtin.cl Index: test/CodeGenOpenCL/pipe_builtin.cl ==

r280699 - [OpenCL] Remove access qualifiers on images in arg info metadata.

Author: bader Date: Tue Sep 6 05:10:28 2016 New Revision: 280699 URL: http://llvm.org/viewvc/llvm-project?rev=280699&view=rev Log: [OpenCL] Remove access qualifiers on images in arg info metadata. Summary: Remove access qualifiers on images in arg info metadata: * kernel_arg_type * kernel_arg_

Re: [PATCH] D23915: [OpenCL] Remove access qualifiers on images in arg info metadata.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280699: [OpenCL] Remove access qualifiers on images in arg info metadata. (authored by bader). Changed prior to commit: https://reviews.llvm.org/D23915?vs=69649&id=70372#toc Repository: rL LLVM http

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

omtcyfz updated the summary for this revision. omtcyfz removed a reviewer: bkramer. omtcyfz added subscribers: bkramer, hokein. omtcyfz updated this revision to Diff 70373. omtcyfz added a comment. Removed whole clang-rename part, only making this patch clang-rename specific. https://reviews.llv

Re: [PATCH] D24087: [lit] Allow more file extensions for test cases.

logan added inline comments. Comment at: test/libcxx/test/format.py:69 @@ +68,3 @@ +name_root, name_ext = os.path.splitext(name) +is_sh_test = name_root.endswith('.sh') +is_pass_test = name_root.endswith('.pass') EricWF wrote: > Since we on

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

omtcyfz added a comment. Bringing results of an offline discussion with Eric (@ioeric) live. Eric's point was that this patch should only care about `clang-refactor` and introduce changes directly related to creating `clang-rename`. `clang-rename` and all other tools migration can be done later

r280702 - [clang-cl] Check that we are in clang cl mode before enabling support for the CL environment variable.

Author: pgousseau Date: Tue Sep 6 05:48:27 2016 New Revision: 280702 URL: http://llvm.org/viewvc/llvm-project?rev=280702&view=rev Log: [clang-cl] Check that we are in clang cl mode before enabling support for the CL environment variable. Checking for the type of the command line tokenizer shoul

Re: [PATCH] D23503: [clang-cl] Check that we are in clang cl mode before enabling support for the CL environment variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280702: [clang-cl] Check that we are in clang cl mode before enabling support for the… (authored by pgousseau). Changed prior to commit: https://reviews.llvm.org/D23503?vs=68020&id=70376#toc Repository

r280701 - DebugInfo: use llvm::DINode::DIFlags type for debug info flags

Author: lkholodov Date: Tue Sep 6 05:48:04 2016 New Revision: 280701 URL: http://llvm.org/viewvc/llvm-project?rev=280701&view=rev Log: DebugInfo: use llvm::DINode::DIFlags type for debug info flags Use llvm::DINode::DIFlags type (strongly typed enum) for debug flags instead of unsigned int to a

Re: [PATCH] D23767: DebugInfo: use llvm::DINode::DIFlags type for debug info flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL280701: DebugInfo: use llvm::DINode::DIFlags type for debug info flags (authored by lkholodov). Changed prior to commit: https://reviews.llvm.org/D23767?vs=69755&id=70375#toc Repository: rL LLVM htt

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

alexfh added inline comments. Comment at: include/clang/Analysis/CFG.h:526 @@ -524,1 +525,3 @@ typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator; + typedef llvm::iterator_range pred_range; + typedef llvm::iterator_range

Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

logan added a comment. Hi @rengolin and @EricWF, After tracing the commit log of clang, it seems that `--rtlib=` is ignored intentionally when `-nodefaultlibs` is present. (see also: https://reviews.llvm.org/rL254535) And, unfortunately, we don't have a command line option to ask clang to lin

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

EricWF added a comment. This looks great. Two comments: 1. The declarations should be used in both the inline and external pthread implementation. They also need visibility declarations. 2. Why can't we use the inline implementation to implement `external_threads.cpp`? I took a stab at it her

Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

EricWF added a comment. In https://reviews.llvm.org/D24083#534459, @logan wrote: > One solution might be adding the `libclang_rt.builtins.${arch}.a` detection > rules[1] to CMakeLists.txt, and manually specify > `-lclang_rt.builtins-${arch}.a` when `LIBCXXABI_USE_COMPILER_RT` is enabled. > Ho

Re: [PATCH] D24087: [lit] Allow more file extensions for test cases.

EricWF added inline comments. Comment at: test/libcxx/test/format.py:69 @@ +68,3 @@ +name_root, name_ext = os.path.splitext(name) +is_sh_test = name_root.endswith('.sh') +is_pass_test = name_root.endswith('.pass') logan wrote: > EricWF wrot

Re: [PATCH] D21505: [Clang][AVX512][Intrinsics]Adding intrinsics for mov{ss|sd} instruction set

m_zuckerman updated this revision to Diff 70383. https://reviews.llvm.org/D21505 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c +

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFindingAction.cpp:49 @@ -47,4 +48,3 @@ public: - explicit AdditionalUSRFinder(const Decl *FoundDecl, ASTContext &Context, - std::ve

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

omtcyfz updated this revision to Diff 70388. omtcyfz marked 6 inline comments as done. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D24224 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

omtcyfz added inline comments. Comment at: clang-rename/USRFindingAction.h:23 @@ -19,1 +22,3 @@ + +using llvm::ArrayRef; alexfh wrote: > No using declarations in headers, please. Also, since your code is in the > clang namespace, you can include clang/Basic/LLV

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

hokein added a comment. > Eric's point was that this patch should only care about clang-refactor and > introduce changes directly related to creating clang-rename. clang-rename and > all other tools migration can be done later, which is also good in terms of > this patch not growing too large.

RE: r275095 - [NFC] Reorder fields of VersionTuple to reduce size

It turns out that there's no need to revert this as the problem persists even without your patch. I'm preparing a patch that fixes the underlying issue. - V. Kalintiris From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Vasileios Kalintir

Re: [PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

vsk resigned from this revision. vsk removed a reviewer: vsk. vsk added a comment. I don't see any issues with this patch, but also don't know enough about the openbsd toolchain to lgtm it. https://reviews.llvm.org/D22130 ___ cfe-commits mailing li

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

omtcyfz updated this revision to Diff 70397. omtcyfz marked 11 inline comments as done. omtcyfz added a comment. Addressing a round of comments. https://reviews.llvm.org/D24192 Files: CMakeLists.txt clang-refactor/CMakeLists.txt clang-refactor/driver/CMakeLists.txt clang-refactor/driver

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

omtcyfz added a comment. Thank you for reviewing, @hokein! Also, please note that this is not a final version, the interface will change a lot in the upcoming diffs. Comment at: clang-refactor/driver/Driver.cpp:46 @@ +45,3 @@ +llvm::StringRef FirstArgument(argv[1]); +i

[PATCH] D24257: clang-format: [JS] ignore comments when wrapping returns.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. When code contains a comment between `return` and the value: return /* lengthy comment here */ ( lengthyValueComesHere); Do not wrap before th

Re: [PATCH] D24257: clang-format: [JS] ignore comments when wrapping returns.

mprobst added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2384 @@ -2383,2 +2383,3 @@ } else if (Style.Language == FormatStyle::LK_JavaScript) { -if (Left.is(tok::kw_return)) +const FormatToken *NonComment = Right.getPreviousNonComment(); +if (Left.isO

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator updated this revision to Diff 70406. tavianator added a comment. Uses a __thread variable to hold the destructor list, as @EricWF suggested. https://reviews.llvm.org/D21803 Files: src/cxa_thread_atexit.cpp test/CMakeLists.txt test/cxa_thread_atexit_test.pass.cpp test/libcxxab

Re: r253269 - Make FP_CONTRACT ON the default.

Hi Steve, et al., It looks like this crasher was fixed in r254573. Should we move forward with recommitting this now? Thanks again, Hal - Original Message - > From: "Manuel Klimek" > To: "Hal Finkel" , "Renato Golin" > Cc: "Clang Commits" > Sent: Tuesday, November 17, 2015 9:47:11 AM

Re: r253269 - Make FP_CONTRACT ON the default.

Yes, we should, I just haven’t had time to deal with it. If someone else wants to pick it up, feel free. Otherwise, I’ll be able to get to it in another couple weeks. > On Sep 6, 2016, at 12:14 PM, Hal Finkel wrote: > > Hi Steve, et al., > > It looks like this crasher was fixed in r254573.

Re: [PATCH] D23284: Add -Rpass-with-hotness

anemet added a comment. In https://reviews.llvm.org/D23284#526413, @dnovillo wrote: > I'm fine with it, but I don't have much of a say in how option groups are > organized. If Richard agrees, then it LGTM. Ping. Would it be OK to commit this with the two LGTMs? I am around to fix any fall-

Re: [PATCH] D23953: OpenCL: Defining __ENDIAN_LITTLE__ and fix target endianness

arsenm added a comment. ping https://reviews.llvm.org/D23953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280718 - Formatting with clang-format patch r280701

Author: lkholodov Date: Tue Sep 6 12:06:14 2016 New Revision: 280718 URL: http://llvm.org/viewvc/llvm-project?rev=280718&view=rev Log: Formatting with clang-format patch r280701 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm

Re: [PATCH] D24136: [OpenCL] Fix pipe built-in functions return type.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D24136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-move/ClangMove.h:33 @@ +32,3 @@ +clang::SourceManager *SM; +MovedDecl() : Decl(nullptr), SM(nullptr) {} +MovedDecl(const clang::Decl *Decl, clang::SourceManager *SM) Please add empty

Re: [PATCH] D23284: Add -Rpass-with-hotness

rsmith added a comment. Sorry I missed this until now. I think this should not be an -R option at all; like -W flags, the idea is for -R to only act as a filter for which diagnostics are shown. This option seems much more closely related to options like -fdiagnostics-show-option and -fdiagnost

LLVM buildmaster will be restarted in few minutes

Hello everyone, LLVM buildmaster will be restarted in few minutes. Sorry for inconvenience. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23992: [OpenCL] Augment pipe built-ins with pipe packet size and alignment.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D23992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[clang-tools-extra] r280725 - [Release notes] Fix links.

Author: eugenezelenko Date: Tue Sep 6 12:52:44 2016 New Revision: 280725 URL: http://llvm.org/viewvc/llvm-project?rev=280725&view=rev Log: [Release notes] Fix links. Differential revision: https://reviews.llvm.org/D24201 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: cla

Re: [PATCH] D24201: [Clang-tools-extra] Fix links in release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL280725: [Release notes] Fix links. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24201?vs=70229&id=70433#toc Repository: rL LLVM https://reviews.llvm.org/D24201 Fi

Re: [PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

Anastasia added a comment. In https://reviews.llvm.org/D23712#524021, @asavonic wrote: > In https://reviews.llvm.org/D23712#520818, @Anastasia wrote: > > > What would be the use case to override the supported extensions for the end > > user? > > > Some extensions may be supported by the platform

r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

Author: mren Date: Tue Sep 6 13:16:54 2016 New Revision: 280728 URL: http://llvm.org/viewvc/llvm-project?rev=280728&view=rev Log: Modules: Fix an assertion in DeclContext::buildLookup. When calling getMostRecentDecl, we can pull in more definitions from a module. We call getPrimaryContext afterw

Re: [PATCH] D23284: Add -Rpass-with-hotness

anemet added a comment. In https://reviews.llvm.org/D23284#534879, @rsmith wrote: > I think this should not be an -R option at all; like -W flags, the idea is > for -R to only act as a filter for which diagnostics are shown. This option > seems much more closely related to options like -fdiagno

Re: [PATCH] D23953: OpenCL: Defining __ENDIAN_LITTLE__ and fix target endianness

Anastasia added a subscriber: Anastasia. Anastasia accepted this revision. Anastasia added a reviewer: Anastasia. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D23953 ___ cfe-commits maili

Re: [PATCH] D24113: Allow implicit conversions between incompatible pointer types in overload resolution in C.

jvesely added a subscriber: jvesely. jvesely added a comment. This change breaks OpenCL(libclc). CLC expects signed/unsigned overloads to be non-ambiguous. For example: atomic_max(global int *p, int val); atomic_max(global unsigned int *p, unsigned int val); need to work and be unambiguous (they

Re: [PATCH] D24257: clang-format: [JS] ignore comments when wrapping returns.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lib/Format/TokenAnnotator.cpp:2384 @@ -2383,2 +2383,3 @@ } else if (Style.Language == FormatStyle::LK_JavaScript) { -if (Left.is(tok::kw_retur

r280730 - clang-format: [JS] ignore comments when wrapping returns.

Author: mprobst Date: Tue Sep 6 13:39:30 2016 New Revision: 280730 URL: http://llvm.org/viewvc/llvm-project?rev=280730&view=rev Log: clang-format: [JS] ignore comments when wrapping returns. Summary: When code contains a comment between `return` and the value: return /* lengthy comment here

Re: [PATCH] D24257: clang-format: [JS] ignore comments when wrapping returns.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280730: clang-format: [JS] ignore comments when wrapping returns. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D24257?vs=70405&id=70444#toc Repository: rL LLVM https://re

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

vitalybuka resigned from this revision. vitalybuka removed a reviewer: vitalybuka. vitalybuka added a comment. I have no strong opinion on that. There is already exception for startfiles, so maybe sanitizes are OK as well. https://reviews.llvm.org/D24048 _

[PATCH] D24272: clang-format: [JS] whitespace required between ! and as.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Before: x!as string After: x! as string https://reviews.llvm.org/D24272 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp

Re: [PATCH] D24272: clang-format: [JS] whitespace required between ! and as.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D24272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

bruno added a comment. Ping! In https://reviews.llvm.org/D23852#529308, @aaron.ballman wrote: > In https://reviews.llvm.org/D23852#525291, @doug.gregor wrote: > > > This will work, but it's *really* unfortunate to put tentative parsing into > > this code path because tentative parsing is far fr

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added inline comments. Comment at: clang-move/ClangMove.h:13 @@ +12,3 @@ + +#include +#include Isn't C++ headers should be after Clang headers? https://reviews.llvm.org/D24243 ___ cfe-commits mailin

r280731 - clang-format: [JS] whitespace required between ! and as.

Author: mprobst Date: Tue Sep 6 13:55:34 2016 New Revision: 280731 URL: http://llvm.org/viewvc/llvm-project?rev=280731&view=rev Log: clang-format: [JS] whitespace required between ! and as. Summary: Before: x!as string After: x! as string Reviewers: djasper Subscribers: klimek, cfe-com

Re: [PATCH] D24272: clang-format: [JS] whitespace required between ! and as.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280731: clang-format: [JS] whitespace required between ! and as. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D24272?vs=70442&id=70446#toc Repository: rL LLVM https://rev

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added a comment. Probably old_source/new_source will be better, because different extensions are used for C++ files. https://reviews.llvm.org/D24243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D24163: [scan-build-py] Increase precision of timestamp in report directory name

dcoughlin updated this revision to Diff 70458. dcoughlin added a comment. Fix the pep8 79-column violation. https://reviews.llvm.org/D24163 Files: tools/scan-build-py/libscanbuild/report.py tools/scan-build-py/tests/unit/test_report.py Index: tools/scan-build-py/tests/unit/test_report.py =

Re: [PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL280741: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24179?vs=70121&id=70459#toc Reposito

[clang-tools-extra] r280741 - [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes.

Author: eugenezelenko Date: Tue Sep 6 14:53:26 2016 New Revision: 280741 URL: http://llvm.org/viewvc/llvm-project?rev=280741&view=rev Log: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes. Differential revision: https://reviews.llvm

[libcxx] r280743 - Remove unneeded includes in after removing __libcpp_throw

Author: ericwf Date: Tue Sep 6 14:56:40 2016 New Revision: 280743 URL: http://llvm.org/viewvc/llvm-project?rev=280743&view=rev Log: Remove unneeded includes in after removing __libcpp_throw Modified: libcxx/trunk/include/exception Modified: libcxx/trunk/include/exception URL: http://llvm.

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

ioeric added a comment. NIce! Some initial comments. Comment at: clang-move/ClangMove.cpp:38 @@ +37,3 @@ + const clang::Module * /*Imported*/) override { +if (const auto *FileEntry = SM.getFileEntryForID(SM.getFileID(HashLoc))) { + if (IsAngled)

[libcxx] r280745 - Add missing include. Sorry about the bot breakage

Author: ericwf Date: Tue Sep 6 15:10:13 2016 New Revision: 280745 URL: http://llvm.org/viewvc/llvm-project?rev=280745&view=rev Log: Add missing include. Sorry about the bot breakage Modified: libcxx/trunk/include/typeinfo Modified: libcxx/trunk/include/typeinfo URL: http://llvm.org/viewvc

[PATCH] D24278: [analyzer] Extend bug reports with extra notes.

NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin, teemperor, v.g.vassilev. NoQ added a subscriber: cfe-commits. This patch allows injecting extra note-like diagnostics into bug reports, which are separate from path diagnostics. Previously, we could only

Re: [PATCH] D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

rsmith added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:487-489 @@ +486,5 @@ + // Traverses template parameter lists of either a DeclaratorDecl or TagDecl. + template ::value || + std::is_base_of::value>::type> + bool TraverseDeclTemplateParameter

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

ioeric updated this revision to Diff 70465. ioeric marked 10 inline comments as done. ioeric added a comment. - Addressed some review comments. https://reviews.llvm.org/D24183 Files: CMakeLists.txt change-namespace/CMakeLists.txt change-namespace/ChangeNamespace.cpp change-namespace/Cha

[libcxx] r280752 - Revert r280743 and r280745. Remove include from ``

Author: ericwf Date: Tue Sep 6 16:06:41 2016 New Revision: 280752 URL: http://llvm.org/viewvc/llvm-project?rev=280752&view=rev Log: Revert r280743 and r280745. Remove include from `` Apparently I missed a number of additional include which need to be added. Reverting so I can recommit as a sing

[libcxx] r280754 - Try 2 - Remove include from ``

Author: ericwf Date: Tue Sep 6 16:25:27 2016 New Revision: 280754 URL: http://llvm.org/viewvc/llvm-project?rev=280754&view=rev Log: Try 2 - Remove include from `` This patch removes the `` include from exception where it is no longer needed. Unlike my previous attempt this patch also adds wher

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz added a comment. ping? https://reviews.llvm.org/D17741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24113: Allow implicit conversions between incompatible pointer types in overload resolution in C.

george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. Thanks for the heads-up! I'm assuming that below is an example of code that this patch broke? void foo(int *a, int) __attribute__((overloadable)); void foo(unsigned int *a, unsigned int) __attribute__((ove

Re: [PATCH] D23284: Add -Rpass-with-hotness

rsmith added a comment. In https://reviews.llvm.org/D23284#534919, @anemet wrote: > In https://reviews.llvm.org/D23284#534879, @rsmith wrote: > > > I think this should not be an -R option at all; like -W flags, the idea is > > for -R to only act as a filter for which diagnostics are shown. This

Re: [PATCH] D23284: Add -Rpass-with-hotness

anemet added a comment. In https://reviews.llvm.org/D23284#535258, @rsmith wrote: > I think this should start with `-fdiagnostics` to group it with other similar > flags. `-fdiagnostics-include-hotness-in-remarks` seems too specific to me -- > I could imagine generating warnings from the middle

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

This is urgent, so I’ve tried to come up with a patch to fix this. I tried reverting r278501 and then made changes to have Sema::CheckVectorOperands call tryVectorConvertAndSplat when the vector type is a normal gcc vector. This fixes the test case I sent and also doesn’t affect the regression t

Re: [PATCH] D24163: [scan-build-py] Increase precision of timestamp in report directory name

This revision was automatically updated to reflect the committed changes. Closed by commit rL280768: [scan-build-py] Increase precision of timestamp in report directory name (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D24163?vs=70458&id=70493#toc Repository: rL

r280768 - [scan-build-py] Increase precision of timestamp in report directory name

Author: dcoughlin Date: Tue Sep 6 18:42:51 2016 New Revision: 280768 URL: http://llvm.org/viewvc/llvm-project?rev=280768&view=rev Log: [scan-build-py] Increase precision of timestamp in report directory name This commit improves compatibility with the perl version of scan-build. The perl versio

Re: [PATCH] D24218: [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname and numpunct_byname.

EricWF retitled this revision from "[libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname" to "[libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname and numpunct_byname.". EricWF updated the summary for this revision. EricWF upd

[PATCH] D24286: Add MS __nop intrinsic to intrin.h

agutowski created this revision. agutowski added reviewers: rnk, thakis. agutowski added a subscriber: cfe-commits. There was no definition for __nop function - added inline assembly. https://reviews.llvm.org/D24286 Files: lib/Headers/intrin.h test/Headers/ms-intrin.cpp Index: lib/Headers/i

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

It seems to me that the test case in test/Sema/vector-cast.c looks incorrect. According to gcc’s documentation, you can cast vectors to and from scalars of the same size, so clang shouldn’t reject “double += <1 x double>". https://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

EricWF added a comment. LGTM modulo bug fix. Comment at: src/cxa_thread_atexit.cpp:70 @@ +69,3 @@ +while (auto head = dtors) { + dtors = head->next; + head->dtor(head->obj); There is a bug here. If `head->next == nullptr` and if `head->dtor(head->o

[libcxx] r280771 - Improve CMake output when registering benchmarks

Author: ericwf Date: Tue Sep 6 19:57:26 2016 New Revision: 280771 URL: http://llvm.org/viewvc/llvm-project?rev=280771&view=rev Log: Improve CMake output when registering benchmarks Modified: libcxx/trunk/benchmarks/CMakeLists.txt Modified: libcxx/trunk/benchmarks/CMakeLists.txt URL: http:/

Re: [PATCH] D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This patch looks great, thank you! Do you have an SVN account or do you need someone to commit this for you? Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:72

[libcxx] r280773 - Enable installation of libc++experimental by default.

Author: ericwf Date: Tue Sep 6 20:15:10 2016 New Revision: 280773 URL: http://llvm.org/viewvc/llvm-project?rev=280773&view=rev Log: Enable installation of libc++experimental by default. When libc++experimental was originally created it was empty and therefore there was no reason to install it. N

Re: [PATCH] D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

lukasza updated the summary for this revision. lukasza updated this revision to Diff 70483. lukasza added a comment. Addressing CR feedbackfrom rsmith@. https://reviews.llvm.org/D24268 Files: include/clang/AST/RecursiveASTVisitor.h unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Index:

[PATCH] D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

lukasza created this revision. lukasza added a reviewer: rsmith. lukasza added a subscriber: cfe-commits. Herald added a subscriber: klimek. The unit tests in this patch demonstrate the need to traverse template parameter lists of DeclaratorDecls (e.g. VarDecls, CXXMethodDecls) and TagDecls (e.g.

Re: [PATCH] D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

lukasza added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:487-489 @@ +486,5 @@ + // Traverses template parameter lists of either a DeclaratorDecl or TagDecl. + template ::value || + std::is_base_of::value>::type> + bool TraverseDeclTemplateParamete

Re: [PATCH] D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

lukasza added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:1728 @@ -1708,2 +1727,3 @@ + TRY_TO(TraverseDeclTemplateParameterLists(D)); TRY_TO(TraverseNestedNameSpecifierLoc(D->getQualifierLoc())); I think that tweaks of EnumDecl trave

Re: [PATCH] D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

On Tue, Sep 6, 2016 at 3:47 PM, Łukasz Anforowicz wrote: > lukasza added inline comments. > > > Comment at: include/clang/AST/RecursiveASTVisitor.h:487-489 > @@ +486,5 @@ > + // Traverses template parameter lists of either a DeclaratorDecl or > TagDecl. > + template + std

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mren > Date: Tue Sep 6 13:16:54 2016 > New Revision: 280728 > > URL: http://llvm.org/viewvc/llvm-project?rev=280728&view=rev > Log: > Modules: Fix an assertion in DeclContext::buildLookup. >

[libcxx] r280775 - Fix PR30260 - optional not working.

Author: ericwf Date: Tue Sep 6 20:56:07 2016 New Revision: 280775 URL: http://llvm.org/viewvc/llvm-project?rev=280775&view=rev Log: Fix PR30260 - optional not working. This patch fixes PR30260 by using a (void*) cast on the placement argument to placement new to casts away the const. See also ht

Re: [PATCH] D24158: Try contextually converting condition of constexpr if to Boolean value

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, LGTM. If you're looking for more issues in this area -- in passing I noticed that we fail to apply the "contextually converted constant expression of type bool" rules properly in the

Re: [PATCH] D24158: Try contextually converting condition of constexpr if to Boolean value

rsmith added inline comments. Comment at: test/CodeGenCXX/cxx1z-constexpr-if.cpp:26-29 @@ -17,2 +25,6 @@ } + if constexpr (A()) +should_be_used_3(); + else +should_not_be_used(); } Please also add a test that we reject expressions that are contextual

r280776 - Fix clang's handling of the copy performed in the second phase of class

Author: rsmith Date: Tue Sep 6 21:14:33 2016 New Revision: 280776 URL: http://llvm.org/viewvc/llvm-project?rev=280776&view=rev Log: Fix clang's handling of the copy performed in the second phase of class copy-initialization. We previously got this wrong in a couple of ways: - we only looked for

[libcxx] r280777 - Improve constexpr tests for std::any

Author: ericwf Date: Tue Sep 6 21:38:48 2016 New Revision: 280777 URL: http://llvm.org/viewvc/llvm-project?rev=280777&view=rev Log: Improve constexpr tests for std::any Modified: libcxx/trunk/test/std/utilities/any/any.class/any.cons/default.pass.cpp Modified: libcxx/trunk/test/std/utiliti

[libcxx] r280779 - Fix PR#30303 - no matching function for call to '__ptr_in_range'

Author: marshall Date: Tue Sep 6 22:32:06 2016 New Revision: 280779 URL: http://llvm.org/viewvc/llvm-project?rev=280779&view=rev Log: Fix PR#30303 - no matching function for call to '__ptr_in_range' Modified: libcxx/trunk/include/string libcxx/trunk/test/std/strings/basic.string/string.

  1   2   >