rsmith added inline comments. ================ Comment at: test/CodeGenCXX/cxx1z-constexpr-if.cpp:26-29 @@ -17,2 +25,6 @@ } + if constexpr (A()) + should_be_used_3(); + else + should_not_be_used(); } ---------------- Please also add a test that we reject expressions that are contextually convertible to a `bool` constant expression but are not contextually converted constant expressions of type `bool`. Example:
if constexpr (4.3) // ill-formed, boolean conversion not permitted ... and sadly ... constexpr void *p = nullptr; if constexpr (p) // ill-formed, boolean conversion not permitted https://reviews.llvm.org/D24158 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
