omtcyfz added inline comments. ================ Comment at: clang-rename/USRFindingAction.h:23 @@ -19,1 +22,3 @@ + +using llvm::ArrayRef; ---------------- alexfh wrote: > No using declarations in headers, please. Also, since your code is in the > clang namespace, you can include clang/Basic/LLVM.h that re-declares ArrayRef > in namespace clang. Ah, I didn't think why this might be bad at first, but now I see.
https://reviews.llvm.org/D24224 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
