EricWF added a comment. This looks great. Two comments:
1. The declarations should be used in both the inline and external pthread implementation. They also need visibility declarations. 2. Why can't we use the inline implementation to implement `external_threads.cpp`? I took a stab at it here <https://gist.github.com/EricWF/0edfd18c22cd50a5f34fd11674f4eda9>. After that this LGTM. ================ Comment at: lib/CMakeLists.txt:211 @@ +210,3 @@ + + set_target_properties(cxx_external_threads + PROPERTIES ---------------- When this is building as a shared library it needs to do the `-nodefaultlibs` dance to prevent linking to libstdc++.so or other unwanted system libraries. https://reviews.llvm.org/D21968 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
