Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki updated this revision to Diff 67470. danielmarjamaki added a comment. Make sure patch can be applied in latest trunk. Ping. https://reviews.llvm.org/D13126 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyz

[clang-tools-extra] r278201 - clang-rename YAML reader: address post-commit comments

Author: vmiklos Date: Wed Aug 10 02:13:29 2016 New Revision: 278201 URL: http://llvm.org/viewvc/llvm-project?rev=278201&view=rev Log: clang-rename YAML reader: address post-commit comments Modified: clang-tools-extra/trunk/clang-rename/tool/ClangRename.cpp clang-tools-extra/trunk/docs/cla

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added a comment. In https://reviews.llvm.org/D23198#510269, @alexfh wrote: > A few late comments. I've addressed these in r278201. Repository: rL LLVM https://reviews.llvm.org/D23198 ___ cfe-commits mailing list cfe-commits@lists.llvm.

r278202 - [x86] Fix a really nasty bug introduced in r276417 where alignment

Author: chandlerc Date: Wed Aug 10 02:32:47 2016 New Revision: 278202 URL: http://llvm.org/viewvc/llvm-project?rev=278202&view=rev Log: [x86] Fix a really nasty bug introduced in r276417 where alignment constraints were added to _mm256_broadcast_{pd,ps} intel intrinsics. The spec for these intrin

Re: r276417 - [X86][AVX] Added support for lowering to VBROADCASTF128/VBROADCASTI128 with generic IR

On Fri, Jul 22, 2016 at 7:06 AM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon > Date: Fri Jul 22 08:58:56 2016 > New Revision: 276417 > > URL: http://llvm.org/viewvc/llvm-project?rev=276417&view=rev > Log: > [X86][AVX] Added support for lowering to VBROADCAST

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

omtcyfz updated this revision to Diff 67475. omtcyfz marked 7 inline comments as done. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D23265 Files: clang-tidy/readability/ElseAfterReturnCheck.cpp docs/clang-tidy/checks/readability-else-after-return.rst test/clang-tidy

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

omtcyfz updated this revision to Diff 67476. omtcyfz added a comment. Make helper matcher `const`. https://reviews.llvm.org/D23265 Files: clang-tidy/readability/ElseAfterReturnCheck.cpp docs/clang-tidy/checks/readability-else-after-return.rst test/clang-tidy/readability-else-after-return.

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

hokein added a comment. Do you have commit access now? https://reviews.llvm.org/D22729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23274: Add an option to clang-format to remove duplicate headers.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1242 @@ -1240,1 +1241,3 @@ }); + // The index of the include on which the cursor is currently put. + unsigned CurrentCursorIndex = UINT_MAX; This needs a comment on what it is actually doing

Re: [PATCH] D23274: Add an style option "DeduplicateIncludes" to clang-format to remove duplicate headers when sorting #includes.

djasper added inline comments. Comment at: include/clang/Format/Format.h:551 @@ +550,3 @@ + /// sorting ``#includes``. + bool DeduplicateIncludes; + Actually, how about we just do this unconditionally? I think people will always want it. https://reviews.llvm.

Re: [PATCH] D23274: Add an style option "DeduplicateIncludes" to clang-format to remove duplicate headers when sorting #includes.

ioeric updated this revision to Diff 67483. ioeric marked an inline comment as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D23274 Files: include/clang/Format/Format.h lib/Format/Format.cpp test/Format/remove-duplicate-includes.cpp tools/clang-form

Re: [PATCH] D23274: Add an style option "DeduplicateIncludes" to clang-format to remove duplicate headers when sorting #includes.

ioeric added inline comments. Comment at: include/clang/Format/Format.h:551 @@ +550,3 @@ + /// sorting ``#includes``. + bool DeduplicateIncludes; + Sounds good to me. I'll get rid of the option then. https://reviews.llvm.org/D23274 _

Re: [PATCH] D23274: Add an style option "DeduplicateIncludes" to clang-format to remove duplicate headers when sorting #includes.

ioeric updated this revision to Diff 67484. ioeric added a comment. - Always deduplicate when sorting includes. Get rid of the option. https://reviews.llvm.org/D23274 Files: lib/Format/Format.cpp test/Format/remove-duplicate-includes.cpp tools/clang-format/ClangFormat.cpp unittests/Form

Re: [PATCH] D23274: Make clang-format remove duplicate headers when sorting #includes.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1224 @@ -1222,1 +1223,3 @@ +// Finds the index of the #include on which the cursor will be put after +// sorting/deduplicating. First off, make this return a pair with the two values. And then the

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

Alexander_Droste added a comment. No but I guess it would be a good idea to ask for commit access. I'll proceed like suggested here: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. https://reviews.llvm.org/D22729 ___ cfe-commits

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

omtcyf0 updated this revision to Diff 67488. omtcyf0 marked 2 inline comments as done. omtcyf0 added a comment. Address comments. https://reviews.llvm.org/D17990 Files: clang-tidy/modernize/DeprecatedHeadersCheck.cpp docs/clang-tidy/checks/modernize-deprecated-headers.rst test/clang-tidy/

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

omtcyf0 marked 3 inline comments as done. omtcyf0 added a comment. https://reviews.llvm.org/D17990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23274: Make clang-format remove duplicate headers when sorting #includes.

ioeric updated this revision to Diff 67489. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D23274 Files: lib/Format/Format.cpp test/Format/remove-duplicate-includes.cpp tools/clang-format/ClangFormat.cpp unittests/F

Re: [PATCH] D23274: Make clang-format remove duplicate headers when sorting #includes.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D23274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r278206 - Make clang-format remove duplicate headers when sorting #includes.

Author: ioeric Date: Wed Aug 10 04:32:23 2016 New Revision: 278206 URL: http://llvm.org/viewvc/llvm-project?rev=278206&view=rev Log: Make clang-format remove duplicate headers when sorting #includes. Summary: When sorting #includes, #include directives that have the same text will be deduplicate

[PATCH] D23346: [OpenCL] Change block descriptor address space to constant

joey created this revision. joey added a subscriber: cfe-commits. joey set the repository for this revision to rL LLVM. The block descriptor is a GlobalVariable in the LLVM IR, so it shouldn't be in the private address space. Repository: rL LLVM https://reviews.llvm.org/D23346 Files: lib/C

Re: [PATCH] D23274: Make clang-format remove duplicate headers when sorting #includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278206: Make clang-format remove duplicate headers when sorting #includes. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D23274?vs=67489&id=67492#toc Repository: rL LLVM ht

r278208 - [X86][AVX] Ensure we only match against 1-byte alignment

Author: rksimon Date: Wed Aug 10 04:59:49 2016 New Revision: 278208 URL: http://llvm.org/viewvc/llvm-project?rev=278208&view=rev Log: [X86][AVX] Ensure we only match against 1-byte alignment Modified: cfe/trunk/test/CodeGen/avx-builtins.c Modified: cfe/trunk/test/CodeGen/avx-builtins.c URL:

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Hi, Ping. The issue in the current implementation of the libc++abi library looks like a time bomb. Even though its probability could be considered as very low, in fact, it depends on the type of an application. At least, we ran into it in our environment. I'd guess t

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

NoQ added a comment. Whoops, forgot to answer: In https://reviews.llvm.org/D23112#508333, @xazax.hun wrote: > I am not sure that the checker is the appropriate way to fix the remaining > issue with this checker. Yeah, there are anyway more problems that require this functionality in the `Ran

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 67500. danielmarjamaki added a comment. Fix patch so it can be applied in latest trunk. Tried to fix review comments. https://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/NonConstParameterCheck.cpp

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki marked 10 inline comments as done. Comment at: test/clang-tidy/readability-non-const-parameter.cpp:117-135 @@ +116,21 @@ +// CHECK-MESSAGES: :[[@LINE+1]]:18: warning: pointer parameter 'p' can be +int return1(int *p) { + // CHECK-FIXES: {{^}}int return1(const int

Re: [PATCH] D23346: [OpenCL] Change block descriptor address space to constant

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D23346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 67501. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D23158 Files: test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassSimpleRenaming.cpp test/clang-rename/ClassTestMulti.c

Re: r278139 - [clang-cl] Make -gline-tables-only imply -gcodeview

Since this flag is new in 3.9, should we merge this there? On Tue, Aug 9, 2016 at 1:23 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Tue Aug 9 12:23:56 2016 > New Revision: 278139 > > URL: http://llvm.org/viewvc/llvm-project?rev=278139&view=rev > Lo

r278213 - [ASTMatchers] Extend documentation for match()

Author: mboehme Date: Wed Aug 10 06:22:57 2016 New Revision: 278213 URL: http://llvm.org/viewvc/llvm-project?rev=278213&view=rev Log: [ASTMatchers] Extend documentation for match() Summary: Adds an explanation of how to use findAll() to find all matches in a subtree. Modified: cfe/trunk/incl

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 67504. danielmarjamaki added a comment. fixed more review comments https://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/NonConstParameterCheck.cpp clang-tidy/readability/NonConstParameterCheck.h

r278209 - [X86][AVX512] lower __mm512_andnot_ps/__mm512_andnot_pd to IR

Author: lsaba Date: Wed Aug 10 05:34:45 2016 New Revision: 278209 URL: http://llvm.org/viewvc/llvm-project?rev=278209&view=rev Log: [X86][AVX512] lower __mm512_andnot_ps/__mm512_andnot_pd to IR Differential revision: https://reviews.llvm.org/D23262 Modified: cfe/trunk/lib/Headers/avx512dqin

Re: [PATCH] D23262: lower __mm512_andnot_ps/__mm512_andnot_pd to IR

This revision was automatically updated to reflect the committed changes. Closed by commit rL278209: [X86][AVX512] lower __mm512_andnot_ps/__mm512_andnot_pd to IR (authored by lsaba). Changed prior to commit: https://reviews.llvm.org/D23262?vs=67152&id=67502#toc Repository: rL LLVM https://

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki marked 2 inline comments as done. Comment at: test/clang-tidy/readability-non-const-parameter.cpp:245 @@ +244,3 @@ + C c(p); +} + I have added tests and fixed FPs in latest diff. Comment at: test/clang-tidy/readability-non-const-

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D17990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 67506. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. added this check to the release notes. run clang-format. https://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readabilit

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

aaron.ballman added a comment. Good catch! Some small nits. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:32-33 @@ -31,1 +31,4 @@ + // It is possible to make smart ptr calling private ctor inside of a member + // function. Change to make_smart_ptr will be invalid. +

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/readability-else-after-return.rst:8 @@ +7,3 @@ +reduce indentation where possible and where it makes understanding code easier. +Early exit is one of the suggested enforcement of that. Please do not use `else

Re: [PATCH] D23158: [clang-rename] merge tests when possible

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you! https://reviews.llvm.org/D23158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:79 @@ -69,3 +78,3 @@ fo

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

alexfh added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:40 @@ +39,3 @@ + for (const auto *BindingName : {"return", "continue", "break", "throw"}) { +if (Result.Nodes.getNodeAs(BindingName)) { + ControlFlowInterruptor = BindingName; -

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/readability-else-after-return.rst:14 @@ -8,2 +13,3 @@ -http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return +``` c++ +void foo(int Value) { alexfh wrote: > aaron.ballman w

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

omtcyfz updated this revision to Diff 67512. omtcyfz marked 4 inline comments as done. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D23265 Files: clang-tidy/readability/ElseAfterReturnCheck.cpp docs/clang-tidy/checks/readability-else-after-return.rst test/clang-tidy

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! https://reviews.llvm.org/D23265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

omtcyfz updated this revision to Diff 67513. omtcyfz added a comment. Remove braces around single statement in `for` and `if` as Alex proposed. https://reviews.llvm.org/D23265 Files: clang-tidy/readability/ElseAfterReturnCheck.cpp docs/clang-tidy/checks/readability-else-after-return.rst t

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 67515. omtcyfz added a comment. Update files not previouysly added with `git add`. https://reviews.llvm.org/D23158 Files: test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp test/clang-rename/ClassAsT

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 67516. omtcyfz added a comment. Delete two more files. https://reviews.llvm.org/D23158 Files: test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp test/clang-rename/ClassAsTemplateArgumentFindByTemplat

[clang-tools-extra] r278221 - [clang-rename] merge tests when possible

Author: omtcyfz Date: Wed Aug 10 08:28:30 2016 New Revision: 278221 URL: http://llvm.org/viewvc/llvm-project?rev=278221&view=rev Log: [clang-rename] merge tests when possible The only difference between some tests is -offset passed to clang-rename. It makes sense to merge them into a single file

Re: [PATCH] D23158: [clang-rename] merge tests when possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL278221: [clang-rename] merge tests when possible (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D23158?vs=67516&id=67517#toc Repository: rL LLVM https://reviews.llvm.org/D2

[clang-tools-extra] r278223 - [clang-rename] remove bunch of deprecated tests

Author: omtcyfz Date: Wed Aug 10 08:32:37 2016 New Revision: 278223 URL: http://llvm.org/viewvc/llvm-project?rev=278223&view=rev Log: [clang-rename] remove bunch of deprecated tests Removed: clang-tools-extra/trunk/test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp clang-tools-ext

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme added a comment. Now that https://reviews.llvm.org/D23004 is submitted, can you take another look? https://reviews.llvm.org/D0 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang-tools-extra] r278225 - [clang-rename] fix test introduced in r278221

Author: omtcyfz Date: Wed Aug 10 08:46:36 2016 New Revision: 278225 URL: http://llvm.org/viewvc/llvm-project?rev=278225&view=rev Log: [clang-rename] fix test introduced in r278221 Modified: clang-tools-extra/trunk/test/clang-rename/ComplicatedClassType.cpp Modified: clang-tools-extra/trunk/t

Re: [clang-tools-extra] r278221 - [clang-rename] merge tests when possible

On Wed, Aug 10, 2016 at 9:28 AM, Kirill Bobyrev via cfe-commits wrote: > Author: omtcyfz > Date: Wed Aug 10 08:28:30 2016 > New Revision: 278221 > > URL: http://llvm.org/viewvc/llvm-project?rev=278221&view=rev > Log: > [clang-rename] merge tests when possible > > The only difference between some t

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

klimek added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:892 @@ -891,1 +891,3 @@ + else +TRY_TO(TraverseStmt(LE->capture_init_begin()[C - LE->capture_begin()])); return true; I'd rather pass in the offset than doing math with what'

Re: [clang-tools-extra] r278221 - [clang-rename] merge tests when possible

On Wed, Aug 10, 2016 at 9:54 AM, Aaron Ballman wrote: > On Wed, Aug 10, 2016 at 9:28 AM, Kirill Bobyrev via cfe-commits > wrote: >> Author: omtcyfz >> Date: Wed Aug 10 08:28:30 2016 >> New Revision: 278221 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=278221&view=rev >> Log: >> [clang-rename

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

omtcyfz added a subscriber: omtcyfz. Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:79 @@ -69,3 +78,3 @@ for (const auto &KeyValue : std::vector>( {{"fenv.h", "cfenv"}, aaron.ballman wrote: > This will definitely fail in M

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:79 @@ -69,3 +78,3 @@ for (const auto &KeyValue : std::vector>( {{"fenv.h", "cfenv"}, omtcyfz wrote: > aaron.ballman wrote: > > This will d

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

sbenza added inline comments. Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:64 @@ +63,3 @@ +void MoveForwardingReferenceCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus11) +return; I'm guessing this is checking Lang

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

omtcyf0 updated this revision to Diff 67519. omtcyf0 added a comment. Address comments. https://reviews.llvm.org/D17990 Files: clang-tidy/modernize/DeprecatedHeadersCheck.cpp docs/clang-tidy/checks/modernize-deprecated-headers.rst test/clang-tidy/modernize-deprecated-headers-cxx03.cpp t

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

omtcyf0 marked an inline comment as done. omtcyf0 added a comment. https://reviews.llvm.org/D17990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

omtcyfz added a comment. In https://reviews.llvm.org/D23279#510234, @alexshap wrote: > > I do think that an automated tool will do a better job of changing field > > orderings in a non-breaking way than most people would, mostly due to > > initializer lists. > > > yeah, that was the original mo

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:64 @@ +63,3 @@ +void MoveForwardingReferenceCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus11) +return; sbenza wrote: > I'm guessin

Re: [PATCH] D23331: Implement LWG 2148: Make non-enum default hash specialization well-formed

mclow.lists added a comment. This looks good to me. However, we don't //usually// change libc++ for issue resolutions that have not yet adopted. We wait until they've "official". https://reviews.llvm.org/D23331 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D23279: clang-reorder-fields

bcraig added a comment. In https://reviews.llvm.org/D23279#511187, @omtcyfz wrote: > In https://reviews.llvm.org/D23279#510234, @alexshap wrote: > > > > I do think that an automated tool will do a better job of changing field > > > orderings in a non-breaking way than most people would, mostly d

[PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. The check warns if an object is used after it has been moved, without an intervening reinitialization. See user-facing documentation for details. https://reviews.llvm.org/D23353 Files: cl

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme added a comment. Apologies for the size of this patch. alexfh@ said he was willing to review it as-is -- however, I'm happy to resubmit in smaller pieces if necessary. https://reviews.llvm.org/D23353 ___ cfe-commits mailing list cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

omtcyfz added a comment. In https://reviews.llvm.org/D23279#511202, @bcraig wrote: > In https://reviews.llvm.org/D23279#511187, @omtcyfz wrote: > > > In https://reviews.llvm.org/D23279#510234, @alexshap wrote: > > > > > > I do think that an automated tool will do a better job of changing > > > >

r278234 - [OpenCL] Change block descriptor address space to constant.

Author: joey Date: Wed Aug 10 10:57:02 2016 New Revision: 278234 URL: http://llvm.org/viewvc/llvm-project?rev=278234&view=rev Log: [OpenCL] Change block descriptor address space to constant. The block descriptor is a GlobalVariable in the LLVM IR, so it shouldn't be in the private address space.

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

fowles added a subscriber: fowles. Comment at: test/clang-tidy/misc-use-after-move.cpp:158 @@ +157,3 @@ +std::move(ptr); +ptr.get(); + } would this warn on: std::unique_ptr ptr; std::move(ptr); ptr->Foo(); I would like it to since that is a likely segfa

Re: [PATCH] D23346: [OpenCL] Change block descriptor address space to constant

joey closed this revision. joey added a comment. Committed r278234. 2 years since my last commit! Repository: rL LLVM https://reviews.llvm.org/D23346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: Modify MallocChecker.cpp to recognize kfree( )

Hey, that's a useful patch, i'd like it to be included! There is odd indentation in some places, but in general it looks correct. The usual thing to do nowadays is to put patches on review on Phabricator, would you like to do that? (http://llvm.org/docs/Phabricator.html, http://llvm.org/docs/

r278235 - [OpenCL] Fix typo in test that I accidentally introduced in my previous commit.

Author: joey Date: Wed Aug 10 11:04:14 2016 New Revision: 278235 URL: http://llvm.org/viewvc/llvm-project?rev=278235&view=rev Log: [OpenCL] Fix typo in test that I accidentally introduced in my previous commit. Modified: cfe/trunk/test/CodeGenOpenCL/cl20-device-side-enqueue.cl Modified: cfe/

Re: [PATCH] D23320: [analyzer] Fixed crash in CloneDetector in function calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278238: [analyzer] Fix a crash in CloneDetector when calling functions by pointers. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23320?vs=67345&id=67537#toc Repository:

Re: r278139 - [clang-cl] Make -gline-tables-only imply -gcodeview

Sure, r278240. On Wed, Aug 10, 2016 at 3:55 AM, Nico Weber wrote: > Since this flag is new in 3.9, should we merge this there? > > On Tue, Aug 9, 2016 at 1:23 PM, Reid Kleckner via cfe-commits > wrote: >> >> Author: rnk >> Date: Tue Aug 9 12:23:56 2016 >> New Revision: 278139 >> >> URL: http://

r278238 - [analyzer] Fix a crash in CloneDetector when calling functions by pointers.

Author: dergachev Date: Wed Aug 10 11:25:16 2016 New Revision: 278238 URL: http://llvm.org/viewvc/llvm-project?rev=278238&view=rev Log: [analyzer] Fix a crash in CloneDetector when calling functions by pointers. CallExpr may have a null direct callee when the callee function is not known in compi

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

NoQ added a comment. Wow, i've completely forgot about this one. Sorry about that... I think this checker is good to have in the current shape, and probably incrementally developed. It'd probably move out of alpha whenever it's tweaked to somehow make sure it finds enough real bugs among intent

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

Prazek added a subscriber: Prazek. Prazek added a reviewer: Prazek. Prazek added a comment. I will review it later, but my first thoughts: 1. I think we should make some other group, because misc seems to be overloaded. I discussed it with Alex months ago - something like bugprone would be good

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek added inline comments. Comment at: test/clang-tidy/modernize-make-shared.cpp:109 @@ +108,3 @@ + void create() { +auto ptr = std::shared_ptr(new Private(42)); + } aaron.ballman wrote: > Add comments explaining why make_shared is not correct. Also, plea

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

RE: r278234 - [OpenCL] Change block descriptor address space to constant.

Hi Hans, Is it still possible to merge this change in release 3.9 branch. This is just a minor bug fix we have found with Clang Blocks and only affects OpenCL. PS, it goes together with a typo fix in the next commit r278235. Thanks in advance, Anastasia -Original Message- From: cfe-com

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

alexfh added inline comments. Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:83 @@ +82,3 @@ + for (const auto &Key : DeleteHeaders) { +DeleteHeadersSet.insert(Key); + } No danger of dangling references here, since `StringMap` copies keys. See `

Re: r278234 - [OpenCL] Change block descriptor address space to constant.

Merged together with r278235 in r278248. Thanks, Hans On Wed, Aug 10, 2016 at 10:25 AM, Anastasia Stulova via cfe-commits wrote: > Hi Hans, > > Is it still possible to merge this change in release 3.9 branch. This is just > a minor bug fix we have found with Clang Blocks and only affects OpenCL

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

omtcyf0 updated this revision to Diff 67551. omtcyf0 marked an inline comment as not done. omtcyf0 added a comment. Revert changes. https://reviews.llvm.org/D17990 Files: clang-tidy/modernize/DeprecatedHeadersCheck.cpp docs/clang-tidy/checks/modernize-deprecated-headers.rst test/clang-tid

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

alexfh added a comment. In https://reviews.llvm.org/D17990#511424, @omtcyf0 wrote: > Revert changes. Thanks! If Aaron has no objections, good to go. https://reviews.llvm.org/D17990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] trivial documentation fix regarding Obj-C ARC objc_arc_weak_reference_unavailable

Fixed incorrect docs that referred to: objc_arc_weak_unavailable when it should be: objc_arc_weak_reference_unavailable Cheers, Sean objc_arc_weak_unavailable-typo.patch Description: Binary data ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

omtcyf0 added a comment. In https://reviews.llvm.org/D17990#511429, @alexfh wrote: > In https://reviews.llvm.org/D17990#511424, @omtcyf0 wrote: > > > Revert changes. > > > Thanks! If Aaron has no objections, good to go. Great! Thank you! https://reviews.llvm.org/D17990

Re: [PATCH] D23279: clang-reorder-fields

bcraig added a comment. In https://reviews.llvm.org/D23279#511266, @omtcyfz wrote: > In https://reviews.llvm.org/D23279#511202, @bcraig wrote: > > > In https://reviews.llvm.org/D23279#511187, @omtcyfz wrote: > > > > > In https://reviews.llvm.org/D23279#510234, @alexshap wrote: > > > > > > > > I d

Re: [PATCH] D23279: clang-reorder-fields

omtcyf0 added a subscriber: omtcyf0. omtcyf0 added a comment. In https://reviews.llvm.org/D23279#511439, @bcraig wrote: > I will agree that compilation databases are a (mostly) necessary, but not > sufficient part of the solution. The refactoring tool will need to be > careful about changing t

[PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

yaxunl created this revision. yaxunl added reviewers: nhaustov, Anastasia. yaxunl added subscribers: cfe-commits, tstellarAMD. Pointers of certain GPUs in AMDGCN target in private address space is 32 bit but pointers in other address spaces are 64 bit. size_t type should be defined as 64 bit for

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/ReleaseNotes.rst:75 @@ +74,3 @@ + + This check warns if an object is used after it has been moved, without an + intervening reinitialization. Please remove //This check// and capitalize //warns/

[clang-tools-extra] r278254 - [clang-tidy] minor improvements in modernise-deprecated-headers check

Author: omtcyfz Date: Wed Aug 10 13:01:45 2016 New Revision: 278254 URL: http://llvm.org/viewvc/llvm-project?rev=278254&view=rev Log: [clang-tidy] minor improvements in modernise-deprecated-headers check This patch introduces a minor list of changes as proposed by Richard Smith in the mailing lis

[clang-tools-extra] r278255 - [Documentation] Fix grammar mistakes in docs/clang-tidy/index.rst spotted by Alexander Kornienko.

Author: eugenezelenko Date: Wed Aug 10 13:02:15 2016 New Revision: 278255 URL: http://llvm.org/viewvc/llvm-project?rev=278255&view=rev Log: [Documentation] Fix grammar mistakes in docs/clang-tidy/index.rst spotted by Alexander Kornienko. Modified: clang-tools-extra/trunk/docs/clang-tidy/inde

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

This revision was automatically updated to reflect the committed changes. Closed by commit rL278254: [clang-tidy] minor improvements in modernise-deprecated-headers check (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D17990?vs=67551&id=67560#toc Repository: rL LLVM

[clang-tools-extra] r278257 - [clang-tidy] enhance readability-else-after-return

Author: omtcyfz Date: Wed Aug 10 13:05:47 2016 New Revision: 278257 URL: http://llvm.org/viewvc/llvm-project?rev=278257&view=rev Log: [clang-tidy] enhance readability-else-after-return `readability-else-after-return` only warns about `return` calls, but LLVM Coding Standars stat that `throw`, `co

Re: [PATCH] D23265: [clang-tidy] enhance readability-else-after-return

This revision was automatically updated to reflect the committed changes. Closed by commit rL278257: [clang-tidy] enhance readability-else-after-return (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D23265?vs=67513&id=67561#toc Repository: rL LLVM https://reviews.l

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added a comment. In https://reviews.llvm.org/D23125#510632, @rsmith wrote: > This doesn't seem like quite the right user interface for this feature. The > module cache is volatile, and it's not really reasonable for people to assume > they know what is and isn't within it. Instead, it

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/ReleaseNotes.rst:78 @@ -77,1 +77,3 @@ +- Bugfix for `modernize-make-unique + `_ I think will be better to have //Fixed

[clang-tools-extra] r278262 - [Release Notes] Consistency in Clang-tidy entries' style.

Author: eugenezelenko Date: Wed Aug 10 13:15:51 2016 New Revision: 278262 URL: http://llvm.org/viewvc/llvm-project?rev=278262&view=rev Log: [Release Notes] Consistency in Clang-tidy entries' style. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

aaron.ballman added inline comments. Comment at: test/clang-tidy/modernize-make-shared.cpp:109 @@ +108,3 @@ + void create() { +auto ptr = std::shared_ptr(new Private(42)); + } Prazek wrote: > aaron.ballman wrote: > > Add comments explaining why make_shared i

  1   2   >