The members are references, pointers and a bool. None of them requires
moving as they're trivially copyable. We actually have a clang-tidy
check to remove std::move in those cases.
On Mon, Aug 8, 2016 at 3:18 AM, Piotr Padlewski
wrote:
>
>
> 2016-08-06 5:45 GMT-07:00 Benjamin Kramer via cfe-commi
xazax.hun updated this revision to Diff 67129.
xazax.hun marked an inline comment as done.
xazax.hun added a comment.
- Changes according to the review comments.
https://reviews.llvm.org/D23060
Files:
include/clang/Driver/CC1Options.td
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
i
omtcyfz added a comment.
Ah, and yes, it's better to move `*.yaml` to `extra/test/clang-rename/Inputs`
in order to prevent confusion as every other file in `extra/test/clang-rename`
is a test.
https://reviews.llvm.org/D23198
___
cfe-commits mailin
Author: rovka
Date: Mon Aug 8 03:27:36 2016
New Revision: 277985
URL: http://llvm.org/viewvc/llvm-project?rev=277985&view=rev
Log:
Fix two bugs for musl-libc on ARM
Bug 1: triples like armv7-pc-linux-musl use the wrong linker name
ld-musl-armv7.so.1; the right name should be ld-musl-arm.so.1, di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277985: Fix two bugs for musl-libc on ARM (authored by
rovka).
Changed prior to commit:
https://reviews.llvm.org/D22904?vs=66074&id=67131#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22904
Fil
rovka added a subscriber: rovka.
rovka added a comment.
Hi Lei,
Renato is on vacation, so I committed this for you.
Regards,
Diana
Repository:
rL LLVM
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
xazax.hun updated this revision to Diff 67135.
xazax.hun added a comment.
- Address review comments.
https://reviews.llvm.org/D23112
Files:
lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp
test/Analysis/out-of-bounds.c
Index: test/Analysis/out-of-bounds.c
===
xazax.hun added a comment.
I am not sure that the checker is the appropriate way to fix the remaining
issue with this checker. I think generating simpler constraints without loosing
any generality is non trivial.
https://reviews.llvm.org/D23112
__
xazax.hun added a comment.
What do you think about escaping pointers that gone through conservatively
evaluated casts?
https://reviews.llvm.org/D23014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: xazax
Date: Mon Aug 8 04:22:59 2016
New Revision: 277989
URL: http://llvm.org/viewvc/llvm-project?rev=277989&view=rev
Log:
[analyzer] Model base to derived casts more precisely.
Dynamic casts are handled relatively well by the static analyzer.
BaseToDerived casts however are treated cons
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277989: [analyzer] Model base to derived casts more
precisely. (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D23014?vs=66632&id=67136#toc
Repository:
rL LLVM
https://reviews
ioeric created this revision.
ioeric added reviewers: alexfh, hokein.
ioeric added a subscriber: cfe-commits.
tooling::Replacements only holds replacements for a single file, so
this patch makes Fix a map from file paths to tooling::Replacements so that it
can be applied on multiple files.
https:
Anastasia added a comment.
In https://reviews.llvm.org/D23086#507360, @yaxunl wrote:
> In https://reviews.llvm.org/D23086#507203, @yaxunl wrote:
>
> > How about assuming ndrange_t is a struct type defined by user and identify
> > it by struct type name in Clang? This gives user freedom of implem
hokein added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:66
@@ -66,1 +65,3 @@
+ // Fixes grouped by file path.
+ std::map Fix;
SmallVector Notes;
Use llvm::StringMap here?
https://reviews.llvm.org/D23257
vbyakovl set the repository for this revision to rL LLVM.
vbyakovl updated this revision to Diff 67140.
Repository:
rL LLVM
https://reviews.llvm.org/D21678
Files:
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/Sema/shift.c
Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp
==
danielmarjamaki added inline comments.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:43
@@ +42,3 @@
+
+static StringRef getAsString(const MatchFinder::MatchResult &Result,
+ const Expr *E) {
alexfh wrote:
> Looks like
danielmarjamaki set the repository for this revision to rL LLVM.
danielmarjamaki updated this revision to Diff 67144.
danielmarjamaki added a comment.
Fixed review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D21134
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readab
danielmarjamaki removed rL LLVM as the repository for this revision.
danielmarjamaki updated this revision to Diff 67145.
danielmarjamaki added a comment.
Cleanup my previous commit. Ran clang-format.
https://reviews.llvm.org/D21134
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/re
vbyakovl added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8597
@@ -8596,4 +8596,3 @@
///by a scalar or vector shift amount.
-static QualType checkOpenCLVectorShift(Sema &S,
- ExprResult &LHS, ExprResult &RHS,
aaron.ballman added a comment.
In https://reviews.llvm.org/D22725#506058, @JDevlieghere wrote:
> - Added function pointer test case
> - Used placeholders for diagnostics
>
> I extended the matchers to include `::memcpy` and `::memset` as well
> because the check otherwise does not work on my m
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Assuming others are fine with hasAnyDeclaration() vs canReferToDecl(), LGTM! If
others feel strongly about canReferToDecl() instead, it still LGTM.
https://reviews.llvm.org/D230
ABataev added a comment.
Ping
https://reviews.llvm.org/D22955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.
ioeric added reviewers: klimek, djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D23264
Files:
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/Refactoring
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D23264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: xazax
Date: Mon Aug 8 08:41:04 2016
New Revision: 278006
URL: http://llvm.org/viewvc/llvm-project?rev=278006&view=rev
Log:
[analyzer] Command line option to show enabled checker list.
This patch adds a command line option to list the checkers that were enabled
by analyzer-checker and not
Author: ioeric
Date: Mon Aug 8 08:37:39 2016
New Revision: 278004
URL: http://llvm.org/viewvc/llvm-project?rev=278004&view=rev
Log:
Fixes calculateRangesAfterReplacements crash when Replacements is empty.
Reviewers: klimek, djasper
Subscribers: cfe-commits, klimek
Differential Revision: https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278004: Fixes calculateRangesAfterReplacements crash when
Replacements is empty. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D23264?vs=67155&id=67156#toc
Repository:
rL LL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278006: [analyzer] Command line option to show enabled
checker list. (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D23060?vs=67129&id=67157#toc
Repository:
rL LLVM
https://r
alexfh added a comment.
Thanks, that's better. Still a couple of comments.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:50
@@ +49,3 @@
+ diag(ArraySubscriptE->getLocStart(),
+ "unusual array index syntax, usually the index is inside the []");
+
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
Is there a reason we don't want this check to be a part of the clang frontend,
rather than as a clang-tidy check?
Comment at: clang-tidy/readability/Mi
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/ClangTidy.cpp:129
@@ -128,22 +128,3 @@
<< Message.Message << Name;
- for (const tooling::Replacement &Fix : Error.Fix) {
-// Retrieve th
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
I think the replacement is wrong for something like:
int *arr; int offs1, offs2;
offs1[arr + offs2] = 42;
which I think would give:
int *arr; int offs1, offs2;
arr + offs2[offs1] = 42;
If the precedence of the "indexing"
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Wait, please add a test.
https://reviews.llvm.org/D23193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-rename/USRFinder.cpp:100
@@ +99,3 @@
+ if (const clang::FieldDecl *FieldDecl = Initializer->getMember()) {
+const auto InitBeginL
omtcyfz created this revision.
omtcyfz added a reviewer: alexfh.
omtcyfz added a subscriber: cfe-commits.
`readability-else-after-return` only warns about `return` calls, but [[
http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return |
Coding Stadnards ]] mention `throw`, `contin
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:38-40
@@ -34,2 +37,5 @@
SourceLocation ElseLoc = If->getElseLoc();
- DiagnosticBuilder Diag = diag(ElseLoc, "don't use el
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:41
@@ +40,3 @@
+ // using anyOf(BINDLITERAL(), anything()).
+ anyOf(hasTrueExpression(ignoringParenImpCasts(
+
ioeric updated this revision to Diff 67164.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Addressed reviewers' comments.
https://reviews.llvm.org/D23257
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:41
@@ +40,3 @@
+ // using anyOf(BINDLITERAL(), anything()).
+ anyOf(hasTrueExpression(ignoringParenImpCasts(
+integerLiteral().bind("trueBranchLiter
omtcyfz updated this revision to Diff 67165.
omtcyfz added a comment.
Do these symbolic pointers seem reasonable?
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/Field.cpp
===
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
Previously, if we pass multiple files or a file pattern (e.g. /path/to/*.cc) to
include-fixer, include-fixer will apply all replacements to the first argument,
which probably causes crashes.
Wi
omtcyfz updated this revision to Diff 67169.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Use shiny `eachOf` and bind everything to `"literal"` value.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:41
@@ +40,3 @@
+ // using anyOf(BINDLITERAL(), anything()).
+ anyOf(hasTrueExpression(ignoringParenImpCasts(
+integerLiteral().bind("trueBranchLiteral")))
hokein updated this revision to Diff 67171.
hokein added a comment.
Remove unneeded header.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/C
hokein updated this revision to Diff 67172.
hokein added a comment.
Add missing tests.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangI
aaron.ballman added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8681-8683
@@ -8680,5 +8676,3 @@
}
-return CheckVectorOperands(LHS, RHS, Loc, IsCompAssign,
- /*AllowBothBool*/true,
- /*Allo
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:59
@@ -57,1 +58,3 @@
"modernize-use-bool-literals");
+CheckFactories.registerCheck(
+"modernize-use-algorithm");
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:38-40
@@ -34,2 +37,5 @@
SourceLocation ElseLoc = If->getElseLoc();
- DiagnosticBuilder Diag = diag(ElseLoc, "don't use else aft
bkramer added a comment.
Can you add a lit test for this? We should've added that earlier :|
Comment at: include-fixer/IncludeFixer.h:53
@@ -51,2 +52,3 @@
/// The context that contains all information about the symbol being queried.
+ std::vector &Contexts;
---
I'm still (as per another similar thread) a bit concerned this is working
around a compiler optimizer bug - I'd love to see a standalone example of
this behavior (that adding the inline keyword to an already
inline/available definition is what's causing the inlining) so we can look
at what the comp
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:59-61
@@ +58,5 @@
+ IncludeStyle(utils::IncludeSorter::parseIncludeStyle(
+ Options.get("IncludeStyle", "llvm"))) {
+
+ for (const auto &KeyValue :
+ {std::make_pair("m
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
This seems to have a lot of overlap with -Wmissing-prototype, really - what
do you think of the overlap/distinction between the two?
On Wed, Aug 3, 2016 at 1:25 PM Eugene Zelenko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Eugene.Zelenko added a subscriber: Eugene.Zelenko.
> Eugene.Zel
On Wed, Aug 3, 2016 at 4:13 PM Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: alexfh
> Date: Wed Aug 3 18:06:03 2016
> New Revision: 277677
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277677&view=rev
> Log:
> [clang-tidy] Inefficient string operation
>
A
Author: olista01
Date: Mon Aug 8 10:28:40 2016
New Revision: 278016
URL: http://llvm.org/viewvc/llvm-project?rev=278016&view=rev
Log:
[ARM] Command-line options for embedded position-independent code
This patch (with the corresponding ARM backend patch) adds support for
some new relocation model
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278016: [ARM] Command-line options for embedded
position-independent code (authored by olista01).
Changed prior to commit:
https://reviews.llvm.org/D23196?vs=66921&id=67176#toc
Repository:
rL LLVM
h
-Wmissing-prototype only warns for functions, I want to catch classes
too. Also functions in the global namespace with a prototype are still
badness in some coding styles. The limitation on definitions was to
cut down on false positives, the current version of the patch doesn't
have that limitation
hjl.tools added a comment.
In https://reviews.llvm.org/D22045#506996, @joerg wrote:
> For what it is worth, this certainly seems to be misnamed. By nature, if it
> doesn't preserve at least the stack pointer, there is no way to recover on
> return, right?
This is the best name we came up with
alexfh added a comment.
In https://reviews.llvm.org/D21134#508524, @jroelofs wrote:
> I think the replacement is wrong for something like:
>
> int *arr; int offs1, offs2;
> offs1[arr + offs2] = 42;
>
>
> which I think would give:
>
> int *arr; int offs1, offs2;
> arr + offs2[offs1] = 42;
aaron.ballman added a comment.
In https://reviews.llvm.org/D22045#508644, @hjl.tools wrote:
> In https://reviews.llvm.org/D22045#506996, @joerg wrote:
>
> > For what it is worth, this certainly seems to be misnamed. By nature, if it
> > doesn't preserve at least the stack pointer, there is no wa
erichkeane added a comment.
In https://reviews.llvm.org/D22045#508648, @aaron.ballman wrote:
> In https://reviews.llvm.org/D22045#508644, @hjl.tools wrote:
>
> > In https://reviews.llvm.org/D22045#506996, @joerg wrote:
> >
> > > For what it is worth, this certainly seems to be misnamed. By nature
hokein added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1
@@ +1,2 @@
+#include
+
Usually test should not use STL headers as it relies on the system headers.
You don't have to use std::string to reproduce the cra
hokein added a comment.
> Can you add a lit test for this? We should've added that earlier :|
I forgot to upload the test first time. But I have already uploaded it, see
`multiple_fixes.cpp`
Comment at: include-fixer/IncludeFixerContext.h:78
@@ -72,1 +77,3 @@
+ /// \brief
NoQ added a comment.
Hmm. The test in `unwanted-programstate-data-propagation.c` passes on my
machine even without the patch, and the return value on the respective path is
correctly represented as `(conj_$6{void *}) != 0U`, which comes from the
`evalCast()` call in `VisitLogicalExpr()` and is
hjl.tools added a comment.
In https://reviews.llvm.org/D22045#508648, @aaron.ballman wrote:
> In https://reviews.llvm.org/D22045#508644, @hjl.tools wrote:
>
> > In https://reviews.llvm.org/D22045#506996, @joerg wrote:
> >
> > > For what it is worth, this certainly seems to be misnamed. By nature,
alexfh added inline comments.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:48
@@ +47,3 @@
+
+ auto D =
+ diag(ArraySubscriptE->getLocStart(),
aaron.ballman wrote:
> Should not use `auto` here because the type is not spelled out in the
> i
On Mon, Aug 8, 2016 at 11:50 AM, H.J Lu wrote:
> hjl.tools added a comment.
>
> In https://reviews.llvm.org/D22045#508648, @aaron.ballman wrote:
>
>> In https://reviews.llvm.org/D22045#508644, @hjl.tools wrote:
>>
>> > In https://reviews.llvm.org/D22045#506996, @joerg wrote:
>> >
>> > > For what i
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:39
@@ +38,3 @@
+ eachOf(
+ // anyOf() is not evaluating second argument if first is
evaluated
+ /
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:48
@@ +47,3 @@
+
+ auto D =
+ diag(ArraySubscriptE->getLocStart(),
alexfh wrote:
> aaron.ballman wrote:
> > Should not use `auto` here because the type is no
On Mon, Aug 8, 2016 at 8:37 AM Benjamin Kramer wrote:
> -Wmissing-prototype only warns for functions, I want to catch classes
> too.
Ah, fair enough. Yeah, a clang-tidy check for things in the global
namespace that are in a main file rather than a header could be another
pivot there.
> Also f
hokein updated this revision to Diff 67178.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/In
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: include-fixer/IncludeFixerContext.h:78
@@ -72,1 +77,3 @@
+ /// \brief The absolute path to the file being processed.
+ std::string FilePath;
---
alexfh added a comment.
In https://reviews.llvm.org/D23193#508563, @omtcyfz wrote:
> Do these symbolic pointers in test seem reasonable?
Yes, kind of. I'd change these to C-style comments, place them on the same line
with the interesting identifier (probably, right after the identifier), and
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278018: [analyzer] Change -analyze-function to accept
qualified names. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22856?vs=66360&id=67180#toc
Repository:
rL LLVM
htt
alexfh added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1
@@ +1,2 @@
+#include
+
hokein wrote:
> Usually test should not use STL headers as it relies on the system headers.
>
> You don't have to use std::string
NoQ created this revision.
NoQ added reviewers: dcoughlin, zaks.anna.
NoQ added subscribers: xazax.hun, a.sidorin, cfe-commits.
Use the official CSS3 properties `border-radius` and `box-shadow` (not only
`-webkit-`specific properties).
Fixes analyzer's diagnostic pieces in HTML diagnostics mode
a.sidorin added inline comments.
Comment at: lib/Rewrite/HTMLRewrite.cpp:304
@@ -303,2 +303,3 @@
+ " border-radius:5px; box-shadow:1px 1px 7px #000; "
" -webkit-border-radius:5px; -webkit-box-shadow:1px 1px 7px #000; "
"position: absolute; top: -
Okay, merged in r278019.
Cheers,
Hans
On Fri, Aug 5, 2016 at 9:36 AM, Anastasia Stulova
wrote:
> Hans,
>
> If still possible could we merge this into 3.9. It contains just a minor
> renaming but it makes all those new OpenCL Builtins usable.
>
> Thanks,
> Anastasia
>
> -Original Message
I've merged the lot in r278020.
Thanks,
Hans
On Fri, Aug 5, 2016 at 7:43 PM, Hans Wennborg wrote:
> These all sgtm for 3.9. Go ahead and merge with
> utils/release/merge.sh, or I'll do it when I get in on Monday.
>
> Cheers,
> Hans
>
> On Fri, Aug 5, 2016 at 6:52 PM, Richard Trieu wrote:
>> Typ
Author: dergachev
Date: Mon Aug 8 11:01:02 2016
New Revision: 278018
URL: http://llvm.org/viewvc/llvm-project?rev=278018&view=rev
Log:
[analyzer] Change -analyze-function to accept qualified names.
Both -analyze-function and -analyzer-display-progress now share the same
convention for naming fun
Thanks!
-Original Message-
From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
Wennborg
Sent: 08 August 2016 17:40
To: Anastasia Stulova
Cc: Alexey Bader; cfe-commits@lists.llvm.org; nd
Subject: Re: r277743 - [OpenCL] Added underscores to the names of 'to_addr'
Ope
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D23274
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
test/Format/remove-duplicate-includes.cpp
tools/clang-forma
omtcyfz updated this revision to Diff 67189.
omtcyfz added a comment.
Remove redundant `anyOf` and `anything`.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-use-bool-literals.rst
test/clang-tidy/modernize-use-bool-lit
ioeric updated this revision to Diff 67191.
ioeric added a comment.
- Check code that is not in affected range is not reformatted in lit test.
https://reviews.llvm.org/D23274
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
test/Format/remove-duplicate-includes.cpp
tools/clang
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: test/clang-tidy/modernize-use-bool-literals.cpp:124
@@ +123,3 @@
+ bool Result = Value == 1 ? 1 : 0;
+ // CHECK-MESSAGES: :[[@LINE-1]]:30: {{.*}}
ioeric updated this revision to Diff 67193.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Update test to not use
https://reviews.llvm.org/D23257
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Mon Aug 8 12:11:56 2016
New Revision: 278022
URL: http://llvm.org/viewvc/llvm-project?rev=278022&view=rev
Log:
[clang-tidy] enhance modernize-use-bool-literals to check ternary operator
modernize-use-bool-literals doesn't checks operands in ternary operator.
For example:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278022: [clang-tidy] enhance modernize-use-bool-literals to
check ternary operator (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23243?vs=67195&id=67197#toc
Repository:
rL
Author: hans
Date: Mon Aug 8 12:18:56 2016
New Revision: 278023
URL: http://llvm.org/viewvc/llvm-project?rev=278023&view=rev
Log:
Merging r277868:
r277868 | compnerd | 2016-08-05 14:35:28 -0700 (Fri, 05 Aug 2016) | 4 lines
Okay, r278023.
Thanks,
Hans
On Fri, Aug 5, 2016 at 2:46 PM, Saleem Abdulrasool
wrote:
> On Fri, Aug 5, 2016 at 2:35 PM, Saleem Abdulrasool via cfe-commits
> wrote:
>>
>> Author: compnerd
>> Date: Fri Aug 5 16:35:28 2016
>> New Revision: 277868
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev
omtcyfz updated this revision to Diff 67199.
omtcyfz added a comment.
Added more info to the test.
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/Field.cpp
==
omtcyfz updated this revision to Diff 67195.
omtcyfz added a comment.
More strict test messages.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-use-bool-literals.rst
test/clang-tidy/modernize-use-bool-literals.cpp
Ind
Alexander_Droste added a comment.
Great; thanks again for the review!
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D23238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: eugenezelenko
Date: Mon Aug 8 12:56:28 2016
New Revision: 278029
URL: http://llvm.org/viewvc/llvm-project?rev=278029&view=rev
Log:
CMakeLists.txt cleanups: synchronize version and CMake minimum required version
with rest of LLVM, consistent spacing.
Differential revision: https://review
tra added a comment.
I think we need to add `noexcept` for these in c++11.
https://reviews.llvm.org/D23239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenezelenko
Date: Mon Aug 8 12:59:02 2016
New Revision: 278030
URL: http://llvm.org/viewvc/llvm-project?rev=278030&view=rev
Log:
CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent
spacing.
Differential revision: https://reviews.llvm.org/D23092
Modified:
li
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D23240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
1 - 100 of 153 matches
Mail list logo
