aaron.ballman added inline comments. ================ Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:48 @@ +47,3 @@ + + auto D = + diag(ArraySubscriptE->getLocStart(), ---------------- alexfh wrote: > aaron.ballman wrote: > > Should not use `auto` here because the type is not spelled out in the > > initialization. > While in general I agree with this recommendation, `auto Diag = diag(...);` > has almost become an idiom in this code. I'd not worry about obscurity of > `auto` in this context, especially, if the variable is renamed to `Diag`, > which will make its meaning and possible ways of using it clearer. I'm okay with that approach.
https://reviews.llvm.org/D21134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
