NoQ created this revision.
NoQ added reviewers: dcoughlin, zaks.anna.
NoQ added subscribers: xazax.hun, a.sidorin, cfe-commits.
Use the official CSS3 properties `border-radius` and `box-shadow` (not only
`-webkit-`specific properties).
Fixes analyzer's diagnostic pieces in HTML diagnostics mode in Firefox and
other non-webkit browsers.
Before: {F2254935}
After: {F2254934}
Not sure, do we need more reviewers? - it seems that HTMLRewrite is mostly used
in the analyzer. Also, are there html/css gurus around? Cause the best thing i
can do is trust the "a lot of green boxes" feeling at
http://caniuse.com/#feat=border-radius and
http://caniuse.com/#feat=css-boxshadow :)
https://reviews.llvm.org/D23272
Files:
lib/Rewrite/HTMLRewrite.cpp
Index: lib/Rewrite/HTMLRewrite.cpp
===================================================================
--- lib/Rewrite/HTMLRewrite.cpp
+++ lib/Rewrite/HTMLRewrite.cpp
@@ -300,6 +300,7 @@
" .expansion { display: none; }\n"
" .macro:hover .expansion { display: block; border: 2px solid #FF0000; "
"padding: 2px; background-color:#FFF0F0; font-weight: normal; "
+ " border-radius:5px; box-shadow:1px 1px 7px #000; "
" -webkit-border-radius:5px; -webkit-box-shadow:1px 1px 7px #000; "
"position: absolute; top: -1em; left:10em; z-index: 1 } \n"
" .macro { color: darkmagenta; background-color:LemonChiffon;"
@@ -310,7 +311,9 @@
" .num { color:#444444 }\n"
" .line { padding-left: 1ex; border-left: 3px solid #ccc }\n"
" .line { white-space: pre }\n"
+ " .msg { box-shadow:1px 1px 7px #000 }\n"
" .msg { -webkit-box-shadow:1px 1px 7px #000 }\n"
+ " .msg { border-radius:5px }\n"
" .msg { -webkit-border-radius:5px }\n"
" .msg { font-family:Helvetica, sans-serif; font-size:8pt }\n"
" .msg { float:left }\n"
@@ -325,6 +328,7 @@
" .mrange { border-bottom:1px solid #6F9DBE }\n"
" .PathIndex { font-weight: bold; padding:0px 5px; "
"margin-right:5px; }\n"
+ " .PathIndex { border-radius:8px }\n"
" .PathIndex { -webkit-border-radius:8px }\n"
" .PathIndexEvent { background-color:#bfba87 }\n"
" .PathIndexControl { background-color:#8c8c8c }\n"
Index: lib/Rewrite/HTMLRewrite.cpp
===================================================================
--- lib/Rewrite/HTMLRewrite.cpp
+++ lib/Rewrite/HTMLRewrite.cpp
@@ -300,6 +300,7 @@
" .expansion { display: none; }\n"
" .macro:hover .expansion { display: block; border: 2px solid #FF0000; "
"padding: 2px; background-color:#FFF0F0; font-weight: normal; "
+ " border-radius:5px; box-shadow:1px 1px 7px #000; "
" -webkit-border-radius:5px; -webkit-box-shadow:1px 1px 7px #000; "
"position: absolute; top: -1em; left:10em; z-index: 1 } \n"
" .macro { color: darkmagenta; background-color:LemonChiffon;"
@@ -310,7 +311,9 @@
" .num { color:#444444 }\n"
" .line { padding-left: 1ex; border-left: 3px solid #ccc }\n"
" .line { white-space: pre }\n"
+ " .msg { box-shadow:1px 1px 7px #000 }\n"
" .msg { -webkit-box-shadow:1px 1px 7px #000 }\n"
+ " .msg { border-radius:5px }\n"
" .msg { -webkit-border-radius:5px }\n"
" .msg { font-family:Helvetica, sans-serif; font-size:8pt }\n"
" .msg { float:left }\n"
@@ -325,6 +328,7 @@
" .mrange { border-bottom:1px solid #6F9DBE }\n"
" .PathIndex { font-weight: bold; padding:0px 5px; "
"margin-right:5px; }\n"
+ " .PathIndex { border-radius:8px }\n"
" .PathIndex { -webkit-border-radius:8px }\n"
" .PathIndexEvent { background-color:#bfba87 }\n"
" .PathIndexControl { background-color:#8c8c8c }\n"
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
