hokein added inline comments. ================ Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1 @@ +1,2 @@ +#include <string> + ---------------- Usually test should not use STL headers as it relies on the system headers.
You don't have to use std::string to reproduce the crash, IMO. https://reviews.llvm.org/D23257 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits