Re: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"

2016-07-01 Thread Sean Silva via cfe-commits
On Thu, Jun 30, 2016 at 5:30 PM, Robinson, Paul wrote: > Okay, that is peculiar. But I can repro it. If I put either orbis-ld or > orbis-ld.exe co-located with clang.exe, it builds a command line without > the .exe suffix (but using the directory where clang.exe lives). > Yeah, as I described

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-07-01 Thread Justin Lebar via cfe-commits
jlebar added a subscriber: jlebar. jlebar added a comment. Yeah, I'd say that in the absence of a rule, consistency with surrounding code is king. Otherwise we're sending a message when we don't mean to be. I'm not at my machine, but my recollection is that most of the driver uses final sparingl

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-07-01 Thread Justin Lebar via cfe-commits
Yeah, I'd say that in the absence of a rule, consistency with surrounding code is king. Otherwise we're sending a message when we don't mean to be. I'm not at my machine, but my recollection is that most of the driver uses final sparingly. But whatever the convention is we should do that, I thin

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

2016-07-01 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: include-fixer/IncludeFixer.cpp:224 @@ +223,3 @@ + std::string MinimizedFilePath = minimizeInclude( + ((FilePath[0] == '"' || FilePath[0] == '<') ? FilePath + : "\"" + File

Re: [PATCH] D21706: [libcxx] refactor for throw

2016-07-01 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. Generally looks OK to me. There are similar uses in test sources as well, but those can be taken care of separately (I'm hoping to get back to the -fno-exceptions XFAILs soon). http://reviews.llvm.org/D21706 ___ cfe-commi

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

2016-07-01 Thread Alexey Bader via cfe-commits
bader added inline comments. Comment at: lib/Sema/SemaChecking.cpp:6773-6774 @@ -6772,4 +7016,2 @@ -namespace { - /// Structure recording the 'active' range of an integer-valued The con of this change - it will export all the symbols from this unnamed namespac

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

2016-07-01 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 62473. hokein marked 5 inline comments as done. hokein added a comment. Fix review comments. http://reviews.llvm.org/D21603 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/SymbolIndexManager.cpp include-fixer/S

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

2016-07-01 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: include-fixer/IncludeFixer.cpp:258 @@ +257,3 @@ + +// Query the symbol based on C++ name Lookup rules. +// Firstly, lookup the identifier with scoped namespace contexts; If fails, djasper wrote: > Could you add som

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

2016-07-01 Thread Aleksei Sidorin via cfe-commits
a.sidorin marked 5 inline comments as done. a.sidorin added a comment. Thank you for your comments! And sorry for late response after pinging. Comment at: lib/AST/ASTImporter.cpp:2518-2519 @@ +2517,4 @@ +Importer.Import(D->getMessage())); + if (!Message) +return nul

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

2016-07-01 Thread Aleksei Sidorin via cfe-commits
a.sidorin marked 2 inline comments as done. Comment at: lib/AST/ASTImporter.cpp:3363 @@ +3362,3 @@ + + // Determine whether we've already imported this decl. + // FriendDecl is not a NamedDecl so we cannot use localUncachedLookup. a.sidorin wrote: > sepavloff wr

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

2016-07-01 Thread Aleksei Sidorin via cfe-commits
a.sidorin updated this revision to Diff 62474. a.sidorin added a comment. Fix some issues pointed by Serge Pavlov. Serge: putting a check of FriendDecls to `IsStructurallyEquivalent()` seems like a good idea for me, but we need some additional changes for it. `CXXRecodeDecl::getFirstDecl()` is

Re: RFC: Default language standard mode policy

2016-07-01 Thread Andrey Bokhanko via cfe-commits
It doesn't break anything for us and in general the proposal make sense to me. Yours, Andrey = Software Engineer Intel Compiler Team On Wed, Jun 29, 2016 at 10:09 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi all! > > I'd like to establish a policy for Clang's

Re: [PATCH] D20561: Warn when taking address of packed member

2016-07-01 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 added a comment. Ping? Any comment on this? Thank you very much. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

2016-07-01 Thread Anastasia Stulova via cfe-commits
Anastasia updated this revision to Diff 62485. Anastasia marked an inline comment as done. Anastasia added a comment. Undo removal of anonymous namespace and move the position of function definition instead. http://reviews.llvm.org/D20249 Files: include/clang/AST/Type.h include/clang/Basic

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

2016-07-01 Thread Anastasia Stulova via cfe-commits
Anastasia marked an inline comment as done. Anastasia added a comment. http://reviews.llvm.org/D20249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

2016-07-01 Thread John Brawn via cfe-commits
john.brawn added a comment. In http://reviews.llvm.org/D21385#471807, @Ilod wrote: > I gave up after this. I have Pyhton 3.5 64 bits, and was building clang > 32-bits on Windows with Visual Studio 2015 Update 2. python 3 isn't supported when building llvm/clang, according to llvm's CMakeLists

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

2016-07-01 Thread Alexey Bader via cfe-commits
bader added a comment. LGTM! Thanks a lot for working on this. http://reviews.llvm.org/D20249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

2016-07-01 Thread Rudy Pons via cfe-commits
Ilod added a comment. In http://reviews.llvm.org/D21385#472268, @john.brawn wrote: > In http://reviews.llvm.org/D21385#471807, @Ilod wrote: > > > I gave up after this. I have Pyhton 3.5 64 bits, and was building clang > > 32-bits on Windows with Visual Studio 2015 Update 2. > > > python 3 isn't

Re: [PATCH] D21619: [Sema] Implement C++14's DR1579: Prefer moving id-expression out of functions

2016-07-01 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a subscriber: mehdi_amini. mehdi_amini added a comment. Is it also PR23849? Is it dup with PR27785? Repository: rL LLVM http://reviews.llvm.org/D21619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D21907: [AArch64] fix profiling with GNU LINUX on Aarch64

2016-07-01 Thread Brian Rzycki via cfe-commits
brzycki added a comment. I realized after posting this I made a mistake in compilation and test. Because of this clang wasn't properly tested. This patch actually causes "ninja check-all" to fail for non-GNU AArch64 Linux targets. I am able to link with clang using -pg -meabi gnu src.c I'd lik

Re: [PATCH] D21706: [libcxx] refactor for throw

2016-07-01 Thread Noel Grandin via cfe-commits
grandinj added inline comments. Comment at: include/array:209 @@ -211,7 +208,3 @@ if (__n >= _Size) -#ifndef _LIBCPP_NO_EXCEPTIONS -throw out_of_range("array::at"); -#else -assert(!"array::at out_of_range"); -#endif +__libcpp_throw(out_of_range("array:

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

2016-07-01 Thread Vladimir Yakovlev via cfe-commits
vbyakovl updated this revision to Diff 62464. http://reviews.llvm.org/D21678 Files: llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/Sema/shift.c Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp === --- llvm/tools/clang

r274348 - Add postorder traversal support to the RecursiveASTVisitor.

2016-07-01 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Fri Jul 1 08:28:31 2016 New Revision: 274348 URL: http://llvm.org/viewvc/llvm-project?rev=274348&view=rev Log: Add postorder traversal support to the RecursiveASTVisitor. This feature needs to be explicitly enabled by overriding shouldTraversePostOrder() as it has perfor

r274349 - Add forgotten test to r274348.

2016-07-01 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Fri Jul 1 08:30:08 2016 New Revision: 274349 URL: http://llvm.org/viewvc/llvm-project?rev=274349&view=rev Log: Add forgotten test to r274348. Added: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Added: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp URL: http://ll

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

2016-07-01 Thread Vassil Vassilev via cfe-commits
v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r274348 and r274349. http://reviews.llvm.org/D20382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12834: add gcc abi_tag support

2016-07-01 Thread James Y Knight via cfe-commits
jyknight added a subscriber: jyknight. jyknight commandeered this revision. jyknight added a reviewer: stbuehler. jyknight added a comment. I believe this was fully superseded by http://reviews.llvm.org/D17567: [GCC] PR23529 Sema part of attrbute abi_tag support http://reviews.llvm.org/D18035: [G

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-07-01 Thread Kwasi Mensah via cfe-commits
Thanks. For future reference, do these benchmarking tests live some place where I can run them myself in the future? On Thu, Jun 30, 2016 at 2:15 AM, Eric Fiselier wrote: > EricWF accepted this revision. > EricWF added a comment. > This revision is now accepted and ready to land. > > LGTM. I ben

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-07-01 Thread Kwasi Mensah via cfe-commits
kmensah added a comment. Thanks. For future reference, do these benchmarking tests live some place where I can run them myself in the future? Repository: rL LLVM http://reviews.llvm.org/D21510 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

r274352 - [OpenMP] Issue warning if a simd construct nested inside another simd

2016-07-01 Thread Kelvin Li via cfe-commits
Author: kli Date: Fri Jul 1 09:30:25 2016 New Revision: 274352 URL: http://llvm.org/viewvc/llvm-project?rev=274352&view=rev Log: [OpenMP] Issue warning if a simd construct nested inside another simd construct Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Se

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

2016-07-01 Thread Teresa Johnson via cfe-commits
tejohnson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:758 @@ +757,3 @@ + + lto::Config Conf; + if (Error E = thinBackend( Can we pass along -save-temps here (i.e. invoke Conf.addSaveTemps)? http://reviews.llvm.org/D21545 _

RE: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"

2016-07-01 Thread Robinson, Paul via cfe-commits
With some digging I worked out at least part of the history. It's not that we care about PATH per se; the test is making sure that even if you don't have a linker in the package, there's still a file with the right name for clang to find in a place that it would (eventually) look. If you *do*

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

2016-07-01 Thread John Brawn via cfe-commits
john.brawn added a comment. > http://clang.llvm.org/get_started.html doesn't specify a version of Python, > the LLVM webpage only say >= 2.7, and I ran the tests without any problem > with Python 3 (but maybe some tests were automatically skipped?). Also, > Python is also marked as only necessa

r274356 - Driver: support -L for MSVC toolchain under the GNU driver

2016-07-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jul 1 10:36:31 2016 New Revision: 274356 URL: http://llvm.org/viewvc/llvm-project?rev=274356&view=rev Log: Driver: support -L for MSVC toolchain under the GNU driver When not using clang in the CL emulation mode, honour the -L flags as additional library paths to pass

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-07-01 Thread Steve Canon via cfe-commits
scanon added a comment. I agree with Marshall. Aside from the points he raises, this approach looks fine. http://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D21619: [Sema] Implement C++14's DR1579: Prefer moving id-expression out of functions

2016-07-01 Thread Erik Pilkington via cfe-commits
erik.pilkington added a comment. Yes, also PR28096. I marked them as being duplicates on the bugzilla. Repository: rL LLVM http://reviews.llvm.org/D21619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

r274359 - Revert r274348 and r274349 until the Windows failures are fixed.

2016-07-01 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Fri Jul 1 11:07:57 2016 New Revision: 274359 URL: http://llvm.org/viewvc/llvm-project?rev=274359&view=rev Log: Revert r274348 and r274349 until the Windows failures are fixed. Removed: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Modified: cfe/trunk/include/cla

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62506. sfantao added a comment. - Use double instead of triple slash in one comment. http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp ===

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

2016-07-01 Thread John Brawn via cfe-commits
john.brawn added a comment. Commit r274365 should make extract_symbols.py work with Python 3. Repository: rL LLVM http://reviews.llvm.org/D21385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62507. sfantao marked 7 inline comments as done. sfantao added a comment. - Fix comments. - Mark functions properly with const and static. - Remove \brief. http://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp Index:

r274370 - Emit more intrinsics for builtin functions

2016-07-01 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Fri Jul 1 12:38:14 2016 New Revision: 274370 URL: http://llvm.org/viewvc/llvm-project?rev=274370&view=rev Log: Emit more intrinsics for builtin functions This is important for building libclc. Since r273039 tests are failing due to now emitting calls to these functions inste

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-07-01 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r274370 http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21706: [libcxx] refactor for throw

2016-07-01 Thread Weiming Zhao via cfe-commits
weimingz updated this revision to Diff 62515. weimingz marked 5 inline comments as done. weimingz added a comment. fix issues per Noel's suggestion http://reviews.llvm.org/D21706 Files: include/__functional_03 include/__locale include/array include/bitset include/complex include/deq

Re: [cfe-dev] RFC: Default language standard mode policy

2016-07-01 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jun 30, 2016 at 01:41:00PM -0700, Richard Smith wrote: > On Thu, Jun 30, 2016 at 2:02 AM, David Chisnall > wrote: > > > On 29 Jun 2016, at 23:07, Richard Smith via cfe-dev < > > cfe-...@lists.llvm.org> wrote: > > > > > > Yes, those are real problems, but it's not reasonable for us to keep

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62516. sfantao marked an inline comment as done. sfantao added a comment. - Check the OpenMP flags only in one place for purposes of obtaining the runtime kind. http://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td include/

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/Driver/Driver.cpp:464-468 @@ +463,7 @@ + RuntimeName = A->getValue(); +HasCompatibleOpenMP = llvm::StringSwitch(RuntimeName) + .Case("libomp", true) +

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/Driver/Driver.cpp:2416 @@ +2415,3 @@ + /// be collapsed with it. + struct JobActionInfoTy { +// \brief The action this info refers to. ABataev wrote: > I think this can be marked '

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62518. sfantao added a comment. - Add code dropped accidently in the previous diff. http://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/Driver.h lib/Driver/Action.cpp

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62519. sfantao marked an inline comment as done. sfantao added a comment. - Mark class as final and remove \brief from comments. http://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Addressed your comment in the new diff. Also removed `\brief` from the comments. http://reviews.llvm.org/D21845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-07-01 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 62520. pirama added a comment. Reformatted with clang-format for just the parts I added. I ignored clang-format-suggested changes in code unrelated to this patch. Is there a policy or practise on periodically fixing format-related issues? If not, I can forma

r274378 - [libclang] Sync-up the way top-level decls in an ASTUnit are handled with how decls in a DeclContext are handled.

2016-07-01 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Fri Jul 1 14:10:54 2016 New Revision: 274378 URL: http://llvm.org/viewvc/llvm-project?rev=274378&view=rev Log: [libclang] Sync-up the way top-level decls in an ASTUnit are handled with how decls in a DeclContext are handled. rdar://19775013 Modified: cfe/trunk/test

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62523. sfantao marked an inline comment as done. sfantao added a comment. - Use llvm::sys::path::replace_extension to deal with the extension of the linker script. http://reviews.llvm.org/D21847 Files: lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-07-01 Thread Justin Lebar via cfe-commits
jlebar added a comment. Hi, Alexy. Would you mind not asking for 'final' in additional reviews until we've resolved this thread elsewhere? Feel free to find me on IRC if you want to talk about it synchronously. Thanks! http://reviews.llvm.org/D21845 __

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Addressed the comments in the new diff. http://reviews.llvm.org/D21847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

2016-07-01 Thread Felix Berger via cfe-commits
flx updated this revision to Diff 62524. flx marked 5 inline comments as done. flx added a comment. Thanks for the review. I addressed all remaining comments. http://reviews.llvm.org/D20277 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-tidy/performance/UnnecessaryValueP

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

2016-07-01 Thread Felix Berger via cfe-commits
flx added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:34 @@ -29,1 +33,3 @@ +template bool isSetDifferenceEmpty(const S &S1, const S &S2) { + for (const auto &E : S1) alexfh wrote: > +1 to `isSubset`. And please add a comm

r274379 - [Driver] Delete some dead code (NFC)

2016-07-01 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Fri Jul 1 14:41:20 2016 New Revision: 274379 URL: http://llvm.org/viewvc/llvm-project?rev=274379&view=rev Log: [Driver] Delete some dead code (NFC) Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-proje

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62525. sfantao added a comment. - Remove \brief from one comment. http://reviews.llvm.org/D21847 Files: lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c ==

Re: [PATCH] D21706: [libcxx] refactor for throw

2016-07-01 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This is getting close. A nit, and a couple of non-trivial comments. Comment at: include/exception:262 @@ -261,3 +261,3 @@ _LIBCPP_INLINE_VISIBILITY -inline void __libcpp_throw(_Exception const& __e) { +inline __attribute__((noreturn)) void __libcpp

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62528. sfantao marked 3 inline comments as done. sfantao added a comment. - Add default initializers to toolchain arguments key and use range based iterator in Dtor. http://reviews.llvm.org/D21848 Files: include/clang/Driver/Compilation.h include/clang

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: include/clang/Driver/Compilation.h:73 @@ +72,3 @@ + /// architecture, and device offload kind. + struct TCArgsKey { +const ToolChain *TC; ABataev wrote: > 1. 'final' > 2. default initi

[clang-tools-extra] r274380 - [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

2016-07-01 Thread Felix Berger via cfe-commits
Author: flx Date: Fri Jul 1 15:12:15 2016 New Revision: 274380 URL: http://llvm.org/viewvc/llvm-project?rev=274380&view=rev Log: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved. Summary: Make check more useful in the following two cases:

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

2016-07-01 Thread Felix Berger via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274380: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const… (authored by flx). Changed prior to commit: http://reviews.llvm.org/D20277?vs=62524&id=62530#toc Repository: rL LLV

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. In http://reviews.llvm.org/D18172#472152, @jlebar wrote: > Yeah, I'd say that in the absence of a rule, consistency with surrounding > code is king. Otherwise we're sending a message when we don't mean to be. > > I'm not at my machine, but my recollection is that most o

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

2016-07-01 Thread Piotr Padlewski via cfe-commits
Prazek added a reviewer: rsmith. Prazek added a comment. Adding Richard who was working on standard defect report that deprived sense of this check. There are some corner cases that are not in the standard and probably won't be handled in the future that we could handle still. http://reviews.l

Re: [PATCH] D21706: [libcxx] refactor for throw

2016-07-01 Thread Weiming Zhao via cfe-commits
weimingz added inline comments. Comment at: include/exception:262 @@ -261,3 +261,3 @@ _LIBCPP_INLINE_VISIBILITY -inline void __libcpp_throw(_Exception const& __e) { +inline __attribute__((noreturn)) void __libcpp_throw(_Exception const& __e) { #ifndef _LIBCPP_NO_EXCEPTIONS -

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-07-01 Thread Jake VanAdrighem via cfe-commits
jakev updated this revision to Diff 62527. jakev added a comment. Don't allow `-fpgo-train` and `-fpgo-apply` together. Add `-fpgo-train-default-output=*` to set the default profile output file. Repository: rL LLVM http://reviews.llvm.org/D21823 Files: include/clang/Driver/Options.td li

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-07-01 Thread Jake VanAdrighem via cfe-commits
jakev added a comment. In http://reviews.llvm.org/D21823#470516, @xur wrote: > (1) It seems the original options of -fprofile-instr-generate and > -fprofile-instr-use will be kept. Is so, what is the guideline to use these > two sets of options. Sorry I'm not sure I understand what you're ask

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

2016-07-01 Thread Jan Vesely via cfe-commits
jvesely added a subscriber: jvesely. Comment at: cfe/trunk/include/clang/Driver/Options.td:381 @@ +380,3 @@ +def cl_unsafe_math_optimizations : Flag<["-"], "cl-unsafe-math-optimizations">, Group, Flags<[CC1Option]>, + HelpText<"OpenCL only. Allow unsafe floating-point optimizati

[PATCH] D21936: [clang-tidy] UnnecessaryValueParamCheck - only warn for virtual methods

2016-07-01 Thread Felix Berger via cfe-commits
flx created this revision. flx added reviewers: alexfh, sbenza. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. As changing virtual methods could break method overrides disable applying the fix and just warn. Repository: rL LLVM http://reviews.llvm.or

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62538. sfantao marked 9 inline comments as done. sfantao added a comment. - Merge branch 'master' into patch-D13909 - Remove unecessary returns and fix iterators. http://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundle

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: test/Driver/clang-offload-bundler.c:14 @@ +13,3 @@ +// +// RUN: touch %t.empty + ABataev wrote: > Hmm, will it work on Windows? Maybe it is better just to add an empty test > file? I see ma

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62540. sfantao added a comment. - Remove \brief when not needed. http://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundler.c tools/CMakeLists.txt tools/clang-offload-bundler/CMakeLists.txt tools/clang-offload-bund

r274385 - [Temporary, Lifetime] Add lifetime marks for temporaries

2016-07-01 Thread Tim Shen via cfe-commits
Author: timshen Date: Fri Jul 1 16:08:47 2016 New Revision: 274385 URL: http://llvm.org/viewvc/llvm-project?rev=274385&view=rev Log: [Temporary, Lifetime] Add lifetime marks for temporaries With all MaterializeTemporaryExprs coming with a ExprWithCleanups, it's easy to add correct lifetime.end m

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

2016-07-01 Thread Tim Shen via cfe-commits
This revision was automatically updated to reflect the committed changes. timshen marked an inline comment as done. Closed by commit rL274385: [Temporary, Lifetime] Add lifetime marks for temporaries (authored by timshen). Changed prior to commit: http://reviews.llvm.org/D20499?vs=62433&id=6254

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-07-01 Thread David Li via cfe-commits
davidxl added inline comments. Comment at: include/clang/Driver/Options.td:507 @@ +506,3 @@ +Group, Flags<[DriverOption]>, MetaVarName<"">, +HelpText<"Set to be the default profile output file (overridden by LLVM_PROFILE_FILE env var)">; +def fpgo_apply_EQ : Joined<["-"]

r274387 - Remove unncessary CHECKs from r274385

2016-07-01 Thread Tim Shen via cfe-commits
Author: timshen Date: Fri Jul 1 16:16:58 2016 New Revision: 274387 URL: http://llvm.org/viewvc/llvm-project?rev=274387&view=rev Log: Remove unncessary CHECKs from r274385 Modified: cfe/trunk/test/CodeGen/temporary-lifetime.cpp Modified: cfe/trunk/test/CodeGen/temporary-lifetime.cpp URL: ht

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

2016-07-01 Thread Tim Shen via cfe-commits
timshen added a comment. Also committed r274387 to remove unnecessary CHECks. It seems to cause problems in certain platforms. Repository: rL LLVM http://reviews.llvm.org/D20499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-07-01 Thread Eric Christopher via cfe-commits
echristo added a comment. In http://reviews.llvm.org/D21334#472548, @pirama wrote: > Reformatted with clang-format for just the parts I added. I ignored > clang-format-suggested changes in code unrelated to this patch. Yep. > Is there a policy or practise on periodically fixing format-relate

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62550. sfantao marked 6 inline comments as done. sfantao added a comment. - Remove \brief and return errors instead of crashing when temporary tiles can't be created. http://reviews.llvm.org/D21851 Files: test/Driver/clang-offload-bundler.c tools/clang

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:345 @@ +344,3 @@ + /// return the triple by reference. + bool isOffloadSection(SectionRef CurSection, StringRef &OffloadTriple) { +StringRef SectionN

Re: [PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62553. sfantao added a comment. - Rebase. - Fix format. http://reviews.llvm.org/D21852 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp test/Driver/openmp-offload.c Index: test/Driver/openm

r274392 - C++14 init-capture: error out instead of crashing.

2016-07-01 Thread Manman Ren via cfe-commits
Author: mren Date: Fri Jul 1 17:27:16 2016 New Revision: 274392 URL: http://llvm.org/viewvc/llvm-project?rev=274392&view=rev Log: C++14 init-capture: error out instead of crashing. When we have template arguments, we have a function and a pattern, the variable in init-capture belongs to the patt

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: include/clang/Driver/Types.h:78 @@ +77,3 @@ + /// compilation phase is a preprocessor one. + bool isSrcFile(ID Id); + ABataev wrote: > 'const'? `isSrcFile` is not member of a class. It is

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62558. sfantao marked 3 inline comments as done. sfantao added a comment. - Mark classes 'final' and set defalt initializers. http://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h include/clang/Driver/Types.h lib/Driver/Action.cpp lib/

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62561. sfantao marked 3 inline comments as done. sfantao added a comment. - Use StringRef instead of string and mark bundler tool as final. http://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/Driver/Action.cpp:133 @@ +132,3 @@ +/// we assume 'host'. +std::string Action::getOffloadKindName(OffloadKind Kind) { + switch (Kind) { ABataev wrote: > 1. Maybe it is enough to return

r274396 - Removes CHECKs for symbolic label names (as Debug Clang will generate).

2016-07-01 Thread Tim Shen via cfe-commits
Author: timshen Date: Fri Jul 1 17:50:00 2016 New Revision: 274396 URL: http://llvm.org/viewvc/llvm-project?rev=274396&view=rev Log: Removes CHECKs for symbolic label names (as Debug Clang will generate). Differential Revision: http://reviews.llvm.org/D20499 Modified: cfe/trunk/test/CodeGen

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

2016-07-01 Thread Tim Shen via cfe-commits
timshen added a comment. ...and r274396 to remove all of the checks for symbolic labels, which are not generated by release builds, nor controlled by a runtime-flag. Repository: rL LLVM http://reviews.llvm.org/D20499 ___ cfe-commits mailing list

Re: [PATCH] D21453: Add support for attribute "overallocated"

2016-07-01 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 62560. ahatanak added a comment. The new patch defines a new attribute "flexible_array", which gets attached to the last array member of a struct. I made changes to clang to treat arrays marked "flexible_array" as C99's flexible array members where it made

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62565. sfantao added a comment. - Add Ctor dropped by mistake in the previous diff. http://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h include/clang/Driver/Types.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.c

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62567. sfantao added a comment. - Use StringRef instead of std::string, fix comments and mark class final. http://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp lib/Driver/ToolChai

r274401 - [CodeView] Include MSVC style names for unnamed types

2016-07-01 Thread David Majnemer via cfe-commits
Author: majnemer Date: Fri Jul 1 18:12:54 2016 New Revision: 274401 URL: http://llvm.org/viewvc/llvm-project?rev=274401&view=rev Log: [CodeView] Include MSVC style names for unnamed types The CodeView printer expects to be able to generate fully qualified names from the debug info graph. This m

[libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

2016-07-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 1 18:22:25 2016 New Revision: 274403 URL: http://llvm.org/viewvc/llvm-project?rev=274403&view=rev Log: Work around ABI break caused by C++17 inline variables. Modified: libcxx/trunk/src/chrono.cpp Modified: libcxx/trunk/src/chrono.cpp URL: http://llvm.org/viewv

[libcxx] r274404 - Turn off ASAN's odr-violation diagnostics for now. See PR28391

2016-07-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 1 18:25:47 2016 New Revision: 274404 URL: http://llvm.org/viewvc/llvm-project?rev=274404&view=rev Log: Turn off ASAN's odr-violation diagnostics for now. See PR28391 Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-07-01 Thread Sean Silva via cfe-commits
silvas added inline comments. Comment at: lib/Driver/Tools.cpp:3560 @@ +3559,3 @@ +if (PGOTrainArg->getOption().matches(options::OPT_fpgo_train_EQ)) { + if (StringRef(PGOTrainArg->getValue()) == "source-cfg") +CmdArgs.push_back("-fprofile-instrument=clang"); -

Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

2016-07-01 Thread Richard Smith via cfe-commits
On Fri, Jul 1, 2016 at 4:22 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Jul 1 18:22:25 2016 > New Revision: 274403 > > URL: http://llvm.org/viewvc/llvm-project?rev=274403&view=rev > Log: > Work around ABI break caused by C++17 inline variabl

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62569. sfantao marked 2 inline comments as done. sfantao added a comment. - Change name of static function, format comments and remove \brief. http://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Tool.h lib/Driver/A

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-07-01 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, thanks for the review! Comment at: include/clang/Driver/Tool.h:132-140 @@ -131,1 +131,11 @@ const char *LinkingOutput) const = 0; + /// ConstructJob - Construct jobs to perform the action \p JA, + /// writing to

Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

2016-07-01 Thread Eric Fiselier via cfe-commits
The attribute is ignored unless it is placed on the in-class declaration of the member. It has no effect when applied to the explicit definition. I would rather keep the workaround internal than make the change in the headers. On Fri, Jul 1, 2016 at 5:34 PM, Richard Smith wrote: > On Fri, Jul 1,

  1   2   >