a.sidorin marked 5 inline comments as done. a.sidorin added a comment. Thank you for your comments! And sorry for late response after pinging.
================ Comment at: lib/AST/ASTImporter.cpp:2518-2519 @@ +2517,4 @@ + Importer.Import(D->getMessage())); + if (!Message) + return nullptr; + ---------------- sepavloff wrote: > Since C++17 `static_assert` may be used without message, so null pointer here > is not an error. I will modify the check, but may be we should check the language standard as well? ================ Comment at: lib/AST/ASTImporter.cpp:3363 @@ +3362,3 @@ + + // Determine whether we've already imported this decl. + // FriendDecl is not a NamedDecl so we cannot use localUncachedLookup. ---------------- sepavloff wrote: > Maybe it is more natural to put this check into `bool > IsStructurallyEquivalent(StructuralEquivalenceContext &Context, RecordDecl > *D1, RecordDecl *D2)`? If records are equivalent, existing decl can be used > as a result of import, if not - entire record must be recreated anyway. Sorry, it seems like I don't completely understand your idea. Won't `IsStructurallyEquivalent()` do an additional amount of work? http://reviews.llvm.org/D14326 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
