hokein added a comment.
friendly ping @rsmith.
http://reviews.llvm.org/D17762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kromanova
Date: Thu Mar 10 03:37:04 2016
New Revision: 263098
URL: http://llvm.org/viewvc/llvm-project?rev=263098&view=rev
Log:
Add doxygen comments to xmmintrin.h's intrinsics.
Only half of the intrinsics in this file is documented here. The patch for the
other half will be sent out late
chandlerc added a comment.
FYI, I'd lik eto hold off on submitting here until we're on the same page with
Philip on the original LLVM review (http://reviews.llvm.org/D17946), but some
comments on how this is working are below...
Comment at: lib/CodeGen/CodeGenAction.cpp:660-66
a.sidorin added a comment.
Serge: BTW, tests for CXXBoolLiteralExpr are presented in this patch. There is
no test //exactly// for it but at least one test uses bool literal and matches
it successfully with cxxBoolLiteral() matcher.
http://reviews.llvm.org/D14286
a.sidorin added a comment.
Alexander, could you update status of this review?
http://reviews.llvm.org/D16873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
roman.shirokiy added a comment.
Hello!
Thanks for the feedback!
MSVC got its own runtime lib, so the function "AddRunTimeLibs" is not used
anywhere in "visualstudio::Linker::Constructjob" i.e. "--rtlib" option is
currently unused in MSVC environment (there is always a warning: argument
unused
roman.shirokiy updated this revision to Diff 50260.
roman.shirokiy added a comment.
Updated diff with the test for "nostdlib" + "rtlib" case.
http://reviews.llvm.org/D17453
Files:
lib/Driver/Tools.cpp
test/Driver/msvc-compiler-rt.c
test/Driver/nostdlib.c
Index: lib/Driver/Tools.cpp
=
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: majnemer.
DmitryPolukhin added subscribers: cfe-commits, aaron.ballman, stbuehler.
Original patch by Stefan Bühler http://reviews.llvm.org/D12834
Difference between original and this one:
- fixed all failing tests
- fixed man
Hahnfeld added a comment.
More comments on this?
Thanks, Jonas
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Thu Mar 10 07:08:22 2016
New Revision: 263109
URL: http://llvm.org/viewvc/llvm-project?rev=263109&view=rev
Log:
Correcting an attribute documentation generation error by giving the abi_tag
attribute a documentation category.
Modified:
cfe/trunk/include/clang/Basic/
Author: rksimon
Date: Thu Mar 10 08:16:36 2016
New Revision: 263113
URL: http://llvm.org/viewvc/llvm-project?rev=263113&view=rev
Log:
Minor Wdocumentation fix. NFCI.
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
URL:
Would this one more reasonable to commit. As you suggested if the base
type is dependent, create a unique canonical UnaryTransformType with the
canonical form of the base type as its base type and with DependentTy as
its underlying type, then use that canonical dependent type as the
underlying
Aaron, thank you for fixing this!
On Thu, Mar 10, 2016 at 4:08 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Thu Mar 10 07:08:22 2016
> New Revision: 263109
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263109&view=rev
> Log:
> Correcting
Author: rksimon
Date: Thu Mar 10 08:42:17 2016
New Revision: 263115
URL: http://llvm.org/viewvc/llvm-project?rev=263115&view=rev
Log:
Updated SSSE3 builtin tests to more closely match the llvm fast-isel equivalent
tests
Modified:
cfe/trunk/test/CodeGen/ssse3-builtins.c
Modified: cfe/trunk/t
Author: rksimon
Date: Thu Mar 10 08:44:32 2016
New Revision: 263116
URL: http://llvm.org/viewvc/llvm-project?rev=263116&view=rev
Log:
Added note to SSE4a builtins about keeping in sync with llvm tests
Modified:
cfe/trunk/test/CodeGen/sse4a-builtins.c
Modified: cfe/trunk/test/CodeGen/sse4a-bu
Author: rksimon
Date: Thu Mar 10 08:46:49 2016
New Revision: 263117
URL: http://llvm.org/viewvc/llvm-project?rev=263117&view=rev
Log:
Updated SSE3 builtin tests to more closely match the llvm fast-isel equivalent
tests
Modified:
cfe/trunk/test/CodeGen/sse3-builtins.c
Modified: cfe/trunk/tes
I think this is ABI-breaking. On OS X, new libc++ headers must work with
old system libc++.dylibs. When I build in this setup with this change, I get
Undefined symbols for architecture x86_64:
"std::__1::basic_string,
std::__1::allocator >::basic_string(std::__1::basic_string, std::__1::allocato
bader added a comment.
If there are no objections to adopt this approach I can start working on
rebasing that patch to the ToT.
Comment at: include/clang/AST/OpenCLImageTypes.def:39
@@ +38,3 @@
+
+IMAGE_READ_TYPE(image1d, OCLImage1d)
+IMAGE_READ_TYPE(image1d_array, OCLImage1dAr
joker.eph added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:660-663
@@ -660,1 +659,6 @@
+ OwnsVMContext(!_VMContext) {
+#ifdef NDEBUG
+ _VMContext.setDiscardValueNames(true);
+#endif
+}
chandlerc wrote:
> I'm surprised this isn't a driver-si
chandlerc added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:660-663
@@ -660,1 +659,6 @@
+ OwnsVMContext(!_VMContext) {
+#ifdef NDEBUG
+ _VMContext.setDiscardValueNames(true);
+#endif
+}
joker.eph wrote:
> chandlerc wrote:
> > I'm surprised t
> On Mar 9, 2016, at 5:22 PM, David Blaikie wrote:
>
> Is this bug only reachable with modules debug info?
Yes, it’s in ObjectFilePCHContainerOperations.cpp, which is only used while
building a PCH or module with -gmodules.
> Could you describe the nature of the fix (not quite clear to me jus
joker.eph updated this revision to Diff 50282.
joker.eph added a comment.
Add a FIXME to change the compile time switch to a runtime command line flag
http://reviews.llvm.org/D18024
Files:
lib/CodeGen/CGBuilder.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenAction.cp
I would like to submit the attached changes for your approval.
My name is Wes Witt and I'm a software engineer at Microsoft. The diff
represent some small changes that we've made in order to use Clang to compile
Objective C on Windows.
The compiler is used for the open source WinObjC project
(
kfunk added a comment.
@bkramer: Thoughts about my patch? I wonder if this makes your "work-around" in
http://reviews.llvm.org/D17808 redundant.
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
On 3/10/16 9:38 AM, Wes Witt via cfe-commits wrote:
I would like to submit the attached changes for your approval.
Gentle etiquette suggestion: please title your emails with something
more descriptive. In this case, something like: "[PATCH] Windows support
for ObjC codegen". And then in the
On Thu, Mar 10, 2016 at 11:38 AM, Wes Witt via cfe-commits
wrote:
> I would like to submit the attached changes for your approval.
Thank you for the patch!
This:
+ let Subjects = SubjectList<[Function, Var, CXXRecord,
ObjCInterface], WarnDiag,
+ "ExpectedVariableOrF
kfunk added inline comments.
Comment at: tools/libclang/CXType.cpp:990
@@ -987,1 +989,3 @@
+CXType clang_getNamedTypeUnderlyingElaboratedType(CXType CT){
+ QualType T = GetQualType(CT);
I'm not happy with this name either. If you look through the libclang API,
carlo.bertolli added a comment.
I can actually add a regression test that checks that the compiler does not
break when using a global in a teams region, even without declare target, if
that is what is required here.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
_
weimingz updated this revision to Diff 50300.
weimingz added a comment.
rebased
http://reviews.llvm.org/D17741
Files:
include/clang/Driver/Options.td
include/clang/Lex/Preprocessor.h
include/clang/Lex/PreprocessorOptions.h
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocation.cpp
lib
tra created this revision.
tra added reviewers: jlebar, jingyue.
tra added a subscriber: cfe-commits.
This provides substantial performance boost on some benchmarks
(~25% on SHOC's FFT) due to vectorized loads/stores.
Unfortunately existing CUDA headers and user code occasionally
take pointer to
pbarrio created this revision.
pbarrio added reviewers: javed.absar, rengolin.
pbarrio added a subscriber: cfe-commits.
pbarrio added a dependency: D17925: [ARM] Add Cortex-R8 to target parser and
tablegen.
Herald added subscribers: rengolin, aemerson.
Add command-line tests for ARM Cortex-R8. De
pbarrio added a comment.
Hello, could you please review these tests for Cortex-R8?
By the way Renato, thank you for the review on the LLVM side.
http://reviews.llvm.org/D18052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: nico
Date: Thu Mar 10 12:42:37 2016
New Revision: 263138
URL: http://llvm.org/viewvc/llvm-project?rev=263138&view=rev
Log:
Make remaining ImplicitFallthrough warning DefaultIgnore.
Follow-up to r262881, which caused this to fire more often.
Modified:
cfe/trunk/include/clang/Basic/Dia
On Wed, Mar 9, 2016 at 6:44 PM, Nico Weber wrote:
> On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote:
>
>> On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith
>> wrote:
>>
>>> On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote:
>>> > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith
>>> wrote:
>>> >>
>
Author: mren
Date: Thu Mar 10 12:53:19 2016
New Revision: 263149
URL: http://llvm.org/viewvc/llvm-project?rev=263149&view=rev
Log:
Add TreatUnavailableAsInvalid for the verification-only mode in InitListChecker.
Given the following test case:
typedef struct {
const char *name;
id field;
} Tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263149: Add TreatUnavailableAsInvalid for the
verification-only mode in InitListChecker. (authored by mren).
Changed prior to commit:
http://reviews.llvm.org/D15314?vs=48228&id=50312#toc
Repository:
Author: rsmith
Date: Thu Mar 10 13:22:21 2016
New Revision: 263155
URL: http://llvm.org/viewvc/llvm-project?rev=263155&view=rev
Log:
Add test for r263138.
Added:
cfe/trunk/test/SemaCXX/switch-implicit-fallthrough-off-by-default.cpp
Added: cfe/trunk/test/SemaCXX/switch-implicit-fallthrough-of
On Thu, Mar 10, 2016 at 10:47 AM, Nico Weber wrote:
> On Wed, Mar 9, 2016 at 6:44 PM, Nico Weber wrote:
>>
>> On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote:
>>>
>>> On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith
>>> wrote:
On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote:
>
Hello everyone,
Below are some buildbot numbers for the week of 2/21/2016 - 2/27/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername |
Hello everyone,
Below are some buildbot numbers for the last week of 2/28/2016 - 3/05/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
davide added a comment.
Hmm, I think you're right. It's not actually that silent (it fails with a fatal
error when trying to load/read).
That said, I think it might still be valuable to emit a diagnostic -- Richard
what do you think?
I noticed you reported a very similar problem here:
https://
dim accepted this revision.
dim added a reviewer: dim.
dim added a comment.
This revision is now accepted and ready to land.
If nobody objects, I will commit this.
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Hahnfeld added a comment.
In http://reviews.llvm.org/D17286#372290, @dim wrote:
> If nobody objects, I will commit this.
I can do so myself but would would like to hear from @joerg first
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
jlebar added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:72
@@ -71,1 +71,3 @@
+#if defined(CUDA_VECTOR_TYPES)
+// Prevent inclusion of CUDA's vector_types.h
Hm, this is a surprising (to me) way of controlling this feature. Can we use
rnk added a comment.
This will definitely work, but it will substantially increase the size of
clang-tidy:
$ du -cksh bin/clang-tidy.exe bin/clang.exe
21M bin/clang-tidy.exe
47M bin/clang.exe
68M total
The difference is mostly from the backends, and that's with only the X86 and
ARM
LegalizeAdulthood added a comment.
I do not have commit access, so I will need someone to commit this for me.
Patch by Richard Thomson
thanks.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:82
@@ +81,3 @@
+? std::string{R"lit()")lit"}
+
LegalizeAdulthood added a comment.
Another week without reviews...
These changes were already split from a previous changeset without being
reviewed properly.
Squeak squeak squeak.
http://reviews.llvm.org/D17482
___
cfe-commits mailing list
cfe-c
tra updated this revision to Diff 50341.
tra marked an inline comment as done.
tra added a comment.
Removed unneeded struct attributes.
http://reviews.llvm.org/D18051
Files:
lib/Headers/CMakeLists.txt
lib/Headers/__clang_cuda_runtime_wrapper.h
lib/Headers/__clang_cuda_vector_types.h
lib
tra added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:72
@@ -71,1 +71,3 @@
+#if defined(CUDA_VECTOR_TYPES)
+// Prevent inclusion of CUDA's vector_types.h
jlebar wrote:
> Hm, this is a surprising (to me) way of controlling this feature
Thank you!
On Thu, Mar 10, 2016 at 2:22 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Mar 10 13:22:21 2016
> New Revision: 263155
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263155&view=rev
> Log:
> Add test for r263138.
>
> Added:
>
jlebar added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:72
@@ -71,1 +71,3 @@
+#if defined(CUDA_VECTOR_TYPES)
+// Prevent inclusion of CUDA's vector_types.h
The compiler driver is responsible for enabling/disabling language extensions
Does anyone have a problem with this direction? I have commits to
follow that get tests green when run against various releases of OSX
but I need this in place first.
> On 2016-Feb-19, at 17:59, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> dexonsmith created this revision.
> dexonsmith
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Does anyone have a problem with this direction? I have commits to
follow that get tests green when run against various releases of OSX
but I need this in place first.
http://reviews.llvm.org/D17469
___
eugenis added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D17360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGExpr.cpp:2484-2485
@@ -2483,3 +2483,4 @@
CheckRecoverableKind RecoverKind = getRecoverableKind(Checked[0].second);
// In cross-DSO CFI mode this
Sorry, if I am late to the party:). Does this mean that ObjectiveC, and its
runtime, is natively supported on Clang for Windows (WinObjC)? This would be
great news.
- Fariborz
> On Mar 10, 2016, at 8:38 AM, Wes Witt via cfe-commits
> wrote:
>
> I would like to submit the attached changes for
Author: nico
Date: Thu Mar 10 16:40:02 2016
New Revision: 263168
URL: http://llvm.org/viewvc/llvm-project?rev=263168&view=rev
Log:
Reenable asm-errors.c
r134811 made the test pass and reenabled it, but r134831
accidentally disabled it again due to a bad merge.
Modified:
cfe/trunk/test/CodeGe
tra abandoned this revision.
tra added a comment.
Ugh. Found more problems with using vector types in C++. Abandoning the idea.
http://reviews.llvm.org/D18051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
OK, so the idea is that when you see that a tag definition, skip it if any
parent is incomplete - because when the parent's definition is complete,
you'll emit all its children anyway?
On Thu, Mar 10, 2016 at 8:19 AM, Adrian Prantl wrote:
>
> > On Mar 9, 2016, at 5:22 PM, David Blaikie wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263170: libclang python bindings: Fix for bug 26394
(authored by jbcoe).
Changed prior to commit:
http://reviews.llvm.org/D17226?vs=47874&id=50369#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17
Author: mren
Date: Thu Mar 10 17:51:03 2016
New Revision: 263171
URL: http://llvm.org/viewvc/llvm-project?rev=263171&view=rev
Log:
Add has_feature objc_class_property.
rdar://23891898
Modified:
cfe/trunk/lib/Lex/PPMacroExpansion.cpp
cfe/trunk/test/SemaObjC/objc-class-property.m
Modified
Author: mren
Date: Thu Mar 10 17:54:12 2016
New Revision: 263172
URL: http://llvm.org/viewvc/llvm-project?rev=263172&view=rev
Log:
Print strict in Availability attribute when it is on.
Modified:
cfe/trunk/test/Sema/attr-print.c
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified: cfe/
jbcoe added inline comments.
Comment at: test/clang-tidy/misc-dangling-handle.cpp:86
@@ +85,3 @@
+ // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives
+
+ view1 = std::string();
Thanks.
http://reviews.llvm.org/D17811
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
In http://reviews.llvm.org/D18051#372490, @tra wrote:
> Ugh. Found more problems with using vector types in C++. Abandoning the idea.
I'm curious, what problems?
http://reviews.llvm.org/D18051
___
> On Mar 10, 2016, at 3:21 PM, David Blaikie wrote:
>
> OK, so the idea is that when you see that a tag definition, skip it if any
> parent is incomplete - because when the parent's definition is complete,
> you'll emit all its children anyway?
Yes. If there’s a more direct way top achieve th
manmanren added a comment.
Uploading a new patch addressing Aaron's comments:
1> Add an optional string argument for fix-it, instead of the original proposal
of named argument `Replacement = "xxx"`
This actually simplifies the patch a lot
2> Add testing cases to make sure we don't accept a fix-it
Author: kromanova
Date: Thu Mar 10 18:05:54 2016
New Revision: 263175
URL: http://llvm.org/viewvc/llvm-project?rev=263175&view=rev
Log:
Add doxygen comments to avxintrin.h's intrinsics.
Only around 25% of the intrinsics in this file are documented here. The patches
for the other half will be sent
manmanren retitled this revision from "Add replacement = "xxx" to
DeprecatedAttr." to "Add an optional string argument to DeprecatedAttr for
Fix-It.".
manmanren updated this revision to Diff 50374.
http://reviews.llvm.org/D17865
Files:
include/clang/Basic/Attr.td
lib/Lex/PPMacroExpansion.cp
manmanren added inline comments.
Comment at: utils/TableGen/ClangAttrEmitter.cpp:1234
@@ +1233,3 @@
+if ((Spelling == "deprecated" || Spelling == "gnu::deprecated") &&
+Variety != "GNU" && index == 1)
+ continue;
This does not look pre
Not sure if it's worth it, but you might be able to abort the loop if you
ever reach a namespace (or anything that's not a tag decl maybe? Not sure
about function local types)
On Thu, Mar 10, 2016 at 4:09 PM, Adrian Prantl wrote:
>
> On Mar 10, 2016, at 3:21 PM, David Blaikie wrote:
>
> OK, so
jbcoe added a comment.
@skalinichev I get the same failure as you. This patch is old now, all tests
used to pass. Can you see what is wrong with the test logic?
http://reviews.llvm.org/D15469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
There were ambiguities in overload resolution between vector types and
their base types. I.e. if I had
void foo(int);
void foo(int3);
then call foo(3) was ambiguous.
It wasn't clear whether this extension is supposed to work in C++ at all.
On Thu, Mar 10, 2016 at 4:05 PM, Hal Finkel wrote:
[+Richard]
- Original Message -
> From: "Artem Belevich"
> To: reviews+d18051+public+fb9c7f3f37ff8...@reviews.llvm.org
> Cc: "Justin Lebar" , "Jingyue Wu"
> , "Hal Finkel" , "cfe-commits"
>
> Sent: Thursday, March 10, 2016 6:38:21 PM
> Subject: Re: [PATCH] D18051: [CUDA] Provide CUDA's
jbcoe added a comment.
I don't know if it's at all helpful but I get the following output from
llvm-lit on the failing test file. There's no mention of a function `foo` at
all:
[startedTranslationUnit]
[enteredMainFile]:
/Users/jon/DEV/llvm-git-svn/tools/clang/test/Index/index-file.cpp
[
pcc created this revision.
pcc added reviewers: rsmith, rjmccall.
pcc added a subscriber: cfe-commits.
User programs shouldn't be able to observe their addresses without invoking
undefined behavior. This will be needed to create relative references
to runtime functions __cxa_pure_virtual and __cxa
eugenis updated this revision to Diff 50379.
eugenis marked 2 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D17360
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGen/cfi-check-fail.c
test/CodeGen/cfi-check-fail2.c
Index: test/CodeGen/cfi-check-fail2.c
Author: jbcoe
Date: Thu Mar 10 17:29:45 2016
New Revision: 263170
URL: http://llvm.org/viewvc/llvm-project?rev=263170&view=rev
Log:
libclang python bindings: Fix for bug 26394
Summary:
https://llvm.org/bugs/show_bug.cgi?id=26394 reports that clang's python
bindings tests are failing.
I can conf
eugenis closed this revision.
eugenis added a comment.
r263180, thanks for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D17360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you for one more awesome check!
Comment at: clang-tidy/misc/DanglingHandleCheck.cpp:25
@@ +24,3 @@
+std::vector parseClasses(StringRef Option) {
+ SmallVector Class
ariccio created this revision.
ariccio added reviewers: zaks.anna, dcoughlin, aaron.ballman.
ariccio added a subscriber: cfe-commits.
As discussed...
http://reviews.llvm.org/D18073
Files:
llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
llvm/tools/clang/test/Analysis/malloc.c
alexfh added a comment.
Sorry for leaving this without attention for a while.
I'm somewhat concerned about this change. It's adding a certain level of
complexity, but doesn't cover some less trivial cases like handling of multiple
headers. Can you take a look at existing tests and say how many
zaks.anna added a comment.
Since we are adding support for so many new APIs that are only available on
Windows, could you please condition checking them only when we build for
Windows. You probably can look and Language Options to figure that out.
Also, we should not duplicate all of our tests.
alexfh added a comment.
Looks mostly good, a few nits.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:82
@@ +81,3 @@
+? std::string{R"lit()")lit"}
+: (")" + Delimiter + R"(")")) != StringRef::npos;
+}
L
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
The Visual Studio native visualizer in llvm.natvis displays the actual pointer
in a PointerUnion as a void *. E.g.
clang::Type const *: 0x02c4a880
Which doesn't make c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:32-59
@@ +31,30 @@
+ /// \param ThreadLimit An integer expression of threads.
+ virtual void emitNumTeamsClause(CodeGenFu
Author: rjmccall
Date: Thu Mar 10 22:30:31 2016
New Revision: 263191
URL: http://llvm.org/viewvc/llvm-project?rev=263191&view=rev
Log:
Preserve ExtParameterInfos into CGFunctionInfo.
As part of this, make the function-arrangement interfaces
a little simpler and more semantic.
NFC.
Modified:
Author: rjmccall
Date: Thu Mar 10 22:30:43 2016
New Revision: 263192
URL: http://llvm.org/viewvc/llvm-project?rev=263192&view=rev
Log:
Add a coerce-and-expand ABIArgInfo as a generalization of some
of the things we do with Expand / Direct.
NFC for now, but this will be used by swiftcall expansion
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D18052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: rjmccall
Date: Thu Mar 10 22:55:21 2016
New Revision: 263193
URL: http://llvm.org/viewvc/llvm-project?rev=263193&view=rev
Log:
Speculatively attempt to fix the MSVC build by making some
methods non-private.
Modified:
cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h
Modified: cfe/trun
Author: rjmccall
Date: Thu Mar 10 23:03:01 2016
New Revision: 263194
URL: http://llvm.org/viewvc/llvm-project?rev=263194&view=rev
Log:
Removing the friend declaration was not a good idea.
Modified:
cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h
Modified: cfe/trunk/include/clang/CodeGen/CGF
rjmccall added a comment.
The underscore check seems over-broad; we support a lot of language dialects
and runtimes besides the Itanium C++ runtime. This would be both more
conservative and more convincing if it were constrained to the functions that
we expect to put in v-tables.
http://revi
alexfh added a comment.
If this issue is specific to MS inline asm, then the additional dependencies
should only be added, when we care about MS inline asm (windows builds only?).
http://reviews.llvm.org/D17981
___
cfe-commits mailing list
cfe-comm
alexfh added a comment.
Also, should we do this for all Clang tools?
http://reviews.llvm.org/D17981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
> + {"iso646.h", "ciso646"},
> Just delete #includes of this one. does nothing.
> + {"stdalign.h", "cstdalign"},
> + {"stdbool.h", "cstdbool"},
> We should just delete these two includes. These headers do nothing in C++.
These don't seem to be addressed. Can yo
ariccio added a comment.
In http://reviews.llvm.org/D18073#372697, @zaks.anna wrote:
> Since we are adding support for so many new APIs that are only available on
> Windows, could you please condition checking them only when we build for
> Windows. You probably can look and Language Options to
alexfh added a comment.
Adding Benjamin as a reviewer, since I'm on vacation.
Repository:
rL LLVM
http://reviews.llvm.org/D17958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
96 matches
Mail list logo
