manmanren added a comment. Uploading a new patch addressing Aaron's comments: 1> Add an optional string argument for fix-it, instead of the original proposal of named argument `Replacement = "xxx"` This actually simplifies the patch a lot 2> Add testing cases to make sure we don't accept a fix-it argument for declspec, c++11 attribute, gnu namespace attribute 3> Change AST printing to make sure we only dump the fix-it argument for gnu style attribute
Cheers, Manman http://reviews.llvm.org/D17865 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
