alexfh added a comment.

Sorry for leaving this without attention for a while.

I'm somewhat concerned about this change. It's adding a certain level of 
complexity, but doesn't cover some less trivial cases like handling of multiple 
headers. Can you take a look at existing tests and say how many times this 
feature is going to be used, if it gets added to the testing script?

Thank you!


================
Comment at: test/clang-tidy/check_clang_tidy.py:122
@@ -40,2 +121,3 @@
   parser.add_argument('-resource-dir')
+  parser.add_argument('--header-filter')
   parser.add_argument('input_file_name')
----------------
The name of the flag might be confusing, since it doesn't have the same meaning 
as the clang-tidy flag with the same name. The clang-tidy `--header-filter` 
flag is a regular expression, but this one is a single header filename.


http://reviews.llvm.org/D17482



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to