[PATCH] D118698: [clangd][nfc] cleanup of remaining clang-tidy findings

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f8da95e070e: [clangd][nfc] cleanup of remaining clang-tidy findings (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118698/new/ https:/

[PATCH] D118698: [clangd][nfc] cleanup of remaining clang-tidy findings

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. There were some left-overs

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel marked 4 inline comments as done. kuhnel added a comment. Thx @sammccall for your patience with this cleanup. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:103 -static clang::clangd::Key kFileBeingProcessed; +static clang::clangd::Key KFileBeingProcessed;

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel marked 6 inline comments as done. kuhnel added inline comments. Comment at: clang-tools-extra/clangd/fuzzer/FuzzerClangdMain.cpp:15 +// NOLINTNEXTLINE(readability-identifier-naming) extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size); ---

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel updated this revision to Diff 403539. kuhnel marked an inline comment as done. kuhnel added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115634/new/ https://reviews.llvm.org/D115634 Files: .clang-tidy

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel updated this revision to Diff 403538. kuhnel added a comment. Herald added a subscriber: aheejin. Re-created the patch as there were too many changes in the repo. Excluding gtest Matchers from naming checks as gtest convention does not match LLVM convention. Repository: rG LLVM Github

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc0e3c893aa09: [NFC][clangd] cleaning up llvm-qualified-auto (authored by kuhnel). Changed prior to commit: https://revi

[PATCH] D117773: [clang-tidy] added JSON output to clang-tidy-diff.py

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, xazax.hun. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. This makes it easier to process the clang-tidy output in

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. TODO: check for remaining `const` then submit. Comment at: clang-tools-extra/clangd/unittests/FileIndexTests.cpp:252 TEST(FileIndexTest, TemplateParamsInLabel) { - auto Source = R"cpp( + const auto *Source = R"cpp( template remove c

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel added a comment. Discussion in team sync, work for myself: - most changes are in unittests --> propose something for the matchers - cleaning up constants makes sense - clean up this patch, then do another round of reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel marked 3 inline comments as done. kuhnel added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:2550 auto AST = TU.build(); - for (auto Comment : {"doc1", "doc2", "doc3"}) { + for (const auto *Comment : {"doc1", "doc2", "doc3"}) { fo

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel updated this revision to Diff 393894. kuhnel added a comment. more reverts of consts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113898/new/ https://reviews.llvm.org/D113898 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/cl

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel updated this revision to Diff 393892. kuhnel added a comment. fixed more const ClangdTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113898/new/ https://reviews.llvm.org/D113898 Files: clang-tools-extra/clangd/AST.cpp clang-tool

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel updated this revision to Diff 393890. kuhnel added a comment. reverted the `const` as advised in Sam's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113898/new/ https://reviews.llvm.org/D113898 Files: clang-tools-extra/clangd/AST.

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. In D113898#3167215 , @kbobyrev wrote: > In D113898#3167050 , @kuhnel wrote: > >> Looking at the documentation, this looks like a bug in the clang-tidy check: >> https://releases.llvm.org/13

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. Looking at the documentation, this looks like a bug in the clang-tidy check: https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html The rule `llvm-qualified-auto` should not add a `const` qualifier. Repository: r

[PATCH] D113896: [clangd] cleanup of header guard names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5bd643d31d11: [clangd] cleanup of header guard names (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel added a comment. @kadircet looks like clang-tidy does not detect missing comments in `#endif`. It does complain about missing comments for namespaces. E.g. in `Serialization.h` the `#endif` comment is missing, but without a finding. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel updated this revision to Diff 391301. kuhnel marked 4 inline comments as done. kuhnel added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113896/new/ https://reviews.llvm.org/D113896 Files: clang-tools

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. When trying to revert some of the changes, I just noticed there are a couple of `if (const auto* ...` in `CodeComplete.cpp` and `AST.cpp` (and maybe other files as well). So some folks seem to be using this right now. If we want to be consistent, we would have to remove

[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa2ce0fab3c: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull (authored by kuhnel). Changed prior to commit: https://reviews.llvm.org/D113899?vs=387254&id=388127#toc Repository: rG LLVM Githu

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel abandoned this revision. kuhnel added a comment. thx for the explanation, makes sense --> abandoning this change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113902/new/ https://reviews.llvm.org/D113902

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

This revision was automatically updated to reflect the committed changes. Closed by commit rGec4a2c956591: [NFC][clangd] cleanup llvm-else-after-return findings (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113892/new/ https://

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.h:3 +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H + //===--- PathMapping.h - apply path mappings to LSP messages -===// Looks like the include guards were missing here. I suppo

[PATCH] D113896: [NFC][clangd] cleanup of header guard names

kuhnel updated this revision to Diff 387929. kuhnel marked 3 inline comments as done. kuhnel added a comment. addresed Sam's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113896/new/ https://reviews.llvm.org/D113896 Files: clang-tools-e

[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:504 bool TraverseDecl(Decl *X) { -if (X && isa(X)) +if (isa_and_nonnull(X)) return Base::TraverseDecl(X); // Already pushed by constructor. kadircet wrote: > while

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

kuhnel updated this revision to Diff 387918. kuhnel marked 4 inline comments as done. kuhnel added a comment. addressed Sam's comments Sorry for the continued mess with automatic code formatting. Somehow VSCode forgot my settings :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel added a comment. In D113902#3131707 , @sammccall wrote: > Hmm, clang-tidy should only be running on entries in compile_commands.json. > are these files listed somehow? No, they are not. The question is: Do the tools our contributors use care ab

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. Based on Sam's comments and our offline discussion, I would propose: 1. abandon this patch 2. start a discussion on the mailing list to disable this check for all of the llvm monorepo. Other thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

kuhnel added a comment. I just checked with my local clangd and it does not crash on this file... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113889/new/ https://reviews.llvm.org/D113889 ___ cfe-commit

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG75a078455fc7: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h (authored by kuhnel). Changed prior to commit: https://reviews.llvm.org/D113889?vs=387239&id=387634#toc Reposi

[PATCH] D113895: [NFC][clangd] fix llvm-namespace-comment finding

This revision was automatically updated to reflect the committed changes. Closed by commit rG274f12a44c60: [NFC][clangd] fix llvm-namespace-comment finding (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113895/new/ https://revie

[PATCH] D113891: [NFC][clangd] cleaning up unused "using"

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2da1a2f400a: [NFC][clangd] cleaning up unused "using" (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113891/new/ https://reviews.llvm.

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman, javed.absar. kuhnel added subscribers: sammccall, hokein, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D113895: [NFC][clangd] fix llvm-namespace-comment finding

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixing the clang-tidy finding. Repository:

[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, kbobyrev, adamcz. kadircet added inline comments. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Hera

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov, aheejin. Herald added a project: clang-tools-extra.

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman, javed.absar. kuhnel added subscribers: sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project

[PATCH] D113896: [NFC][clangd] cleanup of header guard names

kuhnel created this revision. Herald added subscribers: carlosgalvezp, wenlei, usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clan

[PATCH] D113891: [NFC][clangd] cleaning up unused "using"

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. kuhnel added subscribers: hokein, sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clan

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, hokein, adamcz, kbobyrev. kuhnel published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The fil

[PATCH] D105014: added some example code for llvm::Expected

kuhnel added a comment. > Out of interest, did you see > https://llvm.org/docs/ProgrammersManual.html#error-handling ? If not (and if > you find it helpful) then maybe we need to make that document more > discoverable. If that document is not helpful then we should improve it. No I wasn't awar

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367787. kuhnel added a comment. fixing windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ext

[PATCH] D108119: Wiring of standard library indexing into clangd.

kuhnel updated this revision to Diff 367738. kuhnel added a comment. addressed some review comments question of integration with main functionality still open. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108119/new/ https://reviews.llvm.org/D108

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367737. kuhnel marked an inline comment as done. kuhnel added a comment. addressed code review comments also fixed use-after-free Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.o

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel marked an inline comment as done. kuhnel added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibIndexTests.cpp:51 + Req.AnyScope = true; + EXPECT_THAT(match(*Index, Req), + UnorderedElementsAre(llvm::StringRef("myfunc"),

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:72 + Inputs.TFS = &TFS; + // TODO: can we get a real compile command from somewhere? + Inputs.CompileCommand.Directory = virtualRoot().str(); nridge wrote: > sammccall wrote: >

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367523. kuhnel marked 18 inline comments as done. kuhnel added a comment. addressed review comments, has use-after-free problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/

[PATCH] D108119: Wiring of standard library indexing into clangd.

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:180 + if (Opts.IndexStandardLibrary) { +auto SLIndex = indexStandardLibrary(TFS); +if (!SLIndex || !SLIndex->get()) { I'm not sure if returning a Expected makes sense her

[PATCH] D108119: Wiring of standard library indexing into clangd.

kuhnel updated this revision to Diff 366856. kuhnel marked an inline comment as done. kuhnel added a comment. fixed lifecycle of StdLibIndex variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108119/new/ https://reviews.llvm.org/D108119 Files:

[PATCH] D108119: wired up standard library indexing

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Only plumbing code to enable standard library inde

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 365415. kuhnel added a comment. fixed a couple of bugs - wrong usage of llvm::unique - wrong usage of static pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 F

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 365370. kuhnel added a comment. tried to fix Windows build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt c

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel added a comment. > Main points in the implementation are: > > - simplify the exposed interface Good point, I added a new function `indexStandardLibrary()` as external interface. > - i don't think we need to mess with VFS at all actually Yes, removed that. > - we should think a little a

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 365181. kuhnel marked 29 inline comments as done. kuhnel edited the summary of this revision. kuhnel added a comment. Herald added a subscriber: mgrang. addressed code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D105014: added some example code for llvm::Expected

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd8f979fe48c: added some example code for llvm::Expected (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355510. kuhnel added a comment. now fixing arc's way of git commits :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Error.h llv

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355508. kuhnel added a comment. fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Testing/Support/Error.h Index: llvm/include/llv

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355507. kuhnel marked 4 inline comments as done. kuhnel added a comment. updated code examples based on Sam's review Oh my, this is really simple if you know how it's supposed to work. However my intuition is completely off in trying to understand the error h

[PATCH] D105014: added some example code for llvm::Expected

kuhnel added inline comments. Comment at: llvm/include/llvm/Support/Error.h:464 +///errs() << "Problem with division " +/// << toString(E) << "\n"; +/// } sammccall wrote: > this won't compile, you need std::move(E) sorry, I was too lazy

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355485. kuhnel marked 2 inline comments as done. kuhnel added a comment. fixed compilation issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355481. kuhnel added a comment. also added example code for EXPECT_THAT_EXPECTED. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Er

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 355478. kuhnel added a comment. using EXPECT_THAT_EXPECTED Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-too

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355472. kuhnel marked an inline comment as done. kuhnel added a comment. argh, again fixed autoformatter :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: ll

[PATCH] D105014: added some example code for llvm::Expected

kuhnel marked 4 inline comments as done. kuhnel added inline comments. Comment at: llvm/include/llvm/Support/Error.h:462 +/// +/// Unit-testing a function returning an 'Expceted': +/// @code{.cpp} sammccall wrote: > This seems too intrusive/unusual to put inli

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355471. kuhnel marked 2 inline comments as done. kuhnel added a comment. fixed variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355470. kuhnel added a comment. addressed Sam's review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Error.h Index: llvm

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 355466. kuhnel added a comment. forgot header comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ex

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is only the indexing part, it is NOT wired up to t

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 354855. kuhnel added a comment. undo of auto formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Error.h Index: llvm/includ

[PATCH] D105014: added some example code for llvm::Expected

kuhnel added a comment. Argh, the auto formatter seems to have done some magic. I guess I should revert these? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 354849. kuhnel added a comment. removed stray file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Error.h Index: llvm/include/llvm

[PATCH] D105014: added some example code for llvm::Expected

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. Since I had some fun

[PATCH] D94293: [clangd] automatically index STL

kuhnel abandoned this revision. kuhnel added a comment. thx for the review and feedback! I guess I'll re-design the feature and add a new indexing layer instead. However that might take a while, so I'll abandon this revision and start a new one later on. Repository: rG LLVM Github Monorepo

[PATCH] D94293: [clangd] automatically index STL

kuhnel added a comment. Yes, I was looking for feedback on this one as I wasn't happy with my design. Comment at: clang-tools-extra/clangd/index/Background.cpp:449 + // TODO(kuhnel): is the a better place to store this file? + // TODO(kuhnel): do we need a file at all, can we

[PATCH] D94293: [clangd] automatically index STL

kuhnel added a comment. @sammccall here the first implementation we talked about yesterday. This works well on my testing poject that has a compile_commands.json. It does not work without one. Also I'm not really happy with the design as I haven't really found a good place to store the generat

[PATCH] D94293: [clangd] automatically index STL

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94293 Fil

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. @phosek sorry for the late reply, the builds on master are still green, so your changes are working on Windows as well. Thank you for the extra work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. > Looking at the error, it seems like you have a 32-bit version of zlib > installed and in your search path on a 64-bit version of Windows. I'm not > quite sure how to handle that in CMake. For mlir-windows buildbot: I have no clue on what is installed there. For pre-me

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. In D79219#2202048 , @phosek wrote: > How can I test this change on pre-merge bots? I haven't seen any builds > posted on this change before. You can just look at the mlir-windows buildbot, this also showed the failing build: http

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. This patch broke the Windows compilation on buildbot and pre-merge testing . So I'll revert it to get pre-merge testing back online. Otherwise th

[PATCH] D81737: docker images for mlir-nvidia

kuhnel updated this revision to Diff 270984. kuhnel marked 3 inline comments as done. kuhnel added a comment. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. improved tagging of images Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://review

[PATCH] D81737: docker images for mlir-nvidia

kuhnel updated this revision to Diff 270985. kuhnel added a comment. fixed last patch Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81737/new/ https://reviews.llvm.org/D81737 Files: buildbot/google/README.md buildbot/google/docker/README.md b

[PATCH] D81737: docker images for mlir-nvidia

kuhnel added inline comments. Comment at: buildbot/google/docker/build_deploy.sh:36 + +docker build -t ${IMAGE_NAME}:latest -t ${IMAGE_NAME}:${VERSION} . + tra wrote: > What if I happen to run it in a tree I haven't updated for a while? We > probably don't want

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kuhnel added a comment. thx for the feedback, I created an issue for this: https://github.com/google/llvm-premerge-checks/issues/98 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new/ https://reviews.llvm.org/D72715 ___

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

kuhnel added a comment. I had a look at the build problems: https://github.com/google/llvm-premerge-checks/issues/56 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70357/new/ https://reviews.llvm.org/D70357 ___

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kuhnel added a comment. Build failed as patch failed to apply: 00:00:06.098 Checking patch clang-tools-extra/trunk/clangd/FindTarget.h... 00:00:06.100 error: clang-tools-extra/trunk/clangd/FindTarget.h: does not exist in index 00:00:06.100 Checking patch clang-tools-extra/trunk/clangd/Find

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kuhnel added a comment. Build failed during patching: 00:03:00.433 [Phabricator] $ arc patch --diff 225207 --nocommit --nobranch --conduit-uri=https://reviews.llvm.org 00:03:01.736 INFO Base commit is not in local repository; trying to fetch. 00:03:02.694 00:03:02.694 00:0

[PATCH] D68630: [clangd] Disable expand auto on decltype(auto)

kuhnel added a comment. as the automatic build report did not work: Failing Tests (1): LLVM :: tools/llvm-ar/mri-utf8.test http://results.llvm-merge-guard.org/Phabricator-23/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68630/new/ https:

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel updated this revision to Diff 209234. kuhnel marked 3 inline comments as done. kuhnel added a comment. pair programming with Sam, fixed final issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel updated this revision to Diff 208923. kuhnel marked 13 inline comments as done. kuhnel added a comment. fixed parts of the 3rd round of review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel updated this revision to Diff 208706. kuhnel added a comment. fixed typo on "Deducted" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/cl

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:172 +namespace { +/// Computes the deduced type at a given location by visiting the relevant sammccall wrote: > It looks like this has been moved from somewhere (at least code looks > f

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel updated this revision to Diff 208705. kuhnel marked 22 inline comments as done. kuhnel added a comment. Allrighty then, next update: - moved 2 helper funtions to `AST.cpp` - added `ASTTests.cpp` - added more tests - removed a lot of redundant code - implemented corner case for not replacin

[PATCH] D62855: Implementation of auto type expansion.

kuhnel updated this revision to Diff 207039. kuhnel marked an inline comment as done. kuhnel added a comment. fixed merge error around hasDeducedType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855 Files:

[PATCH] D62855: Implementation of auto type expansion.

kuhnel updated this revision to Diff 207037. kuhnel marked 10 inline comments as done. kuhnel added a comment. fixed code review comments from sam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855 Files:

[PATCH] D62855: Implementation of auto type expansion.

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62855 Files: clang-tools-extra/clangd/AST.cpp clang-too

[PATCH] D60826: Clarify -Winfinite-recursion message

kuhnel created this revision. kuhnel added a reviewer: meikeb. Herald added a project: clang. Test review from the tutorial Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60826 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/SemaCXX/warn-infinite-recursi