kuhnel marked 4 inline comments as done.
kuhnel added a comment.
Thx @sammccall for your patience with this cleanup.
================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:103
-static clang::clangd::Key<std::string> kFileBeingProcessed;
+static clang::clangd::Key<std::string> KFileBeingProcessed;
----------------
sammccall wrote:
> I think this got reverted - should just be `FileBeingProcessed`
Right, sorry about the backsliding there. If I were ever to do such a cleanup
again, I need to really split manual and automatic steps into separate commits
and keep them in a separate branch before squashing them for `arc diff`.
================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1864
}
- QualType VisitCoyieldStmt(const CoyieldExpr *S) {
+ QualType visitCoyieldStmt(const CoyieldExpr *S) {
return type(S->getOperand());
----------------
sammccall wrote:
> this was a bug! should be `VisitCoyieldExpr` (capital because it's a CRTP
> override).
>
> But this is is a functional bugfix, please either leave a fixme or change in
> a separate patch
added FIXME, feel feel free to create a patch for it
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115634/new/
https://reviews.llvm.org/D115634
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
