[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2901304 , @baramin wrote: > This is true. > .clang-format: > > Language:Cpp > AlignConsecutiveAssignments: Consecutive > BinPackArguments: false > BinPackParameters: false > ColumnLimit:

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 361414. MarcusJohnson91 added a comment. Getting weird crashes all over the place in code I didn't touch, no idea what's going on CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103426/new/ https://reviews.llvm.org/D103426 Files: clang/lib

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

RedDocMD added a comment. It turns out that there is already an option called `extra-analyzer-config` to pass analyzer configs, like setting `ModelSmartPtrDereference` to true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106739/new/ https://revie

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

RedDocMD created this revision. RedDocMD added reviewers: vsavchenko, NoQ, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this revision. He

[PATCH] D106738: [RISCV] Use getNaturalPointeeTypeAlignment to get alignment for stores created for vector builtins.

craig.topper created this revision. craig.topper added reviewers: HsiangKai, evandro, khchen, arcbbb. Herald added subscribers: StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jone

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

bcain added a comment. This patch is so far just for discussion, still needs tests, etc. The motivation for this patch is to be able to include the intrinsic header files installed in the resource dir. I've taken inspiration from `ToolChains/Linux.cpp` here. Repository: rG LLVM Github Mono

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

bcain created this revision. bcain added reviewers: sidneym, MaskRay. bcain requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106737 Files: clang/lib/Driver/ToolChains/Hexagon.cpp Index: clang/lib/Driver/ToolChai

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 361410. MarcusJohnson91 added a comment. Rebased on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103426/new/ https://reviews.llvm.org/D103426 Files: clang/lib/AST/OSLog.cpp clang/lib/Sema/SemaChecking.cpp clang/lib/StaticAnalyze

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. In D106577#2901654 , @rsmith wrote: > I think this patch as it stands would cause problems with libc > implementations that put their `#define` somewhere other than than > `stdc-predef.h` (eg, older versions of glibc that put i

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:77-80 + const Decl *D = nullptr; + if (T->isTypedefNameType()) { +D = T->getAs()->getDecl(); + } aaron.ballman wrote: > This approach seems fragile for getting access to an A

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 361409. MarcusJohnson91 marked an inline comment as done. MarcusJohnson91 added a comment. #1: Moved a comment to the top, so it's brettier 😊 #2: Moved all the ugly StringLiteral conversion code to StringLiteral::getStrDataAsChar and forwarded that f

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

rnk added a comment. In D106721#2901728 , @efriedma wrote: > Do we need LLVM intrinsics for these? For the x86 equivalents, we just > generate `mul i128`. I worry that LLVM will end up generating a call to compiler-rt to implement i128 arithmetic, esp

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 361405. MarcusJohnson91 marked an inline comment as done. MarcusJohnson91 added a comment. Just implemented the change Aaron requested in TemplateBase.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103426/new/ https://reviews.llvm.org/D10

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); MaskRay wrote: > dblaikie

[PATCH] D106585: Fix clang debug info irgen of i128 enums

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); ---

[PATCH] D106734: Eliminate clang man page generation warning for missing .rst files

t-tye created this revision. t-tye added reviewers: kzhuravl, scott.linder. Herald added a subscriber: mgorny. t-tye requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Update `clang/docs/CMakeLists.txt` for Sphinx man builder

[PATCH] D106733: [clang/darwin] Pass libclang_rt.profile last on linker command

thakis added a comment. Whoops, I'm so used to sending lld changes that I put the wrong reviewers and subscribers at first. Fixed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106733/new/ https://reviews.llvm.org/D106733 ___ cfe-commits

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz created this revision. beanz added reviewers: aaron.ballman, rsmith, erik.pilkington, lgerbarg, pete. Herald added a subscriber: dexonsmith. beanz requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. This p

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 ___

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 updated this revision to Diff 361387. tianshilei1992 added a comment. rebase and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/tes

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

Quuxplusone requested changes to this revision. Quuxplusone added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:810 +def err_requires_expr_in_simple_requirement : Error< + "requires expression in req

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106260/new/ https://reviews.llvm.org/D106260 _

[PATCH] D106724: [WebAssembly] Codegen for extmul SIMD instructions

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

efriedma added a comment. Do we need LLVM intrinsics for these? For the x86 equivalents, we just generate `mul i128`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106721/new/ https://reviews.llvm.org/D106721

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

mstorsjo created this revision. mstorsjo added reviewers: rnk, STL_MSFT, efriedma, DavidSpickett. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. mstorsjo requested review of this revision. Herald added projects: clang, LLVM. This seems to work, but would it need more testing for a

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay added a comment. In D106701#2901639 , @efriedma wrote: > Can we hook this up to a LLVM IR function attribute, instead of making it a > codegen flag? The current TargetLoweringBase::PrefLoopAlignment is global. I have considered a function attri

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

rsmith added a comment. I think this patch as it stands would cause problems with libc implementations that put their `#define` somewhere other than than `stdc-predef.h` (eg, older versions of glibc that put it in `features.h` or other standard libraries that put it in `yvals.h`) due to the mac

[PATCH] D106252: Implement P2092

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM upon inspection. There aren't any cases in libc++ that I'm aware of that will break because of this, but I think it's a good practice to try and bootstrap the library for certainty. Please a

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

efriedma added a comment. Can we hook this up to a LLVM IR function attribute, instead of making it a codegen flag? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106701/new/ https://reviews.llvm.org/D106701 ___

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

bnbarham added a comment. Yep, that would be perfect :). Thanks @mibintc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/ https://reviews.llvm.org/D95159 ___ cfe-commits mailing list cfe-commits@

[PATCH] D106585: Fix clang debug info irgen of i128 enums

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); rnk wrote: > rnk wrot

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:304 + +def pp_pragma_include_instead_not_sysheader : Error< + "'#pragma clang include_instead' cannot be used outside of system headers">, aaron.ballman wrote: > Can you pref

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 361357. cjdb marked 11 inline comments as done. cjdb added a comment. applies all of @aaron.ballman's remaining feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106394/new/ https://reviews.llvm.org/D106394

[clang] 85157c0 - [WebAssembly] Codegen for pmin and pmax

Author: Thomas Lively Date: 2021-07-23T14:49:21-07:00 New Revision: 85157c0079031b51c0446b222894aec4aad71b53 URL: https://github.com/llvm/llvm-project/commit/85157c0079031b51c0446b222894aec4aad71b53 DIFF: https://github.com/llvm/llvm-project/commit/85157c0079031b51c0446b222894aec4aad71b53.diff

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85157c007903: [WebAssembly] Codegen for pmin and pmax (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106612/new/ https://reviews.llvm.org/D106612 __

[PATCH] D106715: Thread safety analysis: Drop special block handling

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previous changes like D101202 and D104261

[PATCH] D106713: Thread safety: Warn when demoting locks on back edges

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously in D104261 we warned about dropping locks

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361344. dgoldman added a comment. Test collectPragmaMarksCallback + preamble merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clang

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

baramin added a comment. This is true. .clang-format: Language:Cpp AlignConsecutiveAssignments: Consecutive BinPackArguments: false BinPackParameters: false ColumnLimit: 120 ConstructorInitializerIndentWidth: 4 ContinuationIndentWidth: 4 IndentWidth: 4 TabWidth:

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

yaxunl added a comment. In D106315#2900882 , @tra wrote: > In D106315#2899928 , @yaxunl wrote: > >> Yes that's possible. However that would require FE to know these functions >> and declare them, whereas the curr

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2900803 , @baramin wrote: > You are right. > > The problem is in > > FromLegacyTimestamp(monitorFrequencyUsec), > seconds(std::uint64_t(maxSampleAge)), maxKeepSamples)); > > line indentation. It is 6 instead

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2900770 , @m1cha wrote: > In D106349#2897400 , > @HazardyKnusperkeks wrote: > >> Looks good, could you also add a note in the relasenotes.rst? > > Sure > > Can I do

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk updated this revision to Diff 361306. rnk added a comment. - add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106585/new/ https://reviews.llvm.org/D106585 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-

[libunwind] a085c23 - [libunwind] Allow restoring SP while unwinding.

Author: Marco Vanotti Date: 2021-07-23T12:39:49-07:00 New Revision: a085c23aa3c8f91866d7f4588d4f683407dc775d URL: https://github.com/llvm/llvm-project/commit/a085c23aa3c8f91866d7f4588d4f683407dc775d DIFF: https://github.com/llvm/llvm-project/commit/a085c23aa3c8f91866d7f4588d4f683407dc775d.diff

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

joerg added a comment. In D106577#2899715 , @aaron.ballman wrote: > In D106577#2899711 , @joerg wrote: > >> This patch is certainly wrong for NetBSD as the wchar_t encoding is up to >> the specific locale charse

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); rnk wrote: > dblaikie wrot

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay created this revision. MaskRay added reviewers: compnerd, craig.topper, rsmith. Herald added subscribers: ormris, StephenFan, frasercrmck, dexonsmith, dang, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jone

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); dblaikie wrote: > rnk wrot

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, LocFilter

chh updated this revision to Diff 361295. chh retitled this revision from "[clang-tidy] New feature --skip-headers, part 1, skip Decls" to "[clang-tidy] New feature --skip-headers, part 1, LocFilter". chh edited the summary of this revision. chh added a comment. Add an AllFileFinder for checks th

[PATCH] D103385: [clang-tidy] bugprone-forwarding-reference-overload: support non-type template parameters

jwtowner marked 2 inline comments as done. jwtowner added a comment. It should be good to go. I do not have commit access so feel free to commit. Thanks! Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:34 + template,A&&...>

[PATCH] D103385: [clang-tidy] bugprone-forwarding-reference-overload: support non-type template parameters

jwtowner updated this revision to Diff 361289. jwtowner added a comment. Improved the code formatting of the samples in the documentation and added back in the newline at the end of the bugprone-forwarding-reference-overload.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. Even after the more recent discussion, I still think my initial message was incorrect, and that the compiler should be defining this macro itself, as proposed in this patch. Note that my confusion was not that the macro being defined or not was dependent on libc behavi

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1141 +def : Pat<(vec.int_vt (vselect +(setolt (vec.vt (bitconvert V128:$rhs)), +(vec.vt (bitconvert V128:$lhs))), aheejin wrote: > Sorry

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1141 +def : Pat<(vec.int_vt (vselect +(setolt (vec.vt (bitconvert V128:$rhs)), +(vec.vt (bitconvert V128:$lhs))), Sorry I asked this in

[clang] e7afaad - Revert "Delete PrintingPolicy's copy constructor/operator."

Author: Erich Keane Date: 2021-07-23T11:24:30-07:00 New Revision: e7afaadd8b7a41cf9fab15786e863e78a8cc1473 URL: https://github.com/llvm/llvm-project/commit/e7afaadd8b7a41cf9fab15786e863e78a8cc1473 DIFF: https://github.com/llvm/llvm-project/commit/e7afaadd8b7a41cf9fab15786e863e78a8cc1473.diff L

[clang] 68ef916 - Delete PrintingPolicy's copy constructor/operator.

Author: Erich Keane Date: 2021-07-23T11:22:52-07:00 New Revision: 68ef916659b9cd4127276f9502fc2870ca6cfdea URL: https://github.com/llvm/llvm-project/commit/68ef916659b9cd4127276f9502fc2870ca6cfdea DIFF: https://github.com/llvm/llvm-project/commit/68ef916659b9cd4127276f9502fc2870ca6cfdea.diff L

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

tra added a comment. In D106315#2899928 , @yaxunl wrote: > Yes that's possible. However that would require FE to know these functions > and declare them, whereas the current approach leave the concern to the > device library. I was thinking of just add

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added a comment. The commit message needs rewriting to reflect the final patch. Also, "Explicitly target-abi encoded in IR is clear than empty target-abi." is wrong, it's not about clarity, it's about robustness and correctness. Comment at: clang/lib/Basic/Targets/RISC

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added inline comments. Comment at: llvm/lib/Support/TargetParser.cpp:341-344 + } + if (ISAInfo.hasExtension("d")) +return "lp64d"; + return "lp64"; makes me feel more comfortable inside, and also is a bit more like the old code where we did explici

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

anjankgk created this revision. anjankgk added reviewers: hubert.reinterpretcast, cebowleratibm, Whitney. Herald added a subscriber: dang. anjankgk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to parse the -b option in the driver

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

baramin added a comment. You are right. The problem is in FromLegacyTimestamp(monitorFrequencyUsec), seconds(std::uint64_t(maxSampleAge)), maxKeepSamples)); line indentation. It is 6 instead of 4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

craig.topper added a comment. In D106210#2899361 , @pengfei wrote: > Happened to see it. I thought Craig might miss it. Thanks @pengfei Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106210/new/ https://re

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha added a comment. In D106349#2897400 , @HazardyKnusperkeks wrote: > Looks good, could you also add a note in the relasenotes.rst? Sure Can I do something about the failing unittests? I don't know how they are related to the changes I made. CHAN

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

MaskRay added a comment. In D106535#2900728 , @kadircet wrote: > Can you provide a reproducer or build bot failure for the crash Fangrui ? I already provided an internal bug :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

MyDeveloperDay added a comment. In D98214#2900371 , @baramin wrote: > We have a regression after the fix: > CPP-25899 CLion formatting > does not match what clang-format produces > > if > > AlignConsecuti

Re: [PATCH] D106535: [clangd] Use CommandMangler in TestTU

Can you provide a reproducer or build bot failure for the crash Fangrui ? On Fri, Jul 23, 2021 at 6:50 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added a comment. > > `[clangd] Get rid of arg adjusters in CommandMangler` can crash > `BuildCompilerInvocation.Drops

[clang] 7290ddd - Revert "[clang] -falign-loops="

Author: Fangrui Song Date: 2021-07-23T09:58:35-07:00 New Revision: 7290ddd6b1090aaab5f8759581c8d307595567ae URL: https://github.com/llvm/llvm-project/commit/7290ddd6b1090aaab5f8759581c8d307595567ae DIFF: https://github.com/llvm/llvm-project/commit/7290ddd6b1090aaab5f8759581c8d307595567ae.diff

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 361264. khchen added a comment. address @jrtc27's comment, thanks! I forget RISCVISAInfo include XLen.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/

[PATCH] D106681: [analyzer] Retrieve a value from list initialization of constant multi-dimensional array.

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, xazax.hun, r.stahl, chrish_ericsson_atx. ASDenysPetrov added a project: clang. Herald added subscribers: manas, steakhal, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftwar

[clang-tools-extra] 2aa0cf1 - Revert D106562 "[clangd] Get rid of arg adjusters in CommandMangler"

Author: Fangrui Song Date: 2021-07-23T09:50:43-07:00 New Revision: 2aa0cf19e7fe17c9eb5eb2555e10184061b933f1 URL: https://github.com/llvm/llvm-project/commit/2aa0cf19e7fe17c9eb5eb2555e10184061b933f1 DIFF: https://github.com/llvm/llvm-project/commit/2aa0cf19e7fe17c9eb5eb2555e10184061b933f1.diff

[clang] 42896ee - [clang] -falign-loops=

Author: Fangrui Song Date: 2021-07-23T09:50:43-07:00 New Revision: 42896eeed9e3d12e7e38217a0d7e35b9736451ac URL: https://github.com/llvm/llvm-project/commit/42896eeed9e3d12e7e38217a0d7e35b9736451ac DIFF: https://github.com/llvm/llvm-project/commit/42896eeed9e3d12e7e38217a0d7e35b9736451ac.diff

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

MaskRay added a comment. `[clangd] Get rid of arg adjusters in CommandMangler` can crash `BuildCompilerInvocation.DropsPlugins`. I am testing `ninja check-clangd` and will push the revert shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1065

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin added a comment. In D106577#2899715 , @aaron.ballman wrote: > In D106577#2899711 , @joerg wrote: > >> This patch is certainly wrong for NetBSD as the wchar_t encoding is up to >> the specific locale cha

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated aaron.ballman wrote: > cor3ntin wrote: > > cor3ntin wrote: > > > aaron.ballman wrote: > > > > Here's an interestin

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-features'.

khchen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:835 +llvm::RISCVISAInfo::filterISAStrings(Features); +std::vector Ops; +if (Features.empty()) { jrtc27 wrote: > Why is this building a list? Just use a string so it's in the

[clang-tools-extra] e7590d7 - Revert "[clangd] Canonicalize compile flags before applying edits"

Author: Kadir Cetinkaya Date: 2021-07-23T18:20:52+02:00 New Revision: e7590d748adfa6afb67c4fb4f72c6f7eeb812734 URL: https://github.com/llvm/llvm-project/commit/e7590d748adfa6afb67c4fb4f72c6f7eeb812734 DIFF: https://github.com/llvm/llvm-project/commit/e7590d748adfa6afb67c4fb4f72c6f7eeb812734.dif

[clang-tools-extra] 04e21fb - Revert "[clangd] Adjust compile flags to contain only the requested file as input"

Author: Kadir Cetinkaya Date: 2021-07-23T17:58:11+02:00 New Revision: 04e21fbc44c145d5599ef8db9aaf66b159107f33 URL: https://github.com/llvm/llvm-project/commit/04e21fbc44c145d5599ef8db9aaf66b159107f33 DIFF: https://github.com/llvm/llvm-project/commit/04e21fbc44c145d5599ef8db9aaf66b159107f33.dif

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361247. dgoldman added a comment. minor comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tools

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, dgoldman wrote: > sammccall wrote: > > FWIW the f

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361246. dgoldman added a comment. Add in suggested algorithm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp cl

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

thakis added a comment. One of your 4 commits in https://github.com/llvm/llvm-project/compare/f86570cd5241...ba5dd945ad91 broke check-clangd on arm macs: http://45.33.8.238/macm1/14648/step_9.txt Please take a look, and revert for now if it takes a while to fix. (And consider spreading out co

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:236-242 + const BugMessageMap BugMessages = { + {&BT_FileNull, "Assuming opening the stream fails here"}, + {&BT_UseAfterClose, "Stream closed here"}, + {&BT_UseAfterO

[PATCH] D106642: [Analyzer][solver][NFC] print constraints deterministically (ordered by their string representation)

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! You got me thinking whether two symbols can have the same dump. We definitely don't want this to happen but there's also no reason to believe it doesn't, given that this wouldn't affect any

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

baramin added a comment. We have a regression after the fix: CPP-25899 CLion formatting does not match what clang-format produces if AlignConsecutiveAssignments: Consecutive Additional two spaces before `=` were added to indentation while form

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba5dd945ad91: [clangd] Adjust compile flags to contain only the requested file as input (authored by kadircet). Repository: rG LLVM Github Monorep

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cc8a8e3849d: [clangd] Canonicalize compile flags before applying edits (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ ht

[clang-tools-extra] ba5dd94 - [clangd] Adjust compile flags to contain only the requested file as input

Author: Kadir Cetinkaya Date: 2021-07-23T17:15:06+02:00 New Revision: ba5dd945ad9124f24452987be64040a6ea6cd25e URL: https://github.com/llvm/llvm-project/commit/ba5dd945ad9124f24452987be64040a6ea6cd25e DIFF: https://github.com/llvm/llvm-project/commit/ba5dd945ad9124f24452987be64040a6ea6cd25e.dif

[clang-tools-extra] 7cc8a8e - [clangd] Canonicalize compile flags before applying edits

Author: Kadir Cetinkaya Date: 2021-07-23T17:15:06+02:00 New Revision: 7cc8a8e3849dc4044cc799e2c1f6cc241b851b70 URL: https://github.com/llvm/llvm-project/commit/7cc8a8e3849dc4044cc799e2c1f6cc241b851b70 DIFF: https://github.com/llvm/llvm-project/commit/7cc8a8e3849dc4044cc799e2c1f6cc241b851b70.dif

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c0d0085bcaa: [clangd] Get rid of arg adjusters in CommandMangler (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 1c0d008 - [clangd] Get rid of arg adjusters in CommandMangler

Author: Kadir Cetinkaya Date: 2021-07-23T17:15:06+02:00 New Revision: 1c0d0085bcaaf27cc8d9492eb3c5c05058e54b8e URL: https://github.com/llvm/llvm-project/commit/1c0d0085bcaaf27cc8d9492eb3c5c05058e54b8e DIFF: https://github.com/llvm/llvm-project/commit/1c0d0085bcaaf27cc8d9492eb3c5c05058e54b8e.dif

[clang] d2a6ec8 - [clangd] Use CommandMangler in TestTU

Author: Kadir Cetinkaya Date: 2021-07-23T17:15:05+02:00 New Revision: d2a6ec8eae75b60081e081eeb37022839f4f2d04 URL: https://github.com/llvm/llvm-project/commit/d2a6ec8eae75b60081e081eeb37022839f4f2d04 DIFF: https://github.com/llvm/llvm-project/commit/d2a6ec8eae75b60081e081eeb37022839f4f2d04.dif

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2a6ec8eae75: [clangd] Use CommandMangler in TestTU (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:233 + // Use the explicitly target-feature to compute default ABI. + if (getABI().empty()) { +bool Is64Bit = getTriple().getArch() == llvm::Triple::riscv64; I don't think using the

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:235 +bool Is64Bit = getTriple().getArch() == llvm::Triple::riscv64; +ABI = llvm::RISCV::computeDefaultABIFromArch(ISAInfo, Is64Bit).str(); + } The ISAInfo includes XLen ===

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

khchen marked an inline comment as done. khchen added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 361216. khchen added a comment. address arichardson's comment, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/lib/Basic/Targets/RISCV.cpp cla

[PATCH] D106669: [clangd] Unify compiler invocation creation

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Background-indexing is fine, be

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:106 +struct PragmaMark { + SourceLocation Loc; + std::string Text; sammccall wrote: > Line number is enough, right? > Column is not interesting, and pragma marks expanded from

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361208. dgoldman marked 3 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-ex

  1   2   >