jwtowner marked 2 inline comments as done.
jwtowner added a comment.
It should be good to go. I do not have commit access so feel free to commit.
Thanks!
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:34
+ template<typename... A,
+ enable_if_t<is_constructible_v<tuple<string,int>,A&&...>,int> = 0>
+ explicit Person(A&&... a) {}
----------------
aaron.ballman wrote:
>
The reason I didn't put the spaces in here was that I was trying to match the
style above for `enable_if_t<is_special<T>,void>`. I can add a space after the
comma there as well.
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:56
+constructor is guarded.
\ No newline at end of file
----------------
aaron.ballman wrote:
> Can you add the newline back?
Will do! Sorry about this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103385/new/
https://reviews.llvm.org/D103385
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
