[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2775 def gno_split_dwarf : Flag<["-"], "gno-split-dwarf">, Group; +def gsrc_hash_algorithm_EQ : Joined<["-"], "gsrc-hash-algorithm=">, Group, Flags<[CC1Option]>, + HelpText<"Hashing algorithm

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

rjmccall added a comment. In D97224#2604537 , @jyknight wrote: >> I'm less certain about what to do with the `__atomic_*` builtins > > The `__atomic` builtins have already been supporting under-aligned pointers > all along -- and that behavior is unchange

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___

[clang] 49ed303 - Revert "[OpenMP] Do not propagate match extensions to nested contexts"

Author: Johannes Doerfert Date: 2021-03-11T23:48:36-06:00 New Revision: 49ed3032ff17ad0a7a4fcd765dbbcac627ca6fa0 URL: https://github.com/llvm/llvm-project/commit/49ed3032ff17ad0a7a4fcd765dbbcac627ca6fa0 DIFF: https://github.com/llvm/llvm-project/commit/49ed3032ff17ad0a7a4fcd765dbbcac627ca6fa0.d

[clang] 0fe0d11 - Revert "[OpenMP] Introduce the `disable_selector_propagation` variant selector trait"

Author: Johannes Doerfert Date: 2021-03-11T23:48:35-06:00 New Revision: 0fe0d114e41c5e3448d88f4353b4047351f26be0 URL: https://github.com/llvm/llvm-project/commit/0fe0d114e41c5e3448d88f4353b4047351f26be0 DIFF: https://github.com/llvm/llvm-project/commit/0fe0d114e41c5e3448d88f4353b4047351f26be0.d

[PATCH] D95765: [OpenMP] Introduce the `disable_selector_propagation` variant selector trait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2642456abc6: [OpenMP] Introduce the `disable_selector_propagation` variant selector trait (authored by jdoerfert). Changed prior to commit: https

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad9e98b8efa0: [OpenMP] Do not propagate match extensions to nested contexts (authored by jdoerfert). Herald added subscribers: llvm-commits, hiradity

[PATCH] D94741: [Utils] Check for more global information in update_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd1bd6e58700: [Utils] Check for more global information in update_test_checks (authored by jdoerfert). Herald added a project: clang. Herald added a

[clang] b264245 - [OpenMP] Introduce the `disable_selector_propagation` variant selector trait

Author: Johannes Doerfert Date: 2021-03-11T23:31:25-06:00 New Revision: b2642456abc6f11ef0a948332ab32c335aba1bcf URL: https://github.com/llvm/llvm-project/commit/b2642456abc6f11ef0a948332ab32c335aba1bcf DIFF: https://github.com/llvm/llvm-project/commit/b2642456abc6f11ef0a948332ab32c335aba1bcf.d

[clang] ad9e98b - [OpenMP] Do not propagate match extensions to nested contexts

Author: Johannes Doerfert Date: 2021-03-11T23:31:21-06:00 New Revision: ad9e98b8efa0138559eb640023695dab54967a8d URL: https://github.com/llvm/llvm-project/commit/ad9e98b8efa0138559eb640023695dab54967a8d DIFF: https://github.com/llvm/llvm-project/commit/ad9e98b8efa0138559eb640023695dab54967a8d.d

[clang] cd1bd6e - [Utils] Check for more global information in update_test_checks

Author: Johannes Doerfert Date: 2021-03-11T23:31:16-06:00 New Revision: cd1bd6e5870044f3e35da3f713782563e0014c5d URL: https://github.com/llvm/llvm-project/commit/cd1bd6e5870044f3e35da3f713782563e0014c5d DIFF: https://github.com/llvm/llvm-project/commit/cd1bd6e5870044f3e35da3f713782563e0014c5d.d

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me! Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2388-2390 + if (DebugKind > codegenoptions::LimitedDebugInfo || + RD->hasAttr()) return false;

[PATCH] D98392: Disable Unique Internal Linkage Names for internal global vars

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdb42a4cc423: Disable unique linkage suffixes ifor global vars until demanglers can be fixed. (authored by tmsriram). Herald added a project: clang.

[clang] cdb42a4 - Disable unique linkage suffixes ifor global vars until demanglers can be fixed.

Author: Sriraman Tallam Date: 2021-03-11T20:59:30-08:00 New Revision: cdb42a4cc4239c0b592fc82021c945ce02ebe5cc URL: https://github.com/llvm/llvm-project/commit/cdb42a4cc4239c0b592fc82021c945ce02ebe5cc DIFF: https://github.com/llvm/llvm-project/commit/cdb42a4cc4239c0b592fc82021c945ce02ebe5cc.dif

[PATCH] D95624: [OpenCL][PR48896] Fix default address space in template argument deduction

bader added inline comments. Comment at: clang/test/SemaOpenCLCXX/address-space-templates.cl:60 + // Preserve the address space of the type in forwarding reference. + // CHECK: CXXMethodDecl {{.*}} operator() 'void (__private int &__private) const __generic' + foo4(i, [](auto

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

EricWF added a comment. Due to some complexities libc++ has dealing with the allocator, as well some optimizations it would be a serious undertaking to restructure libc++ to properly construct the types in the hash containers, This change would be greatly simpler and much appreciated. Reposito

[PATCH] D98436: [Hexagon] Support inlined use of cs0 and cs1

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM. @kparzysz ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98436/new/ https://reviews.llvm.org/D98436 _

[clang] 11b70b9 - Revert "[NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes"

Author: Mircea Trofin Date: 2021-03-11T18:31:19-08:00 New Revision: 11b70b9e3a7458b5b78c30020b56e8ca563a4801 URL: https://github.com/llvm/llvm-project/commit/11b70b9e3a7458b5b78c30020b56e8ca563a4801 DIFF: https://github.com/llvm/llvm-project/commit/11b70b9e3a7458b5b78c30020b56e8ca563a4801.diff

[PATCH] D98440: [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eaeb0fa67e5: [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function… (authored by mtrofin). Repository: rG LLVM Github

[clang] 5eaeb0f - [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes

Author: Mircea Trofin Date: 2021-03-11T18:15:28-08:00 New Revision: 5eaeb0fa67e57391f5584a3f67fdb131e93afda6 URL: https://github.com/llvm/llvm-project/commit/5eaeb0fa67e57391f5584a3f67fdb131e93afda6 DIFF: https://github.com/llvm/llvm-project/commit/5eaeb0fa67e57391f5584a3f67fdb131e93afda6.diff

[clang] bd2bdad - void cast to suppress -Wunused-variable in non-asserts build

Author: David Blaikie Date: 2021-03-11T17:51:31-08:00 New Revision: bd2bdad19e5a3bf910da7c2d1936a7e18b47c084 URL: https://github.com/llvm/llvm-project/commit/bd2bdad19e5a3bf910da7c2d1936a7e18b47c084 DIFF: https://github.com/llvm/llvm-project/commit/bd2bdad19e5a3bf910da7c2d1936a7e18b47c084.diff

[PATCH] D98388: [RISCV][Clang] Add RVV vle/vse intrinsic functions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:225 +Ops[0] = Builder.CreateBitCast(Ops[0], +llvm::PointerType::getUnqual(ResultType)); }], + ManualCodegenMask= [{ I think you can use ResultType->getP

[PATCH] D98466: [WebAssembly] Remove experimental SIMD instructions

tlively updated this revision to Diff 330116. tlively added a comment. - Remove widen as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98466/new/ https://reviews.llvm.org/D98466 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def cla

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

akhuang created this revision. akhuang added a reviewer: rnk. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The MSVC runtime library doesn't have a definition for wmemchr, so provide an inline implementation. Repository: rG LL

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

jdoerfert added a subscriber: ggeorgakoudis. jdoerfert added a comment. In D91556#2617144 , @kiranchandramohan wrote: > Ping @llitchev. Would you have time to take this forward? I think @ggeorgakoudis is working on an alternative API solution, we might n

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

zequanwu updated this revision to Diff 330099. zequanwu added a comment. Split clang change and IR change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98295/new/ https://reviews.llvm.org/D98295 Files: clang/include/clang/Basic/Attr.td clang/

[PATCH] D98418: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h

stuart accepted this revision. stuart added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98418/new/ https://reviews.llvm.org/D98418

[PATCH] D98466: [WebAssembly] Remove experimental SIMD instructions

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight updated this revision to Diff 330088. jyknight added a comment. Use natural alignment for `_Interlocked*` intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97224/new/ https://reviews.llvm.org/D97224 Files: clang/lib/CodeGen/CGAt

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

davide added a comment. + Lang, who probably has a better understanding of this, for visibility. I don't think this should be blocked further, but he might have a chance to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98458/new/ https://

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98458/new/ https://reviews.llvm.org/D98458 ___

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

davide added a comment. In D98458#2620731 , @MaskRay wrote: >> Mach-O doesn't support dso_local and this change broke XNU because of the >> use of dso_local. > > Can you elaborate on the unsupportness? For example, the backend can ignore > dso_local if i

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} tskeith wrote: > Does this work for an instal

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} Does this work for an install? I think there th

[PATCH] D98459: [CodeCompletion] Don't track preferred types if code completion is disabled.

sammccall created this revision. sammccall added a reviewer: kadircet. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some of this work isn't quite trivial. (As requested in D96058 ) Repository

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau added a comment. In D95635#2619804 , @serge-sans-paille wrote: > would it make sense to syndicate the minimal version in a single variable, > say `LLVM_MINIMAL_PYTHON_VERSION`, and use it in several place instead of > hard-coding the value acro

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau updated this revision to Diff 330078. ctetreau added a comment. set a var for the minimum bound Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 Files: clang/CMakeLists.txt lld/CMakeLists.txt

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

MaskRay added a comment. > Mach-O doesn't support dso_local and this change broke XNU because of the use > of dso_local. Can you elaborate on the unsupportness? For example, the backend can ignore dso_local if it does not want to support it. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

arphaman created this revision. arphaman added reviewers: davide, MaskRay. Herald added subscribers: ributzka, jkorous. arphaman requested review of this revision. Herald added a project: clang. This reverts commit 809a1e0ffd7af40ee27270ff8ba2ffc927330e71

[PATCH] D98457: [WebAssembly] Remove unimplemented-simd target features

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: jansvoboda11, wingo, dang, ecnelises, jfb, arphaman, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscri

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc92ec0dd92ba: [Matrix] Add support for matrix-by-scalar division. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] c92ec0d - [Matrix] Add support for matrix-by-scalar division.

Author: Florian Hahn Date: 2021-03-11T22:21:23Z New Revision: c92ec0dd92babe0519a4ff1c785154cde5696779 URL: https://github.com/llvm/llvm-project/commit/c92ec0dd92babe0519a4ff1c785154cde5696779 DIFF: https://github.com/llvm/llvm-project/commit/c92ec0dd92babe0519a4ff1c785154cde5696779.diff LOG:

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

dblaikie added a comment. Added a couple of other folks who might have more context on the tooling front... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ c

[PATCH] D98337: Add support for digit separators in C2x

rjmccall added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98337/new/ https://reviews.llvm.org/D98337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/ https://reviews.llvm.org/D97857 _

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. The original implementation of the attribute on GitHub.com/apple/llvm-project also used the identifier instead of the declref, so we would like to go back to that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98450/new/ https://reviews.llvm.org/D98450 _

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman created this revision. arphaman added reviewers: steven_wu, MForster. Herald added subscribers: ributzka, jkorous. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. The attribute with declref is incompatible with Apple's SDKs, as the declref at the point

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330049. arnamoy10 added a comment. Modifying the algo of default search path extraction for supporting Windows platforms. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Drive

[PATCH] D98440: [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes

mtrofin added a comment. In D98440#2620437 , @aeubanks wrote: > This doesn't break the pipeline tests in llvm/test/Other? > Running check-llvm with expensive checks is probably a good idea to see if > there are any weird issues. Done - nothing else broke

[PATCH] D98440: [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes

mtrofin updated this revision to Diff 330057. mtrofin marked an inline comment as done. mtrofin added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98440/new/ https://reviews.llvm.org/D98440 Files: clang/test/CodeGen/thinlto-

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG87fd09b25f88: [InstrProfiling] Generate runtime hook for ELF platforms (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https:

[clang] 87fd09b - [InstrProfiling] Generate runtime hook for ELF platforms

Author: Petr Hosek Date: 2021-03-11T12:29:01-08:00 New Revision: 87fd09b25f8892e07b7ba11525baa9c3ec3e5d3f URL: https://github.com/llvm/llvm-project/commit/87fd09b25f8892e07b7ba11525baa9c3ec3e5d3f DIFF: https://github.com/llvm/llvm-project/commit/87fd09b25f8892e07b7ba11525baa9c3ec3e5d3f.diff LO

[PATCH] D98440: [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes

aeubanks added a comment. This doesn't break the pipeline tests in llvm/test/Other? Running check-llvm with expensive checks is probably a good idea to see if there are any weird issues. Otherwise seems fine to me. Comment at: llvm/unittests/Analysis/CGSCCPassManagerTest.cpp:

[PATCH] D98165: [clangd] Make ProjectAwareIndex optionally sync

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc9c09632f1a: [clangd] Make ProjectAwareIndex optionally sync (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac292dafa776: [clangd] Add config block for Completion and option for AllScopes (authored by kadircet). Repository: rG LLVM Github Monorepo CHANG

[clang-tools-extra] dc9c096 - [clangd] Make ProjectAwareIndex optionally sync

Author: Kadir Cetinkaya Date: 2021-03-11T20:30:35+01:00 New Revision: dc9c09632f1a8cbb0f44a7025ab7b9e516b9d859 URL: https://github.com/llvm/llvm-project/commit/dc9c09632f1a8cbb0f44a7025ab7b9e516b9d859 DIFF: https://github.com/llvm/llvm-project/commit/dc9c09632f1a8cbb0f44a7025ab7b9e516b9d859.dif

[clang-tools-extra] ac292da - [clangd] Add config block for Completion and option for AllScopes

Author: Kadir Cetinkaya Date: 2021-03-11T20:30:35+01:00 New Revision: ac292dafa776fa9ee18d38d60c7de2da58f939f0 URL: https://github.com/llvm/llvm-project/commit/ac292dafa776fa9ee18d38d60c7de2da58f939f0 DIFF: https://github.com/llvm/llvm-project/commit/ac292dafa776fa9ee18d38d60c7de2da58f939f0.dif

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

kadircet updated this revision to Diff 330036. kadircet marked an inline comment as done. kadircet added a comment. - Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98037/new/ https://reviews.llvm.org/D98037 Files: clang-tools-ex

[PATCH] D98436: [Hexagon] Support inlined use of cs0 and cs1

sidneym updated this revision to Diff 330032. sidneym added a comment. Same patch, just added full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98436/new/ https://reviews.llvm.org/D98436 Files: clang/lib/Basic/Targets/Hexagon.cpp llv

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ConfigFragment.h:244 + struct CompletionBlock { +/// Whether code completion should include results from scopes that are n

[PATCH] D98440: [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes

mtrofin created this revision. mtrofin added reviewers: asbirlea, aeubanks. Herald added subscribers: steven_wu, hiraditya. mtrofin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Check with the analysis result by calling

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330023. arnamoy10 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Updating the patch to make -pedantic and -f2018 behave the same way, also updated the test case accordingly. CHANGES SINCE LAST ACTION https://re

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a reviewer: EricWF. akhuang added a subscriber: EricWF. akhuang added a comment. @EricWF, comments on using this attribute in libc++ vs fixing the code otherwise? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://revie

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi created this revision. Herald added subscribers: jansvoboda11, dexonsmith, dang. arlosi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds clang-cl support for the /ZH: option used to select MD5, SHA1, or SHA_256 hashing algorithms

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d8a9190db19: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang] 8d8a919 - [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

Author: Fangrui Song Date: 2021-03-11T10:13:01-08:00 New Revision: 8d8a9190db19b487198680adab9a6ca173f20bb3 URL: https://github.com/llvm/llvm-project/commit/8d8a9190db19b487198680adab9a6ca173f20bb3 DIFF: https://github.com/llvm/llvm-project/commit/8d8a9190db19b487198680adab9a6ca173f20bb3.diff

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

MaskRay added a comment. In D97894#2620077 , @manojgupta wrote: > @MaskRay I have verified that Chrome OS builds are not affected by this > change. Thank you for testing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

manojgupta accepted this revision. manojgupta added a comment. @MaskRay I have verified that Chrome OS builds are not affected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97894/new/ https://reviews.llvm.org/D97894 ___

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski added a comment. Thank you for updating this @arnamoy10 ! Comment at: flang/lib/Frontend/CompilerInvocation.cpp:26 #include "llvm/Support/raw_ostream.h" + +#include "llvm/Support/FileSystem.h" Not needed Comment at: flang/lib/Fron

[PATCH] D98436: [Hexagon] Support inlined use of cs0 and cs1

sidneym created this revision. sidneym added reviewers: bcain, kparzysz. Herald added a subscriber: hiraditya. sidneym requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Allow inline assembly to reference cs0 and cs1 registers. Reposito

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98037/new/ https://reviews.llvm.org/D98037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D98165: [clangd] Make ProjectAwareIndex optionally sync

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98165/new/ https://reviews.llvm.org/D98165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D98433: [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius added a comment. Is there something else that I should test? Comment at: clang/lib/Parse/ParseExprCXX.cpp:1447 +std::vector EmptyParamInfo; +ParseLambdaSpecifiers(/*LParenLoc=*/NoLoc, /*RParenLoc=*/NoLoc, + EmptyParamInfo, /*EllipsisLoc

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn updated this revision to Diff 33. fhahn added a comment. Thank you very much John! I applied your suggestions to the wording and removed the unneeded language feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/ https://revi

[PATCH] D98433: [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius updated this revision to Diff 329998. curdeius added a comment. Revert unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/ https://reviews.llvm.org/D98433 Files: clang/lib/Parse/ParseExprCXX.cpp clang/test/Par

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ, I am using `trackExpressionValue` to add intersetingness to the `InnerPointerVal`. That solves the original problem. However, it is causing the **MoveChecker** to add extra warnings to use-after-move cases. Essentially, when a `unique_ptr` is moved and subsequent

[PATCH] D98433: [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius created this revision. curdeius added reviewers: rsmith, aaron.ballman, faisalv. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - http://eel.is/c++draft/expr.prim.lambda - http://wg21.link/P1102 Repository: rG LLVM Gi

[PATCH] D98414: [clangd] Turn off implicit cancellation based on client capabilities

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdServer.h:153 +/// to cancel. Clients that always cancel stale requests should clear this. +bool ImplicitC

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 329989. RedDocMD added a comment. Calling trackExpressionValue to mark InnerPointerVal as interesting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/li

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 +case InvalidName::BadIdentifier: + return "the chosen name \"{0}\" is not a valid i

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 329982. ASDenysPetrov added a comment. Updated. In D96090#2618410 , @NoQ wrote: > In all cases we're supposed to have an **original** type, whether we need it > or not. Simply because we're simulating a typed l

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

serge-sans-paille added a comment. would it make sense to syndicate the minimal version in a single variable, say `LLVM_MINIMAL_PYTHON_VERSION`, and use it in several place instead of hard-coding the value across multiple files? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 329976. arnamoy10 added a comment. Clang-formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/include/fl

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

jyknight added a comment. Ping, thanks! Or, if you have suggestions on how to make it easier to review, I'd be open to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86855/new/ https://reviews.llvm.org/D86855 ___

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

hjelmn created this revision. hjelmn added reviewers: krasimir, djasper. hjelmn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The option SpaceBeforeForLoopSemiColon controls whether clang-format puts a space before the semi-colons in a fo

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

krico4272 added a comment. Herald added a subscriber: danielkiss. In D57838#1388400 , @mstorsjo wrote: > LGTM In D57838#1388400 , @mstorsjo wrote: > LGTM F15823649: reboot.zip

[PATCH] D98414: [clangd] Turn off implicit cancellation based on client capabilities

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:153 +/// to cancel. Clients that always cancel stale requests should clear this. +bool ImplicitCancellation = true; + kadircet wrote: > this makes sense as is, but i wond

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 329972. djtodoro added a comment. - rebase on top of trunk - refactor the code ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 329970. arnamoy10 added a comment. Herald added a subscriber: ormris. 1. Updated to set the default search directory for the intrinsic module 2. Modified the test case to check the prepend behavior CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9708

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau requested review of this revision. ctetreau added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___ cfe-commits mailing list cfe-commit

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau updated this revision to Diff 329965. ctetreau added a comment. This revision is now accepted and ready to land. Only require if adding test suite targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D9

[PATCH] D98414: [clangd] Turn off implicit cancellation based on client capabilities

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:153 +/// to cancel. Clients that always cancel stale requests should clear this. +bool ImplicitCancellation = true; + this makes sense as is, but i wonder if we should lif

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:473-488 +static bool mayBeValidIdentifier(llvm::StringRef Ident) { + assert(llvm::json::isUTF8(Ident)); + if (Ident.empty()) +return false; + // We don't check all the rules for non-a

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12 +if (ENABLE_GRPC_REFLECTION) + set(REFLECTION_LIBRARY grpc++_reflection) kbobyrev wrote: > kadircet wrote: > > can we move this piece into FindGRPC.cmake

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:473-488 +static bool mayBeValidIdentifier(llvm::StringRef Ident) { + assert(llvm::json::isUTF8(Ident)); + if (Ident.empty()) +return false; + // We don't check all the rules for non-as

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov added a comment. In D97388#2615104 , @NoQ wrote: > Ok then, let's try to land it! 🤞 Thanks for the approval. Before land this we should land the preparatory revision D97296 . Please, take a look. CHANGES S

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau planned changes to this revision. ctetreau added a comment. Herald added subscribers: dcaballe, cota. I plan to revive this patch. I will try to rig it to only require 3.6 or above is testing is enabled using LLVM_INCLUDE_TESTS. Hopefully if any build bots haven't been fixed by now, the

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG807466ef2812: [OpenMP] Restore backwards compatibility for libomptarget (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 807466e - [OpenMP] Restore backwards compatibility for libomptarget

Author: Joseph Huber Date: 2021-03-11T09:52:11-05:00 New Revision: 807466ef28125cf7268c860b09d5563c9c93602a URL: https://github.com/llvm/llvm-project/commit/807466ef28125cf7268c860b09d5563c9c93602a DIFF: https://github.com/llvm/llvm-project/commit/807466ef28125cf7268c860b09d5563c9c93602a.diff

[clang] df2a6ee - [Sema] Use castAs<> instead getAs<> for dereferenced pointer casts. NFCI.

Author: Simon Pilgrim Date: 2021-03-11T14:51:25Z New Revision: df2a6ee3247c9d00b42c14ea924fd25cc45bda87 URL: https://github.com/llvm/llvm-project/commit/df2a6ee3247c9d00b42c14ea924fd25cc45bda87 DIFF: https://github.com/llvm/llvm-project/commit/df2a6ee3247c9d00b42c14ea924fd25cc45bda87.diff LOG:

  1   2   >