craig.topper added inline comments.
================
Comment at: clang/include/clang/Basic/riscv_vector.td:225
+ Ops[0] = Builder.CreateBitCast(Ops[0],
+ llvm::PointerType::getUnqual(ResultType)); }],
+ ManualCodegenMask= [{
----------------
I think you can use ResultType->getPointerTo() which is a little shorter
================
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle.c:7
+// RUN: %clang_cc1 -triple riscv64 -target-feature +f -target-feature +d
-target-feature +experimental-v \
+// RUN: -Werror -Wall -o - %s >/dev/null 2>%t
+// RUN: FileCheck --check-prefix=ASM --allow-empty %s <%t
----------------
Can we use 2>&1 instead of 2>%t and skip the temporary file?
================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:686
+ // maskedoff operand which is always in first operand.
+ unsigned skew = 0;
+ if (HasMaskedOffOperand)
----------------
Capitalize Skew
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98388/new/
https://reviews.llvm.org/D98388
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
