dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land.
Looks good to me! ================ Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2388-2390 + if (DebugKind > codegenoptions::LimitedDebugInfo || + RD->hasAttr<StandaloneDebugAttr>()) return false; ---------------- Perfect - I love the symmetry/simplicity of this approach, easy to explain (as you have in the documentation) to users, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits