aeubanks added a comment. This doesn't break the pipeline tests in llvm/test/Other? Running check-llvm with expensive checks is probably a good idea to see if there are any weird issues.
Otherwise seems fine to me. ================ Comment at: llvm/unittests/Analysis/CGSCCPassManagerTest.cpp:1948 + CGSCCPassManager CGPM; + bool SCCCalled = false; + FunctionPassManager FPM; ---------------- assert this is true at the end? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98440/new/ https://reviews.llvm.org/D98440 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
