rnkovacs added a comment.
In https://reviews.llvm.org/D35796#878200, @dcoughlin wrote:
> This looks good to me! Do you have commit access, or do you need someone to
> commit it for you?
Thanks! I don't, so it would be nice if someone committed it for me.
https://reviews.llvm.org/D35796
__
dberris added inline comments.
Comment at: lib/Basic/XRayLists.cpp:29
// whether it's treated as a "never" instrument function.
- if (AlwaysInstrument->inSection("fun", FunctionName, "arg1"))
+ if (AlwaysInstrument->inSection("xray_always_instrument", "fun",
FunctionName,
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313963: [clang-format] Ignore case and stable sort
using-declarations (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D37263
Files:
cfe/trunk/lib/Format/UsingDeclarationsSorter.
Author: krasimir
Date: Thu Sep 21 21:48:17 2017
New Revision: 313963
URL: http://llvm.org/viewvc/llvm-project?rev=313963&view=rev
Log:
[clang-format] Ignore case and stable sort using-declarations
Summary:
This ignores case while sorting using-declarations, fixing a case where `_`
would appear b
Author: rsmith
Date: Thu Sep 21 21:33:20 2017
New Revision: 313957
URL: http://llvm.org/viewvc/llvm-project?rev=313957&view=rev
Log:
Closure types have no name (and can't have a typedef name for linkage
purposes), so they never formally have linkage.
Modified:
cfe/trunk/lib/AST/Decl.cpp
c
Author: krasimir
Date: Thu Sep 21 21:37:56 2017
New Revision: 313962
URL: http://llvm.org/viewvc/llvm-project?rev=313962&view=rev
Log:
[clang-tidy] Fix example in documentation, NFC
Summary: A fix in documentation.
Reviewers: bkramer
Reviewed By: bkramer
Subscribers: JDevlieghere, xazax.hun
D
Author: rsmith
Date: Thu Sep 21 21:25:05 2017
New Revision: 313955
URL: http://llvm.org/viewvc/llvm-project?rev=313955&view=rev
Log:
Give external linkage and mangling to lambdas inside inline variables and
variable templates.
This implements the proposed approach in
https://github.com/itanium-
Author: compnerd
Date: Thu Sep 21 21:01:12 2017
New Revision: 313954
URL: http://llvm.org/viewvc/llvm-project?rev=313954&view=rev
Log:
Driver: remove support for libstdc++ from CrossWindows
This code path is entirely untested and not really maintained. The
expected use here is with libc++ only.
efriedma added subscribers: cfe-commits, efriedma.
efriedma added a comment.
Please make sure to add the mailing list as a subscriber when you post a patch.
(I haven't looked at the patch yet.)
https://reviews.llvm.org/D38126
___
cfe-commits maili
Author: rsmith
Date: Thu Sep 21 19:22:32 2017
New Revision: 313953
URL: http://llvm.org/viewvc/llvm-project?rev=313953&view=rev
Log:
Clean up some mistreatment of enumerations.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/lib/AST/Decl.cpp
cfe/trunk/lib/AST/Linkage.h
Modifie
ilya-biryukov added a comment.
Friendly ping. Any suggestions for other reviewers are also very welcome.
https://reviews.llvm.org/D38081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
ilya-biryukov added a comment.
Could you please run `clang-format` on every submission?
Comment at: clangd/GlobalCompilationDatabase.cpp:98
+ {
+CompileCommandsDir = "/";
+return tryLoadDatabaseFromPath(CompileCommandsDir.getValue());
Is this some
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
Looks good modulo a few NITS.
Let me know if you need help landing this.
Comment at: unittests/clangd/ClangdTests.cpp:910
+ auto FooH = getVirtualTestFilePath("foo.h");
+ auto invalid = getVirtualTestFilePat
Author: ahatanak
Date: Thu Sep 21 18:54:36 2017
New Revision: 313952
URL: http://llvm.org/viewvc/llvm-project?rev=313952&view=rev
Log:
Add test cases that weren't committed in r313945.
Added:
cfe/trunk/test/CodeGenCXX/noescape.cpp
cfe/trunk/test/CodeGenObjC/noescape.m
cfe/trunk/test/S
Author: george.karpenkov
Date: Thu Sep 21 18:43:12 2017
New Revision: 313950
URL: http://llvm.org/viewvc/llvm-project?rev=313950&view=rev
Log:
[Analyzer] Static analyzer script for updating reference results
The script updates reference results from the previous run, and stages them.
Differentia
Author: george.karpenkov
Date: Thu Sep 21 18:41:16 2017
New Revision: 313949
URL: http://llvm.org/viewvc/llvm-project?rev=313949&view=rev
Log:
[Analyzer] Refactor analyzer testing scripts.
- Exporting needed function for future reuse.
- Idiomatic python: using with `file as f` instead of `try/f
echristo added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:2917
+CodeGenFunction &CGF, llvm::Function *F,
+bool ForceThumb) {
+ StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU;
--
gtbercea added a comment.
In https://reviews.llvm.org/D38040#878090, @Hahnfeld wrote:
> Hi Doru,
>
> if I remember correctly I submitted https://reviews.llvm.org/D34888 for a
> crash when mapping a scalar value with nested regions.
> I've marked another test in this file that the codegen for `t
Author: rsmith
Date: Thu Sep 21 18:04:22 2017
New Revision: 313948
URL: http://llvm.org/viewvc/llvm-project?rev=313948&view=rev
Log:
Fix tracking of whether a destructor would be deleted.
I've been unable to find any cases whose behavior is actually changed by this,
but only because an implicitly
eugenis added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:2917
+CodeGenFunction &CGF, llvm::Function *F,
+bool ForceThumb) {
+ StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU;
---
ilya-biryukov updated this revision to Diff 116297.
ilya-biryukov added a comment.
- Fixed CHECK-DAG typo.
https://reviews.llvm.org/D38083
Files:
clangd/ClangdUnit.cpp
test/clangd/completion-qualifiers.test
Index: test/clangd/completion-qualifiers.test
ilya-biryukov added inline comments.
Comment at: test/clangd/completion-qualifiers.test:12
+# CHECK: {"jsonrpc":"2.0","id":2,"result":[
+# CHEKC-DAG: {"label":"foo()
const","kind":2,"detail":"int","sortText":"00035foo","filterText":"foo","insertText":"foo","insertTextFormat":1}
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
In https://reviews.llvm.org/D38134#877831, @Anastasia wrote:
> Now if we have a block which is being called and enqueued at the same time,
> will we generate 2 functions for it? Could we add such test case btw?
Yes. It is covered
Author: ahatanak
Date: Thu Sep 21 17:41:05 2017
New Revision: 313945
URL: http://llvm.org/viewvc/llvm-project?rev=313945&view=rev
Log:
Add support for attribute 'noescape'.
The attribute informs the compiler that the annotated pointer parameter
of a function cannot escape and enables IRGen to att
Author: george.karpenkov
Date: Thu Sep 21 17:37:12 2017
New Revision: 313944
URL: http://llvm.org/viewvc/llvm-project?rev=313944&view=rev
Log:
[Analyzer] Log when auto-synthesized body is used.
Differential Revision: https://reviews.llvm.org/D37910
Modified:
cfe/trunk/lib/StaticAnalyzer/Core
echristo added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:2917
+CodeGenFunction &CGF, llvm::Function *F,
+bool ForceThumb) {
+ StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU;
--
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM with one tweak.
Comment at: lib/CodeGen/CGBlocks.cpp:1124
LocalDeclMap,
-
Author: rsmith
Date: Thu Sep 21 17:11:15 2017
New Revision: 313943
URL: http://llvm.org/viewvc/llvm-project?rev=313943&view=rev
Log:
Extend -ast-dump for CXXRecordDecl to dump the flags from the DefinitionData.
Modified:
cfe/trunk/lib/AST/ASTDumper.cpp
cfe/trunk/test/Frontend/float16.cpp
alexshap created this revision.
Let's take a look at the following example:
for the triple thumbv7-apple-ios8.0.0 ssize_t is long and size_t is unsigned
long,
while NSInteger is int and NSUinteger is unsigned int.
Following
https://developer.apple.com/library/content/documentation/Cocoa/Concept
eugenis added a comment.
ping
https://reviews.llvm.org/D37656
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
In https://reviews.llvm.org/D37822#877903, @Anastasia wrote:
> In https://reviews.llvm.org/D37822#877572, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D37822#873876, @Anastasia wrote:
> >
> > > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote:
> > >
> > > > In
On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vsapsai
> Date: Fri Sep 15 12:51:42 2017
> New Revision: 313386
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313386&view=rev
> Log:
> [Sema] Error out early for tags defined inside an
Author: zturner
Date: Thu Sep 21 15:16:40 2017
New Revision: 313928
URL: http://llvm.org/viewvc/llvm-project?rev=313928&view=rev
Log:
Resubmit "[lit] Refactor out some more common lit configuration code."
There were two issues, one Python 3 specific related to Unicode,
and another which is that t
Author: george.karpenkov
Date: Thu Sep 21 15:12:49 2017
New Revision: 313927
URL: http://llvm.org/viewvc/llvm-project?rev=313927&view=rev
Log:
[Analyzer] Use CC environment variable to select analyzer path in SATestBuild.
This change is required to easily test the given checkout of the analyzer,
kongyi created this revision.
kongyi added a project: clang.
Qualtype may point to null if we cannot infer its type yet.
Fixes PR33843
Repository:
rL LLVM
https://reviews.llvm.org/D38158
Files:
lib/Sema/SemaExpr.cpp
test/SemaCXX/typo-correction-crash.cpp
Index: test/SemaCXX/typo-corre
yaxunl updated this revision to Diff 116277.
yaxunl marked 6 inline comments as done.
yaxunl added a comment.
Revise by Anastasia's comments.
https://reviews.llvm.org/D37822
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGOpenCLRuntime.cpp
lib/CodeGen/CGOpenCLRuntime.h
test/CodeGen/blocks
ahatanak added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1042
+}
+
+assert(SrcElementTy->isFloatingPointTy() &&
bruno wrote:
> What happens if the SrcElementTy is float and DstElementTy isn't? Seems like
> it will hit the assertion below.
ahatanak updated this revision to Diff 116275.
ahatanak marked 8 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D32520
Files:
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Ind
Author: george.karpenkov
Date: Thu Sep 21 14:47:33 2017
New Revision: 313924
URL: http://llvm.org/viewvc/llvm-project?rev=313924&view=rev
Log:
[Analyzer] Add simple help to SATestAdd.py
Differential Revision: https://reviews.llvm.org/D38003
Modified:
cfe/trunk/utils/analyzer/SATestAdd.py
Mo
Author: george.karpenkov
Date: Thu Sep 21 14:47:13 2017
New Revision: 313923
URL: http://llvm.org/viewvc/llvm-project?rev=313923&view=rev
Log:
[Analyzer] Remove dead code from CmpRuns.py.
Differential Revision: https://reviews.llvm.org/D38003
Modified:
cfe/trunk/utils/analyzer/CmpRuns.py
Mo
Author: zturner
Date: Thu Sep 21 14:45:45 2017
New Revision: 313922
URL: http://llvm.org/viewvc/llvm-project?rev=313922&view=rev
Log:
Revert "[lit] Refactor out some more common lit configuration code."
This is breaking several bots. I have enough information to
investigate, so I'm reverting to
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me! Do you have commit access, or do you need someone to
commit it for you?
https://reviews.llvm.org/D35796
___
cfe-com
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM.
Do you want me to commit this for you?
https://reviews.llvm.org/D37861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
> But I also think it wouldn't be good to block this until ClanD indexing
> reaching a mature state.
I agree 100%.
> All in all, we are willing to reuse as much of ClangD indexing as we
Author: jhb
Date: Thu Sep 21 14:28:48 2017
New Revision: 313920
URL: http://llvm.org/viewvc/llvm-project?rev=313920&view=rev
Log:
[libunwind] Partially revert r297174 to fix build on at least FreeBSD.
The changes in r297174 moved the #include of on FreeBSD (and
probably other systems) inside of
Author: zturner
Date: Thu Sep 21 14:27:31 2017
New Revision: 313919
URL: http://llvm.org/viewvc/llvm-project?rev=313919&view=rev
Log:
[lit] Refactor out some more common lit configuration code.
debuginfo-tests has need to reuse a lot of common configuration
from clang and lld, and in general it s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313913: [libclang] Keep track of TranslationUnit instance
when annotating tokens (authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D36953?vs=111959&id=116262#toc
Repository:
rL L
Author: jbcoe
Date: Thu Sep 21 13:48:43 2017
New Revision: 313913
URL: http://llvm.org/viewvc/llvm-project?rev=313913&view=rev
Log:
[libclang] Keep track of TranslationUnit instance when annotating tokens
Summary:
Previously the `_tu` was not propagated to the returned cursor, leading to
errors
Hahnfeld added a comment.
Hi Doru,
if I remember correctly I submitted https://reviews.llvm.org/D34888 for a crash
when mapping a scalar value with nested regions.
I've marked another test in this file that the codegen for `tofrom` is correct.
So I don't know if this test checks some other cond
Author: erichkeane
Date: Thu Sep 21 13:31:01 2017
New Revision: 313911
URL: http://llvm.org/viewvc/llvm-project?rev=313911&view=rev
Log:
Remove svn-properties for file added in 313909 (NFC)
Modified:
cfe/trunk/test/SemaCXX/warn-sign-conversion-cpp11.cpp (props changed)
Propchange: cfe/trun
Fixed in 313909.
-Original Message-
From: Friedman, Eli [mailto:efrie...@codeaurora.org]
Sent: Thursday, September 21, 2017 1:14 PM
To: Keane, Erich ; cfe-commits@lists.llvm.org
Subject: Re: r313907 - Suppress Wsign-conversion for enums with matching
underlying type
On 9/21/2017 12:58 P
Author: erichkeane
Date: Thu Sep 21 13:14:08 2017
New Revision: 313909
URL: http://llvm.org/viewvc/llvm-project?rev=313909&view=rev
Log:
Add testcase I forgot to add in R313907.
Added:
cfe/trunk/test/SemaCXX/warn-sign-conversion-cpp11.cpp (with props)
Added: cfe/trunk/test/SemaCXX/warn-sig
Ugg... good catch, thanks.
-Original Message-
From: Friedman, Eli [mailto:efrie...@codeaurora.org]
Sent: Thursday, September 21, 2017 1:14 PM
To: Keane, Erich ; cfe-commits@lists.llvm.org
Subject: Re: r313907 - Suppress Wsign-conversion for enums with matching
underlying type
On 9/21/20
On 9/21/2017 12:58 PM, Erich Keane via cfe-commits wrote:
Author: erichkeane
Date: Thu Sep 21 12:58:55 2017
New Revision: 313907
URL: http://llvm.org/viewvc/llvm-project?rev=313907&view=rev
Log:
Suppress Wsign-conversion for enums with matching underlying type
As reported here: https://bugs.llv
alexshap created this revision.
Herald added a subscriber: klimek.
The wording in the documentation for the matcher isExternC appears to be
misleading since this
matcher is applicable to functions and variables as well.
This diff changes the comment regenerates the html file.
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313907: Suppress Wsign-conversion for enums with matching
underlying type (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38145?vs=116245&id=116252#toc
Repository:
rL LLV
Author: erichkeane
Date: Thu Sep 21 12:58:55 2017
New Revision: 313907
URL: http://llvm.org/viewvc/llvm-project?rev=313907&view=rev
Log:
Suppress Wsign-conversion for enums with matching underlying type
As reported here: https://bugs.llvm.org/show_bug.cgi?id=34692
A non-defined enum with a backi
zibi added a comment.
ping
https://reviews.llvm.org/D37861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313906: [Sema] Prevent InstantiateClass from checking
unrelated exception specs. (authored by vsapsai).
Changed prior to commit:
https://reviews.llvm.org/D37881?vs=116056&id=116250#toc
Repository:
rL
Author: vsapsai
Date: Thu Sep 21 12:54:12 2017
New Revision: 313906
URL: http://llvm.org/viewvc/llvm-project?rev=313906&view=rev
Log:
[Sema] Prevent InstantiateClass from checking unrelated exception specs.
Sema::InstantiateClass should check only exception specs added during
class instantiation
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
erichkeane updated this revision to Diff 116245.
erichkeane marked an inline comment as done.
https://reviews.llvm.org/D38145
Files:
lib/Sema/SemaChecking.cpp
test/SemaCXX/warn-sign-conversion-cpp11.cpp
Index: test/SemaCXX/warn-sign-conversion-cpp11.cpp
=
erichkeane added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8176
+ // underlying type, so that when someone specifies the type as
+ // "unsigned" it doesn't cause sign-conversion type warnings.
if (!Enum->isCompleteDefinition())
efrie
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8176
+ // underlying type, so that when someone specifies the type as
+ // "unsigned" it doesn't cause sign-conversion type warnings.
if (!Enum->isCompleteDefinition())
Explici
erichkeane updated this revision to Diff 116244.
erichkeane marked 2 inline comments as done.
erichkeane added a comment.
Updated based on Eli's feedback.
https://reviews.llvm.org/D38145
Files:
lib/Sema/SemaChecking.cpp
test/SemaCXX/warn-sign-conversion-cpp11.cpp
Index: test/SemaCXX/warn-
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D38046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313899: [CUDA] Fixed order of words in the names of shfl
builtins. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D38147?vs=116228&id=116238#toc
Repository:
rL LLVM
https://rev
Author: tra
Date: Thu Sep 21 11:46:39 2017
New Revision: 313899
URL: http://llvm.org/viewvc/llvm-project?rev=313899&view=rev
Log:
[CUDA] Fixed order of words in the names of shfl builtins.
Differential Revision: https://reviews.llvm.org/D38147
Modified:
cfe/trunk/lib/Headers/__clang_cuda_int
Author: tra
Date: Thu Sep 21 11:44:49 2017
New Revision: 313898
URL: http://llvm.org/viewvc/llvm-project?rev=313898&view=rev
Log:
[NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync}
instructions/intrinsics/builtins.
Differential Revision: https://reviews.llvm.org/D38148
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313898: [NVPTX] Implemented bar.warp.sync, barrier.sync, and
vote{.sync}… (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D38148?vs=116236&id=116237#toc
Repository:
rL LLVM
http
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8176
+return IntRange(C.getIntWidth(QualType(T, 0)),
+!ET->isSignedIntegerOrEnumerationType());
Maybe add a comment noting what can trigger this case?
==
tra updated this revision to Diff 116236.
tra added a comment.
Fixed a typo in one test.
https://reviews.llvm.org/D38148
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/Headers/__clang_cuda_intrinsics.h
clang/test/CodeGen/builtins-nvptx-ptx60.cu
clang/test/CodeGen/builtins-
tra created this revision.
Herald added subscribers: hiraditya, sanjoy, jholewinski.
https://reviews.llvm.org/D38148
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/Headers/__clang_cuda_intrinsics.h
clang/test/CodeGen/builtins-nvptx-ptx60.cu
clang/test/CodeGen/builtins-nvptx.
wmi updated this revision to Diff 116232.
wmi added a comment.
Changes following the discussion:
- Put the bitfield split logic under an option and off by default.
- When sanitizer is enabled, the option for bitfield split will be ignored and
a warning message will be emitted.
In addition, a te
b-sumner added a comment.
In https://reviews.llvm.org/D37822#877903, @Anastasia wrote:
> In https://reviews.llvm.org/D37822#877572, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D37822#873876, @Anastasia wrote:
> >
> > > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote:
> > >
> > > > I
jlebar added a comment.
> The problem of adding this attribute conservatively for all functions is that
> it prevents some optimizations to happen.
function-attrs removes the convergent attribute from anything it can prove does
not call a convergent function.
I agree this is a nonoptimal solut
Anastasia added a comment.
In https://reviews.llvm.org/D37822#877572, @yaxunl wrote:
> In https://reviews.llvm.org/D37822#873876, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote:
> >
> > > In https://reviews.llvm.org/D37822#872291, @Anastasia wrote:
> > >
> > > >
jlebar added a comment.
Naturally they're different orders in the PTX and CUDA. :)
https://reviews.llvm.org/D38147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra created this revision.
Herald added a subscriber: sanjoy.
https://reviews.llvm.org/D38147
Files:
clang/lib/Headers/__clang_cuda_intrinsics.h
Index: clang/lib/Headers/__clang_cuda_intrinsics.h
===
--- clang/lib/Headers/__clang
Anastasia added a comment.
The problem of adding this attribute conservatively for all functions is that
it prevents some optimizations to happen. I agree to commit this as a temporary
fix to guarantee correctness of generated code. But if we ask to add the
`convergent` attribute into the spec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313896: [Sema] Fix using old initializer during switch
statement transformation. (authored by vsapsai).
Changed prior to commit:
https://reviews.llvm.org/D38009?vs=115754&id=116226#toc
Repository:
rL
Author: vsapsai
Date: Thu Sep 21 10:58:27 2017
New Revision: 313896
URL: http://llvm.org/viewvc/llvm-project?rev=313896&view=rev
Log:
[Sema] Fix using old initializer during switch statement transformation.
It fixes a crash in CodeGen when we are trying to generate code for
initializer expression
erichkeane created this revision.
As reported here: https://bugs.llvm.org/show_bug.cgi?id=34692
A non-defined enum with a backing type was always defaulting to
being treated as a signed type. IN the case where it IS defined,
the signed-ness of the actual items is used.
This patch uses the unde
Anastasia added a comment.
Now if we have a block which is being called and enqueued at the same time,
will we generate 2 functions for it? Could we add such test case btw?
I feel it would be much simpler if we could always generate the kernel metadata
for blocks. A lot of special case code wou
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313894: [fixup][Sema] Allow in C to define tags inside
enumerations. (authored by vsapsai).
Changed prior to commit:
https://reviews.llvm.org/D38109?vs=116110&id=116219#toc
Repository:
rL LLVM
https
Author: vsapsai
Date: Thu Sep 21 10:41:30 2017
New Revision: 313894
URL: http://llvm.org/viewvc/llvm-project?rev=313894&view=rev
Log:
[fixup][Sema] Allow in C to define tags inside enumerations.
Fix for too aggressive error err_type_defined_in_enum introduced in
r313386. Defining tags inside enum
Author: zturner
Date: Thu Sep 21 10:38:13 2017
New Revision: 313892
URL: http://llvm.org/viewvc/llvm-project?rev=313892&view=rev
Log:
[lit] Rename lld and clang lit configs to end in .py
This follows in line with a previous patch of renaming LLVM's.
Working on these files is difficult in certain
vlad.tsyrklevich added inline comments.
Comment at: lib/AST/Decl.cpp:3953
ReasonToReject = 5; // is standard layout.
- else if (Blacklist.isBlacklistedLocation(getLocation(), "field-padding"))
+ else if (Blacklist.isBlacklistedLocation(ASanMask, getLocation(),
+
vlad.tsyrklevich updated this revision to Diff 116213.
vlad.tsyrklevich marked 5 inline comments as done.
vlad.tsyrklevich added a comment.
- sanitizerCompile -> createSanitizerSections
- ASanMask -> AsanMask and fix another bug relating to ANDing with
LangOpts.Sanitize.Mask
https://reviews.llv
eandrews added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:2434
+// Emit section information for extern variables.
+if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) {
+ if (const SectionAttr *SA = D->getAttr())
efried
eandrews updated this revision to Diff 116211.
eandrews added a comment.
I've updated the patch based on review comments. The changes include setting
section unconditionally for extern variables and emitting a warning if section
attribute is specified on a redeclaration.
https://reviews.llvm.o
Rakete added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:5185
if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) {
// C++2a allows functions with ref-qualifier & if they are also
'const'.
+if (Proto->isConst() && !Proto->isVolatile
lebedev.ri added a comment.
Tried stage2 build, so far only one warning.
But found out that `ubsan_value.h`'s `typedef s128 SIntMax;` crashes this code
because
class LLVM_NODISCARD APSInt : public APInt {
...
/// \brief Get the correctly-extended \c int64_t value.
int64_t getExtValue
chh updated this revision to Diff 116201.
chh marked 2 inline comments as done.
chh edited the summary of this revision.
https://reviews.llvm.org/D35743
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
Nebiroth updated this revision to Diff 116198.
Nebiroth added a comment.
More consistent logging in clangdmain.
Restructured argument checking in ClangdMain
Fixed empty compile-commands-dir triggering error messages.
Fixed failing standard tests.
https://reviews.llvm.org/D37150
Files:
clangd/
lebedev.ri added a comment.
In https://reviews.llvm.org/D36836#877636, @alexfh wrote:
> > The metric is implemented as per COGNITIVE COMPLEXITY by SonarSource
> > specification version 1.2 (19 April 2017),
>
> Err, "I did ask them, and received an answer that it is it can be implemented
> in cl
xazax.hun updated this revision to Diff 116195.
xazax.hun added a comment.
- Unittests now creates temporary files at the correct location
- Temporary files are also cleaned up when the process is terminated
- Absolute paths are handled correctly by the library
https://reviews.llvm.org/D34512
F
alexfh added a comment.
> The metric is implemented as per COGNITIVE COMPLEXITY by SonarSource
> specification version 1.2 (19 April 2017),
Err, "I did ask them, and received an answer that it is it can be implemented
in clang-tidy" might not be enough.
Repository:
rL LLVM
https://reviews.
martell accepted this revision.
martell added a comment.
This revision is now accepted and ready to land.
It seems that msvc enabled some c++17 features when in c++14 mode and they left
them enabled because projects became dependant on them.
switching to c++17 as the default and removing the c++1
1 - 100 of 124 matches
Mail list logo
