efriedma added inline comments.
================ Comment at: lib/Sema/SemaChecking.cpp:8176 + return IntRange(C.getIntWidth(QualType(T, 0)), + !ET->isSignedIntegerOrEnumerationType()); ---------------- Maybe add a comment noting what can trigger this case? ================ Comment at: test/SemaCXX/sign-conversion.cpp:21 + return foo; +} ---------------- There's an existing file test/SemaCXX/warn-sign-conversion.cpp for C++ sign-conversion tests. https://reviews.llvm.org/D38145 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
