gtbercea added a comment. In https://reviews.llvm.org/D38040#878090, @Hahnfeld wrote:
> Hi Doru, > > if I remember correctly I submitted https://reviews.llvm.org/D34888 for a > crash when mapping a scalar value with nested regions. > I've marked another test in this file that the codegen for `tofrom` is > correct. So I don't know if this test checks some other conditions? > > Jonas Hi Jonas, The test is verifying whether the parameter is passed to the kernel correctly. I believe it was not passed as a reference before the patch. In addition to that, something that was in my previous patch is related to this code: DSAStack->checkMappableExprComponentListsForDeclAtLevel( D, Level, [&](OMPClauseMappableExprCommon::MappableExprComponentListRef In particular with the Level variable. Should the Level variable actually be Level + 1 in this case? Thanks, --Doru Repository: rL LLVM https://reviews.llvm.org/D38040 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
