pekka.jaaskelainen added a comment.
In https://reviews.llvm.org/D28080#653493, @Anastasia wrote:
> > Also, for me the command without -emit-llvm doesn't output anything.
>
> What targets do you use?
In this case I used only SPIR. I suppose this is fine as the concept of linking
is unclear in c
mehdi_amini added a comment.
In https://reviews.llvm.org/D29065#654336, @steven_wu wrote:
> I think you should add a new API for embedBitcodeMarkerEnabled() or revert
> the name the APIs to before https://reviews.llvm.org/rL287084.
I'm missing where https://reviews.llvm.org/rL287084 changed th
steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D29066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
mehdi_amini updated this revision to Diff 85530.
mehdi_amini added a comment.
Add a test
https://reviews.llvm.org/D29066
Files:
clang/lib/Driver/Tools.cpp
clang/test/Driver/embed-bitcode.c
Index: clang/test/Driver/embed-bitcode.c
===
EricWF resigned from this revision.
EricWF added a comment.
I think we've agreed that this change shouldn't proceed. Resigning as reviewer.
https://reviews.llvm.org/D28981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: ericwf
Date: Mon Jan 23 22:57:33 2017
New Revision: 292883
URL: http://llvm.org/viewvc/llvm-project?rev=292883&view=rev
Log:
[libcxx] Never use within libc++
Summary:
It is my opinion that libc++ should never use ``, including in the
`dylib`. This patch remove all uses of `assert` from
EricWF added inline comments.
Comment at: include/__config:827
# endif
+# if !defined(_LIBCPP_BUILDING_LIBRARY)
# define _LIBCPP_EXTERN_TEMPLATE(...)
mclow.lists wrote:
> Does this belong here?
>
Yeah, so `-DLIBCXX_ENABLE_ASSERTIONS=ON` now define `-D_LIBC
On Mon, Jan 23, 2017 at 4:33 PM, Hans Wennborg via Phabricator <
revi...@reviews.llvm.org> wrote:
> hans added a comment.
>
> This sounds like something we'll want to merge to the release branch when
> it lands?
>
>
> https://reviews.llvm.org/D28933
>
Yes. I'll land it tomorrow afternoon.
-- Ma
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
this LGTM. assert is not something we should have in the dylib.
Comment at: include/__config:827
# endif
+# if !defined(_LIBCPP_BUILDING_LIBRARY)
# define _
mehdi_amini added inline comments.
Comment at: clang/include/clang/CodeGen/BackendUtil.h:51
+ llvm::Expected
+ FindThinLTOModule(llvm::MemoryBufferRef MBRef);
}
Indentation seems strange?
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:841
steven_wu added a comment.
I think you should add a new API for embedBitcodeMarkerEnabled() or revert the
name the APIs to before https://reviews.llvm.org/rL287084.
https://reviews.llvm.org/D29065
___
cfe-commits mailing list
cfe-commits@lists.llvm
pcc created this revision.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D29067
Files:
clang/include/clang/CodeGen/BackendUtil.h
clang/include/clang/CodeGen/CodeGenAction.h
clang/lib/CodeGen/BackendUtil.cpp
clang/lib/CodeGen/CodeGenAction.cpp
clang/test/CMakeLists.txt
cl
mehdi_amini created this revision.
https://reviews.llvm.org/D29066
Files:
clang/lib/Driver/Tools.cpp
Index: clang/lib/Driver/Tools.cpp
===
--- clang/lib/Driver/Tools.cpp
+++ clang/lib/Driver/Tools.cpp
@@ -8435,9 +8435,13 @@
//
mehdi_amini created this revision.
These accessors maps directly to the command line option.
https://reviews.llvm.org/D29065
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
clang/lib/Driver/Tools.cpp
Index: clang/lib/Driver/Tools.cpp
==
FYI, I reverted r292800 from trunk in r292874. It was causing our internal
validation bots to have false positives whenever a static local was
dereferenced/passed to a nonnull function in a block evaluated at the top level.
Devin
> On Jan 23, 2017, at 4:19 PM, Hans Wennborg wrote:
>
> Merged
Author: dcoughlin
Date: Mon Jan 23 20:10:59 2017
New Revision: 292874
URL: http://llvm.org/viewvc/llvm-project?rev=292874&view=rev
Log:
Revert "[analyzer] Fix memory space of static locals seen from nested blocks."
This reverts commit r292800.
It is causing null pointer dereference false positiv
EricWF created this revision.
Herald added a subscriber: mgorny.
It is my opinion that libc++ should never use ``, including in the
`dylib`. This patch remove all uses of `assert` from within libc++ and replaces
most of them with `_LIBCPP_ASSERT` instead.
Additionally this patch turn `LIBCXX_EN
r292869.
On Mon, Jan 23, 2017 at 3:00 PM, Hans Wennborg wrote:
> Ok, go ahead.
>
> On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote:
> > This patch needs to get merged into 4.0 since the offending commit with
> the
> > misspelling is in the 4.0 branch.
> >
> > /Eric
> >
> >
> > On Mon, Jan
Author: ericwf
Date: Mon Jan 23 19:05:56 2017
New Revision: 292869
URL: http://llvm.org/viewvc/llvm-project?rev=292869&view=rev
Log:
Merge r292822 - Fixed a typo in __config that prevented the aligned new/delete
tests from passing on Mac OS.
Modified:
libcxx/branches/release_40/include/__con
Author: dlj
Date: Mon Jan 23 19:04:30 2017
New Revision: 292868
URL: http://llvm.org/viewvc/llvm-project?rev=292868&view=rev
Log:
Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead.
Summary:
This patch changes TableGen-generated code in AttrPCHRead to call functions on
ASTRecordRead
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292868: Switch TableGen to emit calls to ASTRecordReader for
AttrPCHRead. (authored by dlj).
Changed prior to commit:
https://reviews.llvm.org/D28007?vs=85493&id=85498#toc
Repository:
rL LLVM
https:
r292867.
On Mon, Jan 23, 2017 at 2:52 PM, Hans Wennborg wrote:
> We merged the first one, so I suppose we better fix it :-)
>
> Sounds good to me.
>
> On Mon, Jan 23, 2017 at 1:37 PM, Eric Fiselier wrote:
> > This patch should be merge into the 4.0 branch.
> >
> > It fixes a bug introduced to t
Author: ericwf
Date: Mon Jan 23 19:03:36 2017
New Revision: 292867
URL: http://llvm.org/viewvc/llvm-project?rev=292867&view=rev
Log:
Merge r292830 - Fix GCC C++03 build by hiding default template argument in C++03
Modified:
libcxx/branches/release_40/include/string
Modified: libcxx/branches/
r292866.
On Mon, Jan 23, 2017 at 5:22 PM, Hans Wennborg wrote:
> Sounds good to me.
>
> On Mon, Jan 23, 2017 at 1:56 PM, Eric Fiselier wrote:
> > This patch should be merge into 4.0 since it is needed to fix compile
> time
> > regressions in when using Clang 3.4 and C++03.
> >
> > See https://
Author: ericwf
Date: Mon Jan 23 19:01:55 2017
New Revision: 292866
URL: http://llvm.org/viewvc/llvm-project?rev=292866&view=rev
Log:
Merge r292833 - Manually force the use of __decltype in C++03 with Clang 3.4.
This merges a version of r292833 since it didn't apply cleanly due to other
upstream c
Author: kcc
Date: Mon Jan 23 18:57:31 2017
New Revision: 292862
URL: http://llvm.org/viewvc/llvm-project?rev=292862&view=rev
Log:
[sanitizer-coverage] emit __sanitizer_cov_trace_pc_guard w/o a preceding 'if'
by default. Update the docs, also add deprecation notes around other parts of
sanitizer
dlj updated this revision to Diff 85493.
dlj added a comment.
- Pull, merge, etc.
https://reviews.llvm.org/D28007
Files:
include/clang/Serialization/ASTReader.h
lib/Serialization/ASTReaderDecl.cpp
utils/TableGen/ClangAttrEmitter.cpp
Index: utils/TableGen/ClangAttrEmitter.cpp
GorNishanov marked 2 inline comments as done.
GorNishanov added a comment.
Looks even better now!
https://reviews.llvm.org/D28835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov updated this revision to Diff 85490.
GorNishanov added a comment.
Feedback implemented!
https://reviews.llvm.org/D28835
Files:
include/clang/AST/StmtCXX.h
include/clang/Sema/ScopeInfo.h
lib/AST/StmtCXX.cpp
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test
GorNishanov updated this revision to Diff 85489.
GorNishanov added a comment.
No changes. Merge with top of the tree (to simplify comparing with the updated
version that is coming up in a second).
https://reviews.llvm.org/D28835
Files:
include/clang/AST/StmtCXX.h
include/clang/Sema/ScopeIn
> Also, I plan to submit this (once it's LGTM'ed) to the 4.0 branch. Is
that OK with you, Richard?
(To be clear, I'll check with Hans before I submit this there, as well.
Just trying to save a round-trip. :) )
On Mon, Jan 23, 2017 at 4:39 PM, George Burgess IV via Phabricator <
revi...@reviews.ll
george.burgess.iv updated this revision to Diff 85486.
george.burgess.iv marked 2 inline comments as done.
george.burgess.iv added a comment.
Addressed all feedback.
Richard noted that, because we're now doing these checks after overload
resolution has occurred, we no longer need to convert argu
hans added a comment.
This sounds like something we'll want to merge to the release branch when it
lands?
https://reviews.llvm.org/D28933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
dcoughlin added a comment.
This is super-exciting work!
Some high-level notes:
- The running-time numbers you report are very high. At a ~20x slowdown, the
benefits from improved solver reasoning will have to be very, very large to
justify the performance cost. It is worth thinking about ways
Ping?
On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote:
> Richard, what do you think?
>
> On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote:
>> I would love to see this merged. It would make it easier to write libc++
>> tests if the tests didn't have to worry about the old 4.0 behavior.
>
Thanks! r292859.
On Mon, Jan 23, 2017 at 3:26 PM, Richard Smith wrote:
> Hans, this should go into Clang 4.
>
> On 23 January 2017 at 15:14, Richard Smith via cfe-commits
> wrote:
>>
>> Author: rsmith
>> Date: Mon Jan 23 17:14:23 2017
>> New Revision: 292847
>>
>> URL: http://llvm.org/viewvc/llv
Sounds good to me.
On Mon, Jan 23, 2017 at 1:56 PM, Eric Fiselier wrote:
> This patch should be merge into 4.0 since it is needed to fix compile time
> regressions in when using Clang 3.4 and C++03.
>
> See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054 for more info.
>
> /Eric
>
> On
Merged in r292858.
Thanks,
Hans
On Mon, Jan 23, 2017 at 4:15 PM, Anna Zaks wrote:
> Yes, ok to merge!
> Thank you.
>
> Sent from my iPhone
>
>> On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote:
>>
>> Sounds good to me.
>>
>> Anna, you're the code owner here. Ok to merge this?
>>
>> Thanks,
>> H
dblaikie updated this revision to Diff 85484.
dblaikie added a comment.
Add bit to the Module record for when modular codegen decls are included in the
MODULAR_CODEGEN_DECLS bitcode record
https://reviews.llvm.org/D28845
Files:
include/clang/AST/ASTContext.h
include/clang/AST/ExternalASTSo
Yes, ok to merge!
Thank you.
Sent from my iPhone
> On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote:
>
> Sounds good to me.
>
> Anna, you're the code owner here. Ok to merge this?
>
> Thanks,
> Hans
>
>> On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev
>> wrote:
>> Hans,
>>
>> Could we m
Thanks for reverting! This was indeed broken.
I've re-committed it with a fix in r292856.
On Fri, Jan 20, 2017 at 12:56 PM, Reid Kleckner via cfe-commits
wrote:
> The first Chrome DLL build with this change is crashing during compilation:
> https://build.chromium.org/p/chromium.fyi/builders/Clan
Author: hans
Date: Mon Jan 23 17:57:50 2017
New Revision: 292856
URL: http://llvm.org/viewvc/llvm-project?rev=292856&view=rev
Log:
Re-commit "Don't inline dllimport functions referencing non-imported methods"
This re-commits r292522 with the addition that it also handles calls
through pointer to
> However I do want a little special behavior for libc++ [...]
I have no problem with this: I just wanted to be sure that we could
reasonably use this feature for things that aren't libcxx. :)
> Libc++ defines some symbols within the global namespace, and we'll need a
way to group those as part o
rsmith added a comment.
Can we instead address this locally in `_Pragma` handling, by getting it to
clear out the junk it inserted into the token stream when it's done (if
backtracking is enabled)?
Repository:
rL LLVM
https://reviews.llvm.org/D28772
__
> I like the idea of tagging diagnose_ifs with tags, though I wonder how
this could be made applicable to code outside of libcxx. Specifically, if I
import some big library that uses diagnose_if, then I'd still need to use
`-Wno-user-defined-warnings` if said lib had a single diagnose_if that I
did
jwakely added a comment.
The __throw_xxx functions are not part of the public libstdc++ API and whatever
Firefox is trying to do with them is not supported by libstdc++ and is
undefined behaviour. Make it stop.
https://reviews.llvm.org/D28981
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292849: Add LF_ prefix to LibFunc enums in
TargetLibraryInfo. (authored by dlj).
Changed prior to commit:
https://reviews.llvm.org/D28477?vs=83674&id=85473#toc
Repository:
rL LLVM
https://reviews.ll
Author: dlj
Date: Mon Jan 23 17:16:58 2017
New Revision: 292849
URL: http://llvm.org/viewvc/llvm-project?rev=292849&view=rev
Log:
Add LF_ prefix to LibFunc enums in TargetLibraryInfo.
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situati
Hans, this should go into Clang 4.
On 23 January 2017 at 15:14, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Mon Jan 23 17:14:23 2017
> New Revision: 292847
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292847&view=rev
> Log:
> PR31692: Don't mark
Author: rsmith
Date: Mon Jan 23 17:14:23 2017
New Revision: 292847
URL: http://llvm.org/viewvc/llvm-project?rev=292847&view=rev
Log:
PR31692: Don't mark a declaration as invalid if we haven't necessarily emitted
a (user-visible) error.
Added:
cfe/trunk/test/SemaCXX/cxx11-default-member-initi
joerg added a comment.
I'm not terribly attached to using __ABICALLS__ for NetBSD, but let me check
back with some of the MIPS folks. I would prefer __mips_abicalls to be always
defined though, independent of the historic behavior.
https://reviews.llvm.org/D29032
___
mclow.lists added a comment.
> It would be nice to have some way of making them semi-compatible.
I'm afraid I disagree. If we make them something that people can "count on",
then we have to support them.
The whole point of names that start with `__` (or `_[A-Z]` are that they are
internal, imp
djasper added a comment.
I am happy to let other people in the community weigh in, but I would not move
forward with this patch. Listing directories is not a task that clang-format
should do. It does not seem useful to me to add this functionality to basically
every single tool that you might w
I like the idea of tagging diagnose_ifs with tags, though I wonder how this
could be made applicable to code outside of libcxx. Specifically, if I
import some big library that uses diagnose_if, then I'd still need to use
`-Wno-user-defined-warnings` if said lib had a single diagnose_if that I
didn'
On Mon, Jan 23, 2017 at 5:29 PM, Aaron Ballman
wrote:
> On Mon, Jan 23, 2017 at 5:00 PM, Nico Weber via cfe-commits
> wrote:
> > On Sun, Jan 22, 2017 at 6:17 AM, Malcolm Parsons <
> malcolm.pars...@gmail.com>
> > wrote:
> >>
> >> On 20 January 2017 at 21:32, Nico Weber wrote:
> >> > This warns
Author: timshen
Date: Mon Jan 23 16:39:35 2017
New Revision: 292839
URL: http://llvm.org/viewvc/llvm-project?rev=292839&view=rev
Log:
[APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble,
IEEEdouble)
Summary:
This patch changes the layout of DoubleAPFloat, and adjust all
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292839: [APFloat] Switch from (PPCDoubleDoubleImpl,
IEEEdouble) layout to (IEEEdouble… (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D27872?vs=85217&id=85457#toc
Repository:
Author: arsenm
Date: Mon Jan 23 16:31:14 2017
New Revision: 292838
URL: http://llvm.org/viewvc/llvm-project?rev=292838&view=rev
Log:
AMDGPU: Update for changed subtarget feature name
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/CodeGenOpenCL/denorms-are-zero.cl
Modified: cfe/
dim added a comment.
In https://reviews.llvm.org/D28981#653908, @mclow.lists wrote:
> > In https://reviews.llvm.org/rL279744, __throw_XXX() functions were
> > introduced, partially for compatibility with software compiled against
> > libstdc++.
>
> You're working from a false premise. These fu
On Mon, Jan 23, 2017 at 5:00 PM, Nico Weber via cfe-commits
wrote:
> On Sun, Jan 22, 2017 at 6:17 AM, Malcolm Parsons
> wrote:
>>
>> On 20 January 2017 at 21:32, Nico Weber wrote:
>> > This warns about code like
>> >
>> > constexpr int foo = 4;
>> > [&foo]() { use(foo); }
>> >
>> > That's co
echristo added a comment.
Hal has given an ack (offline) as well. Go ahead Tim.
https://reviews.llvm.org/D27872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sunil_Srivastava added a comment.
Ping
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I've merged this to the release branch in r292834.
Thanks,
Hans
On Fri, Jan 13, 2017 at 2:14 AM, Benjamin Kramer via cfe-commits
wrote:
> Author: d0k
> Date: Fri Jan 13 04:14:07 2017
> New Revision: 291892
>
> URL: http://llvm.org/viewvc/llvm-project?rev=291892&view=rev
> Log:
> Fix the build of
mclow.lists added a comment.
> In https://reviews.llvm.org/rL279744, __throw_XXX() functions were
> introduced, partially for compatibility with software compiled against
> libstdc++.
You're working from a false premise. These functions were not added for
compatibility with libstdc++, but rat
My dream, and something I would like to work towards is supporting
something like this:
> [[clang::libcxx_diagnose_if(cond, "message", "warning", /* warning-id*/
"non-const-functor")]]
>
> -Wno-libcxx-warnings=non-const-functor
This way libc++ warnings get treated differently from all other users
Ok, go ahead.
On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote:
> This patch needs to get merged into 4.0 since the offending commit with the
> misspelling is in the 4.0 branch.
>
> /Eric
>
>
> On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits
> wrote:
>>
>> Author: marshall
>>
EricWF added a comment.
@dim I would really rather just suppress these warnings if we want them merged
into 4.0.
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
On Sun, Jan 22, 2017 at 6:17 AM, Malcolm Parsons
wrote:
> On 20 January 2017 at 21:32, Nico Weber wrote:
> > This warns about code like
> >
> > constexpr int foo = 4;
> > [&foo]() { use(foo); }
> >
> > That's correct, but removing &foo then makes MSVC complain about this
> code
> > like "err
This patch should be merge into 4.0 since it is needed to fix compile time
regressions in when using Clang 3.4 and C++03.
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054 for more info.
/Eric
On Mon, Jan 23, 2017 at 2:41 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org
This patch needs to get merged into 4.0 since the offending commit with the
misspelling is in the 4.0 branch.
/Eric
On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Jan 23 13:51:54 2017
> New Revision: 292822
>
>
We merged the first one, so I suppose we better fix it :-)
Sounds good to me.
On Mon, Jan 23, 2017 at 1:37 PM, Eric Fiselier wrote:
> This patch should be merge into the 4.0 branch.
>
> It fixes a bug introduced to the 4.0 branch in r292354
> (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=21
Author: ericwf
Date: Mon Jan 23 15:41:13 2017
New Revision: 292833
URL: http://llvm.org/viewvc/llvm-project?rev=292833&view=rev
Log:
Manually force the use of __decltype in C++03 with Clang 3.4.
uses `decltype` in a way incompatible with `__typeof__`.
This is problematic when compiling with Cla
Sounds good to me.
Anna, you're the code owner here. Ok to merge this?
Thanks,
Hans
On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev wrote:
> Hans,
>
> Could we merge this one into the 4.0.0 release branch? It's a recent bugfix
> for the analyzer.
>
> Thanks,
> Artem.
>
>
>
> On 1/23/17 7:57 P
This patch should be merge into the 4.0 branch.
It fixes a bug introduced to the 4.0 branch in r292354 (
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054).
/Eric
On Mon, Jan 23, 2017 at 2:24 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date:
Author: ericwf
Date: Mon Jan 23 15:24:58 2017
New Revision: 292830
URL: http://llvm.org/viewvc/llvm-project?rev=292830&view=rev
Log:
Fix GCC C++03 build by hiding default template argument in C++03
Modified:
libcxx/trunk/include/string
Modified: libcxx/trunk/include/string
URL:
http://llvm.
efriedma added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:4031
// C99 6.5.3.4p4: the type (an unsigned integer type) is size_t.
+ if (isUnevaluatedContext() && ExprKind == UETT_SizeOf &&
+ TInfo->getType()->isVariablyModifiedType())
Is the isUnev
EricWF added a comment.
I think I may have committed these changes as part of another change set.
https://reviews.llvm.org/D26110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weimingz updated this revision to Diff 85446.
weimingz edited the summary of this revision.
weimingz added a comment.
As Eli sugguested, it's better to check it in Sema. In order to access
RelocationModel in Sema, we moved it from CodeGenOpts to LangOpts
https://reviews.llvm.org/D28526
Files:
rjmccall added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:217
+ /// statements.
+ llvm::SmallVector LabelSeenStack;
+
Shouldn't this be maintained by some existing scoping structure like
LexicalScope?
Comment at: lib/CodeGen/
mclow.lists added a comment.
Ok, this is weird. It looks like the changes to <__config> got committed, but
not the test.
https://reviews.llvm.org/D26110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
dim updated this revision to Diff 85440.
dim added a comment.
In https://reviews.llvm.org/D28520#653360, @aaron.ballman wrote:
> In https://reviews.llvm.org/D28520#652607, @dim wrote:
>
> >
>
[...]
>> I'm really open to any variant, as long as something that works can get in
>> before the 4.0
Author: marshall
Date: Mon Jan 23 13:53:28 2017
New Revision: 292823
URL: http://llvm.org/viewvc/llvm-project?rev=292823&view=rev
Log:
Implement LWG#2778: basic_string_view is missing constexpr.
Added:
libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp
Modified:
li
Author: marshall
Date: Mon Jan 23 13:51:54 2017
New Revision: 292822
URL: http://llvm.org/viewvc/llvm-project?rev=292822&view=rev
Log:
Fixed a typo in __config that prevented the aligned new/delete tests from
passing on Mac OS.
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
I don't think it's possible to check this in the way you're doing so here. In
general, there's no way to know whether a constant expression will be part of a
`typedef` declaration or
rsmith added a comment.
Generally looks good, but we have a better way of modeling types with a
trailing variable-length array that you should use.
Comment at: include/clang/AST/StmtCXX.h:299
/// down the coroutine frame.
class CoroutineBodyStmt : public Stmt {
enum SubSt
rsmith added inline comments.
Comment at: include/clang/Sema/Overload.h:758
/// instead.
+/// FIXME: Now that it only alloates ImplicitConversionSequences, do we
want
+/// to un-generalize this?
Typo "alloates"
Comment at: lib/Sem
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:229
+def remark_ssp_applied_reason
+: Remark<"SSP applied to function due to %select{an unknown reason|a "
+ "call to alloca|a stack allocated buffer or struct containing a "
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292819: Guard __gnuc_va_list typedef. (authored by
probinson).
Changed prior to commit:
https://reviews.llvm.org/D28620?vs=84151&id=85430#toc
Repository:
rL LLVM
https://reviews.llvm.org/D28620
Fil
Author: probinson
Date: Mon Jan 23 13:09:21 2017
New Revision: 292819
URL: http://llvm.org/viewvc/llvm-project?rev=292819&view=rev
Log:
Guard __gnuc_va_list typedef.
Differential Revision: http://reviews.llvm.org/D28620
Added:
cfe/trunk/test/Headers/stdarg-gnuc_va_list.c
Modified:
cfe/tr
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This looks fine to me now, might be good to get someone else to ack as well
though.
https://reviews.llvm.org/D27872
___
cfe-commits mailing
arsenm added inline comments.
Comment at: test/SemaOpenCL/logical-ops.cl:1-3
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu
+
arsenm wrote:
> Should this
arsenm added inline comments.
Comment at: test/SemaOpenCL/logical-ops.cl:1-3
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu
+
Should this have a 2.0 run l
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Ok. Thanks Alex, LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D27257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
yaxunl added a comment.
The tests should be added to SemaOpenCL/extension-version.cl
Comment at: lib/Sema/SemaType.cpp:6683
+ // access qualifier unless the cl_khr_3d_image_writes extension is enabled.
+ if (CurType->isOCLImage3dWOType() &&
+ !S.getOpenCLOptions().isEnab
The only plan that we have at the moment is basically for a
-Wno-user-defined-warnings-in-system-headers type of flag. I agree that it
would be nice if we could be more granular than this, so I'll think about
what we can do.
On Mon, Jan 23, 2017 at 8:36 AM, Nico Weber wrote:
> This happens to fi
Hans,
Could we merge this one into the 4.0.0 release branch? It's a recent
bugfix for the analyzer.
Thanks,
Artem.
On 1/23/17 7:57 PM, Artem Dergachev via cfe-commits wrote:
Author: dergachev
Date: Mon Jan 23 10:57:11 2017
New Revision: 292800
URL: http://llvm.org/viewvc/llvm-project?rev=2
On 22 January 2017 at 07:57, Kim Gräsman wrote:
> Hi Richard,
>
> On Fri, Jan 20, 2017 at 1:58 AM, Richard Smith via cfe-commits
> wrote:
> >
> > +String builtins
> > +---
> > +
> > +Clang provides constant expression evaluation support for builtins
> forms of
> > +the following func
Author: rsmith
Date: Mon Jan 23 12:17:46 2017
New Revision: 292811
URL: http://llvm.org/viewvc/llvm-project?rev=292811&view=rev
Log:
Fix documentation typo from r292558.
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
http://llvm.org/view
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:723
+? CGM.getNSConcreteStackBlock()
+: llvm::Constant::getNullValue(
+ CGM.getNSConcreteStackBlock()->getType());
-
Sounds good to me.
On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier wrote:
> We should merge this patch into the 4.0 release branch. It is needed to make
> "check-all" pass when using GCC 4, 5 and 6.
>
> /Eric
>
> On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits
> wrote:
>>
>> Autho
1 - 100 of 164 matches
Mail list logo
