djasper added a comment.

I am happy to let other people in the community weigh in, but I would not move 
forward with this patch. Listing directories is not a task that clang-format 
should do. It does not seem useful to me to add this functionality to basically 
every single tool that you might want to pipe files through. That would mean 
that you'd have to repeat the same code many times. Also, I would not call this 
"bash magic", these are more like "bash basics". I don't know how much harder 
this is on windows, but still solving that doesn't sound like something 
clang-format should fix.

The other point I'd like to make is that it rarely makes sense to format an 
entire directory structure with clang-format. It is actually much more useful 
if integrated into editors (plugins available) or the version control system 
(e.g. through git-clang-format). That's also why you see many diffs here, we 
don't reformat all of clang-format on every commit, just the changed lines. The 
rest might go sightly out of sync with clang-format's formatting, but that's 
ok, no harm done. Often this is preferable over lots of spurious diffs as 
present here.


Repository:
  rL LLVM

https://reviews.llvm.org/D29039



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to