> Also, I plan to submit this (once it's LGTM'ed) to the 4.0 branch. Is that OK with you, Richard?
(To be clear, I'll check with Hans before I submit this there, as well. Just trying to save a round-trip. :) ) On Mon, Jan 23, 2017 at 4:39 PM, George Burgess IV via Phabricator < revi...@reviews.llvm.org> wrote: > george.burgess.iv updated this revision to Diff 85486. > george.burgess.iv marked 2 inline comments as done. > george.burgess.iv added a comment. > > Addressed all feedback. > > Richard noted that, because we're now doing these checks after overload > resolution has occurred, we no longer need to convert arguments for > arg-dependent diagnose_if checks. As a result, we get to make lots of > things `const`. Yay! > > Also, I plan to submit this (once it's LGTM'ed) to the 4.0 branch. Is that > OK with you, Richard? > > > https://reviews.llvm.org/D28889 > > Files: > include/clang/Sema/Overload.h > include/clang/Sema/Sema.h > lib/Sema/SemaChecking.cpp > lib/Sema/SemaExpr.cpp > lib/Sema/SemaExprCXX.cpp > lib/Sema/SemaLookup.cpp > lib/Sema/SemaOverload.cpp > test/Sema/diagnose_if.c > test/SemaCXX/diagnose_if.cpp > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
