Sounds good to me.
On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier <e...@efcs.ca> wrote: > We should merge this patch into the 4.0 release branch. It is needed to make > "check-all" pass when using GCC 4, 5 and 6. > > /Eric > > On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: ericwf >> Date: Fri Jan 20 06:54:45 2017 >> New Revision: 292607 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=292607&view=rev >> Log: >> Don't default older GCC's to C++17, but C++14 or C++11 instead >> >> Modified: >> libcxx/trunk/test/libcxx/test/config.py >> >> Modified: libcxx/trunk/test/libcxx/test/config.py >> URL: >> http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/test/config.py?rev=292607&r1=292606&r2=292607&view=diff >> >> ============================================================================== >> --- libcxx/trunk/test/libcxx/test/config.py (original) >> +++ libcxx/trunk/test/libcxx/test/config.py Fri Jan 20 06:54:45 2017 >> @@ -423,6 +423,15 @@ class Configuration(object): >> if not std: >> # Choose the newest possible language dialect if none is >> given. >> possible_stds = ['c++1z', 'c++14', 'c++11', 'c++03'] >> + if self.cxx.type == 'gcc': >> + maj_v, _, _ = self.cxx.version >> + maj_v = int(maj_v) >> + if maj_v < 7: >> + possible_stds.remove('c++1z') >> + # FIXME: How many C++14 tests actually fail under GCC 5 >> and 6? >> + # Should we XFAIL them individually instead? >> + if maj_v <= 6: >> + possible_stds.remove('c++14') >> for s in possible_stds: >> if self.cxx.hasCompileFlag('-std=%s' % s): >> std = s >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits