Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

Hahnfeld updated the summary for this revision. Hahnfeld updated this revision to Diff 49459. Hahnfeld added a comment. Rename option to `-stdlib=platform` http://reviews.llvm.org/D17286 Files: lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h test/Driver/freebs

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio updated this revision to Diff 49456. ariccio added a comment. Nit addressed. http://reviews.llvm.org/D17688 Files: llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp Index: llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

r262311 - Test template instantiation of ns_consumed and ns_returns_retained.

Author: rjmccall Date: Tue Mar 1 00:54:30 2016 New Revision: 262311 URL: http://llvm.org/viewvc/llvm-project?rev=262311&view=rev Log: Test template instantiation of ns_consumed and ns_returns_retained. Modified: cfe/trunk/test/SemaObjCXX/arc-templates.mm Modified: cfe/trunk/test/SemaObjCXX/

[PATCH] D17752: [MSVC Compat] Correctly handle finallys nested within finallys

majnemer created this revision. majnemer added reviewers: rnk, andrew.w.kaylor. majnemer added a subscriber: cfe-commits. We'd lose track of the parent CodeGenFunction, leading us to get confused with regard to which function a nested finally belonged to. http://reviews.llvm.org/D17752 Files:

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

not_ubsan was added a long time ago, I presume it is still needed due to recursion in sema as well. not_asan was added recently to 2 tests after r260760. I tentatively removed it from 'index-many-call-ops.cpp’ and if all looks good I’ll remove from the other as well. > On Feb 29, 2016, at 9:57

r262308 - Better comments for ExtParameterInfo.

Author: rjmccall Date: Tue Mar 1 00:27:40 2016 New Revision: 262308 URL: http://llvm.org/viewvc/llvm-project?rev=262308&view=rev Log: Better comments for ExtParameterInfo. Modified: cfe/trunk/include/clang/AST/Type.h cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

If the test shouldn't require large stack usage, should the not_ubsan, not_asan tags be removed? On Mon, Feb 29, 2016 at 9:55 PM, Justin Lebar wrote: > Works! Thank you for fixing this, and so quickly. > > On Mon, Feb 29, 2016 at 6:51 PM, Argyrios Kyrtzidis wrote: >> Try with r262290. >> >>> On

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Works! Thank you for fixing this, and so quickly. On Mon, Feb 29, 2016 at 6:51 PM, Argyrios Kyrtzidis wrote: > Try with r262290. > >> On Feb 29, 2016, at 6:23 PM, Argyrios Kyrtzidis wrote: >> >> Ah, I see the problem in the code, will fix shortly. >> >>> On Feb 29, 2016, at 5:43 PM, Justin Leba

[PATCH] [libclang/python] Add bindings for children of diagnostics

This exposes the Clang API bindings `clang_getChildDiagnostics` (which returns a `CXDiagnosticSet`) and `clang_getNumDiagnosticsInSet` / `clang_getDiagnosticInSet` (to traverse the `CXDiagnosticSet`), and adds a helper `children` property in the Python `Diagnostic` wrapper. Also, this adds the mis

r262295 - [test] After r262290 reducing stack usage, try re-enabling asan on the related test.

Author: akirtzidis Date: Mon Feb 29 22:40:20 2016 New Revision: 262295 URL: http://llvm.org/viewvc/llvm-project?rev=262295&view=rev Log: [test] After r262290 reducing stack usage, try re-enabling asan on the related test. Modified: cfe/trunk/test/Index/index-many-call-ops.cpp Modified: cfe/

Re: r262290 - [index] Fix issue where data visitation was disabled with C++ operator call expressions, during indexing.

On Mon, Feb 29, 2016 at 8:34 PM, Argyrios Kyrtzidis wrote: > This is to reduce stack usage, whether it hits stack overflow or not is > highly dependent on configuration. > I've tried forcing smaller stack on the specific test > (test/Index/index-many-call-ops.cpp) but then it can hit stack overfl

Re: r262290 - [index] Fix issue where data visitation was disabled with C++ operator call expressions, during indexing.

This is to reduce stack usage, whether it hits stack overflow or not is highly dependent on configuration. I've tried forcing smaller stack on the specific test (test/Index/index-many-call-ops.cpp) but then it can hit stack overflow in sema; I don’t have a good way to test this. I believe asan w

r262293 - clang-format: Correctly apply wrap before multi-line RHS rule to

Author: djasper Date: Mon Feb 29 22:19:59 2016 New Revision: 262293 URL: http://llvm.org/viewvc/llvm-project?rev=262293&view=rev Log: clang-format: Correctly apply wrap before multi-line RHS rule to ternary expressions. Before: return a ? a :

r262291 - clang-format: [JS] Support quoted object literal keys.

Author: djasper Date: Mon Feb 29 22:19:47 2016 New Revision: 262291 URL: http://llvm.org/viewvc/llvm-project?rev=262291&view=rev Log: clang-format: [JS] Support quoted object literal keys. Before: var x = { a: a, b: b, 'c': c, }; After: var x = { a: a, b: b, 'c': c, }

r262292 - clang-format: Increase the penalty for breaking between array subscripts.

Author: djasper Date: Mon Feb 29 22:19:55 2016 New Revision: 262292 URL: http://llvm.org/viewvc/llvm-project?rev=262292&view=rev Log: clang-format: Increase the penalty for breaking between array subscripts. Before: aa[aaa]

Re: r262290 - [index] Fix issue where data visitation was disabled with C++ operator call expressions, during indexing.

Does this change any behavior? (missing test case?) On Mon, Feb 29, 2016 at 6:46 PM, Argyrios Kyrtzidis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: akirtzidis > Date: Mon Feb 29 20:46:32 2016 > New Revision: 262290 > > URL: http://llvm.org/viewvc/llvm-project?rev=262290&view=re

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Try with r262290. > On Feb 29, 2016, at 6:23 PM, Argyrios Kyrtzidis wrote: > > Ah, I see the problem in the code, will fix shortly. > >> On Feb 29, 2016, at 5:43 PM, Justin Lebar wrote: >> >>> How are you configuring >> >> cmake -G "Ninja" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang

r262290 - [index] Fix issue where data visitation was disabled with C++ operator call expressions, during indexing.

Author: akirtzidis Date: Mon Feb 29 20:46:32 2016 New Revision: 262290 URL: http://llvm.org/viewvc/llvm-project?rev=262290&view=rev Log: [index] Fix issue where data visitation was disabled with C++ operator call expressions, during indexing. Modified: cfe/trunk/lib/Index/IndexBody.cpp Modi

Re: [PATCH] D17737: [PGO] change profile use cc1 option

silvas added a comment. Some comments but otherwise feel free to commit. Comment at: lib/CodeGen/CodeGenModule.cpp:154 @@ +153,3 @@ +assert(!CodeGenOpts.ProfileInstrumentUsePath.empty() && + "Need to explicitly specify the profile name."); +auto ReaderOrErr = l

Re: r262275 - Infrastructure improvements to Clang attribute TableGen.

All green on the two latest commits. Thanks! http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/961 -- Sean Silva On Mon, Feb 29, 2016 at 6:14 PM, John McCall wrote: > On Feb 29, 2016, at 5:44 PM, Sean Silva wrote: > This seems to be causing a substantial

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

thakis added a comment. In http://reviews.llvm.org/D17741#364931, @weimingz wrote: > In http://reviews.llvm.org/D17741#364756, @thakis wrote: > > > Instead of doing this, would it make sense to have a flag like > > -ffile-basename that changes what __FILE__ expands to? > > > > I had wished I'd b

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Ah, I see the problem in the code, will fix shortly. > On Feb 29, 2016, at 5:43 PM, Justin Lebar wrote: > >> How are you configuring > > cmake -G "Ninja" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang > -DCMAKE_CXX_COMPILER=clang++ -DLLVM_ENABLE_ASSERTIONS=On > -DLLVM_ENABLE_SPHINX=true -D

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz updated this revision to Diff 49445. weimingz added a comment. rename the macro to CLANG_FILE_BASENAME per Ben's comments. http://reviews.llvm.org/D17741 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPMacroExpansion.cpp test/Lexer/file_basename.c Index: test/Lexer/file_basena

Re: [PATCH] D17737: [PGO] change profile use cc1 option

xur updated this revision to Diff 49444. xur marked 2 inline comments as done. xur added a comment. Integrated Sean's review suggestions. -Rong http://reviews.llvm.org/D17737 Files: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.d

Re: r262275 - Infrastructure improvements to Clang attribute TableGen.

> On Feb 29, 2016, at 5:44 PM, Sean Silva wrote: > This seems to be causing a substantial amount of warning spew from MSVC: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/955 > >

r262289 - Fix the template instantiation of ExtParameterInfos; tests to follow.

Author: rjmccall Date: Mon Feb 29 20:09:25 2016 New Revision: 262289 URL: http://llvm.org/viewvc/llvm-project?rev=262289&view=rev Log: Fix the template instantiation of ExtParameterInfos; tests to follow. Modified: cfe/trunk/include/clang/AST/Type.h cfe/trunk/include/clang/Sema/Sema.h

r262288 - Add an llvm_unreachable back to the autogeneration of this covered switch.

Author: rjmccall Date: Mon Feb 29 20:09:20 2016 New Revision: 262288 URL: http://llvm.org/viewvc/llvm-project?rev=262288&view=rev Log: Add an llvm_unreachable back to the autogeneration of this covered switch. Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Modified: cfe/trunk/utils/

Re: [PATCH] D17737: [PGO] change profile use cc1 option

silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land. Thanks! http://reviews.llvm.org/D17737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz added a comment. In http://reviews.llvm.org/D17741#364756, @thakis wrote: > Instead of doing this, would it make sense to have a flag like > -ffile-basename that changes what __FILE__ expands to? > > I had wished I'd be able to have some control over __FILE__ (I'd like to say > "make a

Re: [PATCH] D17737: [PGO] change profile use cc1 option

xur marked 4 inline comments as done. Comment at: lib/Frontend/CompilerInvocation.cpp:378 @@ -377,1 +377,3 @@ +enum PGOInstrumentor { ProfileUnknown, ProfileNone, ProfileClang, ProfileLLVM }; +static PGOInstrumentor getPGOInstrumentor(StringRef S) { silvas wrot

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz added a comment. In http://reviews.llvm.org/D17741#364742, @bcraig wrote: > Note: this doesn't count as an official "LGTM". > > The code change seems fine to me. I think this has been implemented in gcc > as well, but I don't recall for certain. If this has been implemented in > gcc,

Re: [PATCH] D17581: [CUDA] disable attribute-based overloading for __global__ functions.

jlebar closed this revision. jlebar added a comment. Landed in http://reviews.llvm.org/rL261778. http://reviews.llvm.org/D17581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r262275 - Infrastructure improvements to Clang attribute TableGen.

This seems to be causing a substantial amount of warning spew from MSVC: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/955 I think our recommended "portable" method of using llvm_unreachable is outside the switch, instead of in the default case: http://l

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

> How are you configuring cmake -G "Ninja" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_ENABLE_SPHINX=true -DSPHINX_OUTPUT_MAN=true ../llvm > and what compiler and version are you using ? $ clang --version Ubuntu clang versi

[PATCH] D17746: Fix PR26741 -- __builtin_object_size is not consistently conservative with C++ inheritance

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. This patch fixes PR26741, and makes us handle inheritance more sanely. Broken code: ``` struct Foo { char a[1]; }; struct Bar : Foo {}; int break() { Bar *b;

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

I don’t quite understand how it gets that stack trace, dataTraverseNode() was introduced to avoid exactly this. How are you configuring and what compiler and version are you using ? > On Feb 29, 2016, at 3:14 PM, Justin Lebar wrote: > >> Is this still an issue after r260785 ? > > I just sync'e

Re: [PATCH] D17390: Introduce -fembed-bitcode driver option

steven_wu added a comment. Thanks for reviewing the patch. There is a problem in the test case (it only works on darwin). It is fixed in r262286. Comment at: lib/Driver/Driver.cpp:1761 @@ -1747,1 +1760,3 @@ +const ActionList *BackendInputs = + (EmbedBitcode ? Inputs :

r262286 - Fix the testcase in r262282

Author: steven_wu Date: Mon Feb 29 19:24:54 2016 New Revision: 262286 URL: http://llvm.org/viewvc/llvm-project?rev=262286&view=rev Log: Fix the testcase in r262282 -bitcode_bundle is only passed to the darwin ld64 linker and it is only implemented there. Remove the check on the linker flag. Modi

r262285 - Make test more robust.

Author: silvas Date: Mon Feb 29 19:20:15 2016 New Revision: 262285 URL: http://llvm.org/viewvc/llvm-project?rev=262285&view=rev Log: Make test more robust. Really all these tests are checking is that we find a file path. The behavior when we don't find one will have `"ps4-ld"` in it. We just need

Re: r262278 - Generalize the consumed-parameter array on FunctionProtoType

> On Feb 29, 2016, at 5:06 PM, Pariborz Jahanian wrote: >> On Feb 29, 2016, at 4:49 PM, John McCall via cfe-commits >> wrote: >> >> Author: rjmccall >> Date: Mon Feb 29 18:49:02 2016 >> New Revision: 262278 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=262278&view=rev >> Log: >> Generaliz

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 02/29/2016 10:13 AM, Michael Matz via cfe-commits wrote: Also this insistence that all of "trivially copyable" is already quite nicely specified in the C++ ABI is still not really relevant because C++ _is not the only language out there_. I'm not sure how often I have to repeat this until peo

Re: [PATCH] D17390: Introduce -fembed-bitcode driver option

This revision was automatically updated to reflect the committed changes. Closed by commit rL262282: Introduce -fembed-bitcode driver option (authored by steven_wu). Changed prior to commit: http://reviews.llvm.org/D17390?vs=49431&id=49437#toc Repository: rL LLVM http://reviews.llvm.org/D17

RE: r250293 - Bring back r250262: PS4 toolchain

Nico asks: +def warn_drv_ps4_force_pic : Warning< + "option '%0' was ignored by the PS4 toolchain, using '-fPIC'">, + InGroup; Should this use the existing UnusedCommandLineArgument instead of introducing a new group? Depends on what kinds of distinctions you want to make, when it comes to h

r262282 - Introduce -fembed-bitcode driver option

Author: steven_wu Date: Mon Feb 29 19:07:58 2016 New Revision: 262282 URL: http://llvm.org/viewvc/llvm-project?rev=262282&view=rev Log: Introduce -fembed-bitcode driver option Summary: This is the clang driver part of the change to embedded bitcode. This includes: 1. -fembed-bitcode option which

Re: r262278 - Generalize the consumed-parameter array on FunctionProtoType

> On Feb 29, 2016, at 4:49 PM, John McCall via cfe-commits > wrote: > > Author: rjmccall > Date: Mon Feb 29 18:49:02 2016 > New Revision: 262278 > > URL: http://llvm.org/viewvc/llvm-project?rev=262278&view=rev > Log: > Generalize the consumed-parameter array on FunctionProtoType > to allow arb

r262278 - Generalize the consumed-parameter array on FunctionProtoType

Author: rjmccall Date: Mon Feb 29 18:49:02 2016 New Revision: 262278 URL: http://llvm.org/viewvc/llvm-project?rev=262278&view=rev Log: Generalize the consumed-parameter array on FunctionProtoType to allow arbitrary data to be associated with a parameter. Also, fix a bug where we apparently haven'

r262277 - [analyzer] Update CheckObjCDealloc diagnostic for missing -dealloc.

Author: dcoughlin Date: Mon Feb 29 18:39:04 2016 New Revision: 262277 URL: http://llvm.org/viewvc/llvm-project?rev=262277&view=rev Log: [analyzer] Update CheckObjCDealloc diagnostic for missing -dealloc. Update the diagnostic for classes missing -dealloc to mention an instance variable that needs

Re: [PATCH] D17390: Introduce -fembed-bitcode driver option

thakis accepted this revision. thakis added a reviewer: thakis. thakis added a comment. This revision is now accepted and ready to land. Thanks, that's much clearer :-) http://reviews.llvm.org/D17390 ___ cfe-commits mailing list cfe-commits@lists.ll

r262275 - Infrastructure improvements to Clang attribute TableGen.

Author: rjmccall Date: Mon Feb 29 18:18:05 2016 New Revision: 262275 URL: http://llvm.org/viewvc/llvm-project?rev=262275&view=rev Log: Infrastructure improvements to Clang attribute TableGen. This should make it easier to add new Attr subclasses. Modified: cfe/trunk/include/clang/AST/Attr.h

r262272 - [analyzer] Teach CheckObjCDealloc about Block_release().

Author: dcoughlin Date: Mon Feb 29 17:57:10 2016 New Revision: 262272 URL: http://llvm.org/viewvc/llvm-project?rev=262272&view=rev Log: [analyzer] Teach CheckObjCDealloc about Block_release(). It now treats Block_release(b) as a release in addition to [b release]. Modified: cfe/trunk/lib/Sta

Re: [PATCH] D17737: [PGO] change profile use cc1 option

silvas added a comment. Thanks, this is looking good. I have some naming suggestions and nits, but the overall content of the patch LGTM. Comment at: include/clang/Driver/CC1Options.td:286 @@ +285,3 @@ +def fprofile_instrument_usepath_EQ : +Joined<["-"], "fprofile-instrumen

Re: [PATCH] D17390: Introduce -fembed-bitcode driver option

steven_wu updated this revision to Diff 49431. steven_wu added a comment. Make selectToolForJob logic better and less disruptive for -fembed-bitcode. When -fembed-bitcode is used, the same old logic is used to decide if CompileJob and BackendJob can be combined with an extra requirement for -femb

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

joerg added a subscriber: joerg. joerg added a comment. I've added functionality like that to NetBSD's GCC a long time ago. That functionality is useful for a variety of situations, cutting down file space or canonicalization are two uses.

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

> Is this still an issue after r260785 ? I just sync'ed to r262268 and was able to reproduce the segfault. > Could you provide a stack trace ? $ gdb --args release/bin/c-index-test -index-file /usr/local/google/home/jlebar/code/llvm/src/tools/clang/test/Index/index-many-call-ops.cpp (gdb) run Pr

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

thakis added a subscriber: thakis. thakis added a comment. Instead of doing this, would it make sense to have a flag like -ffile-basename that changes what __FILE__ expands to? I had wished I'd be able to have some control over __FILE__ (I'd like to say "make all __FILE__s relative to this give

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Is this still an issue after r260785 ? Could you provide a stack trace ? > On Feb 29, 2016, at 2:27 PM, Justin Lebar wrote: > > Hi, I think this broke clang/test/Index/index-many-call-ops.cpp. I > get a segfault due to recursive stack overflow in release builds on my > linux x86-64 box when run

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

bcraig added a subscriber: bcraig. bcraig added a comment. Note: this doesn't count as an official "LGTM". The code change seems fine to me. I think this has been implemented in gcc as well, but I don't recall for certain. If this has been implemented in gcc, then I would expect the semantics

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

zaks.anna added a comment. Nit: Could you change the prefix from "win" to "win_"? http://reviews.llvm.org/D17688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Hi, I think this broke clang/test/Index/index-many-call-ops.cpp. I get a segfault due to recursive stack overflow in release builds on my linux x86-64 box when running that test -- it seems the purpose of that test is to check that we *don't* segfault. This has been broken for a while, and people

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz created this revision. weimingz added a subscriber: cfe-commits. __FILE__ will be expanded to the full path. In some embedded system scenarios, the final images is linked from many objs and the image size is a very important factor. The full filenames can occupy a lot space in the strin

[PATCH] D17737: [PGO] change profile use cc1 option

xur created this revision. xur added reviewers: davidxl, silvas, bogner. xur added subscribers: davidxl, xur, cfe-commits. This patch takes the suggestion by Sean Silva in https://reviews.llvm.org/D17622 to decouple cc1 option from driver level option. -fprofile-instr-use={} is now a driver only

[PATCH] D17735: [libcxxabi] PR26778 Fix tests when CXX="ccache clang++"

hintonda created this revision. hintonda added a reviewer: mclow.lists. hintonda added a subscriber: cfe-commits. If you use ccache to build libcxxabi by setting CXX="ccache clang++", check-libcxxabi will fail since LIBCXXABI_COMPILER will be set to "ccache". We can't just include CMAKE_CXX_COMPI

r262261 - [analyzer] Don't treat calls to system headers as escaping in CheckObjCDealloc.

Author: dcoughlin Date: Mon Feb 29 15:44:08 2016 New Revision: 262261 URL: http://llvm.org/viewvc/llvm-project?rev=262261&view=rev Log: [analyzer] Don't treat calls to system headers as escaping in CheckObjCDealloc. This prevents false negatives when a -dealloc method, for example, removes itsel

[PATCH] D17734: [libcxx] PR26777 Fix tests when built with CXX="ccache clang++"

hintonda created this revision. hintonda added a reviewer: mclow.lists. hintonda added a subscriber: cfe-commits. If you use ccache to build libcxx by setting CXX="ccache clang++", check-libcxx will fail since LIBCXX_COMPILER will be set to "ccache". We can't just include CMAKE_CXX_COMPILER_ARG1

[clang-tools-extra] r262257 - IdentifierNamingCheck.cpp: try to fix MSVC build

Author: hans Date: Mon Feb 29 15:17:39 2016 New Revision: 262257 URL: http://llvm.org/viewvc/llvm-project?rev=262257&view=rev Log: IdentifierNamingCheck.cpp: try to fix MSVC build It was failing to build with: clang-tidy\readability\IdentifierNamingCheck.cpp(640): error C2882: 'format' : illegal

Re: r261774 - Bail on compilation as soon as a job fails.

I think the reason this becomes tricky is that you can reuse Action nodes for multiple invocations of cc1 (or your favorite tool). We do this on macos with bindarch for universal binaries. So you can't necessarily point to one CompilationAction node and say "*that* failed with an error", with no

Re: [PATCH] D17695: clang-cl: Implement initial limited support for precompiled headers.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Very nice! I only have some style nits, really. Look forward to using this :-) Comment at: include/clang/Basic/DiagnosticDriverKinds.td:112 @@ +111,3 @@ +def warn_drv_yc_multiple

Re: r261774 - Bail on compilation as soon as a job fails.

On Mon, Feb 29, 2016 at 11:19 AM, Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Can you expand on this? The idea is that those implicit deps are in > addition to regular dependencies, not a replacement. > > Sure. > > What I was trying to say is, suppose you have two CUDA de

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

Hahnfeld added a comment. In http://reviews.llvm.org/D17286#364544, @joerg wrote: > I was thinking about something like `-stdlib=platform` to reflect that it is > the target choice. Ah yes, that was the term I was missing, `architecture` wasn't actually correct http://reviews.llvm.org/D17286

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

joerg added a comment. I was thinking about something like `-stdlib=platform` to reflect that it is the target choice. http://reviews.llvm.org/D17286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D17390: Introduce -fembed-bitcode driver option

thakis added a subscriber: thakis. thakis added a comment. I don't understand the changes to Driver.cpp lines 1760 and down. The rest looks good to me. Comment at: lib/Driver/Driver.cpp:1761 @@ -1747,1 +1760,3 @@ +const ActionList *BackendInputs = + (EmbedBitcode ? Inp

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

Hahnfeld added a comment. In http://reviews.llvm.org/D17286#364353, @joerg wrote: > I dislike the value `default`, since with `CLANG_DEFAULT_CXX_STDLIB` it is > not. Otherwise, it should be fine. Hmm, had this feeling as well... What about `-stdlib=test` as I only plan to use this for the tes

Re: r261774 - Bail on compilation as soon as a job fails.

> Can you expand on this? The idea is that those implicit deps are in addition > to regular dependencies, not a replacement. Sure. What I was trying to say is, suppose you have two CUDA device compilations. You want device compilation B to bail if device compilation A fails. So what are the im

[PATCH] D17727: Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.

ioeric created this revision. ioeric added a reviewer: klimek. ioeric added subscribers: klimek, cfe-commits. Merge branch 'master' of http://llvm.org/git/clang Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency. http://reviews.llvm.org/D17727 Files: include/clang/Fo

Re: Embedded Bitcode in Object Files

Ping. I don't know who is the best review for the patches. Thanks for Rafael looking at the LLVM change. Richard, do you have any opinions on the clang changes? Thanks Steven > On Feb 18, 2016, at 9:57 AM, Steven Wu wrote: > > Hi all > > I put up some patches for embedding bitcode inside th

RE: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

Hi Dmitri, Could you please let us know your opinion about C++ vs C-style doxygen comments. Read this thread for ‘pro’ and ‘con’ arguments about using C++ headers. Will LLVM online documentation look proper if we decide to use C-style headers? Which style do you personally prefer to see? Note,

r262239 - [PGO] clang cc1 option change to enable IR level instrumentation

Author: xur Date: Mon Feb 29 12:54:59 2016 New Revision: 262239 URL: http://llvm.org/viewvc/llvm-project?rev=262239&view=rev Log: [PGO] clang cc1 option change to enable IR level instrumentation This patch expands cc1 option -fprofile-instrument= with a new value: -fprofile-instrument=llvm which

Re: [PATCH] D17622: [PGO] clang cc1 option change to enable IR level instrumenation

This revision was automatically updated to reflect the committed changes. Closed by commit rL262239: [PGO] clang cc1 option change to enable IR level instrumentation (authored by xur). Changed prior to commit: http://reviews.llvm.org/D17622?vs=49243&id=49394#toc Repository: rL LLVM http://r

Re: r261774 - Bail on compilation as soon as a job fails.

On Sun, Feb 28, 2016 at 3:40 PM, Justin Lebar wrote: > On Sun, Feb 28, 2016 at 1:46 PM, Nico Weber wrote: > > Do you think something like the implicit inputs thing in > > http://reviews.llvm.org/D17695 could work for you as well, instead of > this > > patch? > > Having read just the patch descri

Re: [PATCH] D16396: Warn if variable cannot be implicitly instantiated

Any feedback? Thanks, --Serge 2016-01-21 14:33 GMT+06:00 Serge Pavlov : > sepavloff created this revision. > sepavloff added a reviewer: rsmith. > sepavloff added subscribers: cfe-commits, silvas. > > Instantiation of static class members may be a source of user > misunderstanding, > especially

Re: [PATCH] D16396: Warn if variable cannot be implicitly instantiated

sepavloff added a subscriber: sepavloff. sepavloff added a comment. Any feedback? Thanks, --Serge http://reviews.llvm.org/D16396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

joerg added a comment. I dislike the value `default`, since with `CLANG_DEFAULT_CXX_STDLIB` it is not. Otherwise, it should be fine. http://reviews.llvm.org/D17286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: r262232 - Implement new interfaces for code-formatting when applying replacements.

On Mon, Feb 29, 2016 at 5:39 PM Chandler Carruth wrote: > On Mon, Feb 29, 2016 at 11:32 AM Manuel Klimek via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: klimek >> Date: Mon Feb 29 10:27:41 2016 >> New Revision: 262232 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=262232&v

r262234 - Revert "Implement new interfaces for code-formatting when applying replacements."

Author: klimek Date: Mon Feb 29 10:44:16 2016 New Revision: 262234 URL: http://llvm.org/viewvc/llvm-project?rev=262234&view=rev Log: Revert "Implement new interfaces for code-formatting when applying replacements." This reverts commit r262232. Modified: cfe/trunk/include/clang/Tooling/Core/

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

dim added subscribers: joerg, dim. dim added a comment. LGTM, at least. @emaste, @joerg, OK with you too? http://reviews.llvm.org/D17286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

klimek closed this revision. klimek added a comment. Submitted as r262232 http://reviews.llvm.org/D17704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r262232 - Implement new interfaces for code-formatting when applying replacements.

On Mon, Feb 29, 2016 at 11:32 AM Manuel Klimek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: klimek > Date: Mon Feb 29 10:27:41 2016 > New Revision: 262232 > > URL: http://llvm.org/viewvc/llvm-project?rev=262232&view=rev > Log: > Implement new interfaces for code-formatting when a

r262232 - Implement new interfaces for code-formatting when applying replacements.

Author: klimek Date: Mon Feb 29 10:27:41 2016 New Revision: 262232 URL: http://llvm.org/viewvc/llvm-project?rev=262232&view=rev Log: Implement new interfaces for code-formatting when applying replacements. Patch by Eric Liu. Modified: cfe/trunk/include/clang/Tooling/Core/Replacement.h cf

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

Hi, On Fri, 26 Feb 2016, H.J. Lu wrote: > >> It is clear to me now. Let's go with > >> > >> --- > >> An empty type is a type where it and all of its subobjects (recursively) > >> are of class, structure, union, or array type. No memory slot nor > >> register should be used to pass or return an

Re: [PATCH] D17645: AMDGPU: Add missing Volcanic Islands targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL262228: AMDGPU: Add missing Volcanic Islands targets (authored by tstellar). Changed prior to commit: http://reviews.llvm.org/D17645?vs=49184&id=49372#toc Repository: rL LLVM http://reviews.llvm.org

r262228 - AMDGPU: Add missing Volcanic Islands targets

Author: tstellar Date: Mon Feb 29 09:08:56 2016 New Revision: 262228 URL: http://llvm.org/viewvc/llvm-project?rev=262228&view=rev Log: AMDGPU: Add missing Volcanic Islands targets Reviewers: arsenm Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D17645 Modified: cfe

Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

ioeric updated this revision to Diff 49359. ioeric marked an inline comment as done. ioeric added a comment. - return Replacements() instead of the empty Replaces. http://reviews.llvm.org/D17704 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Too

Re: [PATCH] D17637: [PPC64][VSX] Add short, char, and bool data type for vec_vsx_ld and vec_vsx_st intrinsics

cycheng updated this revision to Diff 49335. cycheng added a comment. Fix clang testing failure. Thanks Kit! I have checked the result by: make check-all Testing result: Testing Time: 33.36s Expected Passes: 24505 Expected Failures : 152 Unsupported Tests : 365 [100%] Built

[RecursiveASTVisitor] fix skipping template specialization definition details

As described in [1] RecursiveASTVisitor skips definition of class template specializations. This patch fixes it in the same way as is done for partial specializations. 1. https://llvm.org/bugs/show_bug.cgi?id=12640 Index: include/clang/AST/RecursiveASTVisitor.h

Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

ioeric updated this revision to Diff 49355. ioeric marked 8 inline comments as done. ioeric added a comment. - removed applyAllReplacementsAndFormat with Rewritter interface. reduced the column limit in test case; some formatting. http://reviews.llvm.org/D17704 Files: include/clang/Tooling/C

[PATCH] D17704: Added interfaces for code-formatting while applying replacements.

ioeric created this revision. ioeric added a reviewer: klimek. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. Merge branch 'master' of http://llvm.org/git/clang http://reviews.llvm.org/D17704 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replace

r262216 - clang-format: Don't format unrelated nested blocks.

Author: djasper Date: Mon Feb 29 06:26:20 2016 New Revision: 262216 URL: http://llvm.org/viewvc/llvm-project?rev=262216&view=rev Log: clang-format: Don't format unrelated nested blocks. With this change: SomeFunction( [] { int i; return i; // Format this line. },

Re: r262200 - [X86] Enabling xsave should not enable AVX. I seem to have done this, but I don't know why.

On Mon, Feb 29, 2016 at 06:51:34AM -, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Mon Feb 29 00:51:34 2016 > New Revision: 262200 > > URL: http://llvm.org/viewvc/llvm-project?rev=262200&view=rev > Log: > [X86] Enabling xsave should not enable AVX. I seem to have done this, bu

Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: lib/Tooling/Core/Replacement.cpp:290 @@ +289,3 @@ + const format::FormatStyle &Style) { + if (Replaces.empty()) return

[PATCH] D17709: [MSVC Compat] Support for '__unaligned' attribute in function declaration

olga.a.chupina created this revision. olga.a.chupina added a reviewer: rnk. olga.a.chupina added a subscriber: cfe-commits. This patch supports using '__unaligned' attribute in function declaration: struct UnalignedS { void foo(double) __unaligned { ; } }; void bar(void (UnalignedS::*pf)(doubl

  1   2   >