bcraig added a subscriber: bcraig.
bcraig added a comment.

Note: this doesn't count as an official "LGTM".

The code change seems fine to me.  I think this has been implemented in gcc as 
well, but I don't recall for certain.  If this has been implemented in gcc, 
then I would expect the semantics to be the same.  If it hasn't been 
implemented in gcc, then we might want to pick a different name for the macro 
(e.g. __CLANG_FILE_BASENAME__).


http://reviews.llvm.org/D17741



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to