steven_wu added a comment.

Thanks for reviewing the patch. There is a problem in the test case (it only 
works on darwin). It is fixed in r262286.


================
Comment at: lib/Driver/Driver.cpp:1761
@@ -1747,1 +1760,3 @@
+    const ActionList *BackendInputs =
+      (EmbedBitcode ? Inputs : &(*Inputs)[0]->getInputs());
     // Compile job may be wrapped in CudaHostAction, extract it if
----------------
thakis wrote:
> Why is this change needed? If its needed, is the preceding comment out of 
> date now?
The preceding comment is still true but this condition makes 
BackendInputs->begin() not always CompileJobAction. I have a cleaner way to 
handle this. I am rebasing and updating the patch.


Repository:
  rL LLVM

http://reviews.llvm.org/D17390



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to