klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land.
LG ================ Comment at: lib/Tooling/Core/Replacement.cpp:290 @@ +289,3 @@ + const format::FormatStyle &Style) { + if (Replaces.empty()) return Replaces; + ---------------- I'd return a default constructed Replacements() instead - I think that requires a bit less reasoning (as written currently, I'll need to reason that a copy is made to convince myself that this is correct). http://reviews.llvm.org/D17704 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits