On Tue, Oct 13, 2015 at 11:40 PM, Eric Christopher
wrote:
>
>
> On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote:
>
>> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
>> wrote:
>>
>>> It was already reverted, but I agree, let's get this fixed first.
>>>
>>
>> It was reintroduced in r250252.
Author: silvas
Date: Wed Oct 14 01:45:07 2015
New Revision: 250273
URL: http://llvm.org/viewvc/llvm-project?rev=250273&view=rev
Log:
Revert-to-green r250262 (PS4 toolchain patch)
It is breaking llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
e.g.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_6
On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote:
> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
> wrote:
>
>> It was already reverted, but I agree, let's get this fixed first.
>>
>
> It was reintroduced in r250252. It is breaking
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-
On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
wrote:
> It was already reverted, but I agree, let's get this fixed first.
>
It was reintroduced in r250252. It is breaking
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1362
-- Sean Silva
>
> Thanks!
>
>
It was already reverted, but I agree, let's get this fixed first.
Thanks!
-eric
On Tue, Oct 13, 2015 at 11:33 PM Sean Silva wrote:
> On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova <
> katya_roman...@playstation.sony.com> wrote:
>
>> kromanova added a comment.
>>
>> Hi,
>>
>> The initial PS4 p
On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova <
katya_roman...@playstation.sony.com> wrote:
> kromanova added a comment.
>
> Hi,
>
> The initial PS4 patch caused a test failure (debug-options.c) on the PS4
> bot. I suspect that I know why the problem happens, but I'm not sure what
> will be the
mgrabovsky added a comment.
In http://reviews.llvm.org/D13643#265976, @aaron.ballman wrote:
> Should there be an exception to this diagnostic for code involving Boolean
> values? e.g.,
>
> void f(bool a, bool b, bool c) {
>
> if (a == b == c)
> ;
>
> }
>
> At the very least, it seems like
Author: echristo
Date: Wed Oct 14 00:40:21 2015
New Revision: 250271
URL: http://llvm.org/viewvc/llvm-project?rev=250271&view=rev
Log:
Canonicalize some of the x86 builtin tests and either remove or comment
about optimization options.
Modified:
cfe/trunk/test/CodeGen/3dnow-builtins.c
cfe/
Author: echristo
Date: Wed Oct 14 00:40:11 2015
New Revision: 250270
URL: http://llvm.org/viewvc/llvm-project?rev=250270&view=rev
Log:
Remove the optimization option from this test as it is unnecessary
and front end tests should avoid this if possible.
Modified:
cfe/trunk/test/CodeGen/fma-bui
ABataev added a comment.
In http://reviews.llvm.org/D13336#257628, @rnk wrote:
> I think fundamentally we are doing too much declspec property lowering in
> Sema. We might want to back up and figure out how to do it in IRGen. Right
> now we have bugs like this, which are probably more important
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250265: [MSVC] Fix for http://llvm.org/PR24132:
__declspec(property): double… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13375?vs=36331&id=37319#toc
Repository:
rL LLVM
Author: abataev
Date: Tue Oct 13 23:05:42 2015
New Revision: 250265
URL: http://llvm.org/viewvc/llvm-project?rev=250265&view=rev
Log:
[MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double
invocations of foo() when compiling foo()->propertyName
Removes extra codegen for base express
ABataev added a comment.
I see, no problems, thanks!
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
Intel Corp.
http://reviews.llvm.org/D13375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
kromanova added a comment.
Hi,
The initial PS4 patch caused a test failure (debug-options.c) on the PS4 bot. I
suspect that I know why the problem happens, but I'm not sure what will be the
best way to handle it. If someone knows how to fix this test more "elegantly",
I would appreciate their
On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote:
> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
> wrote:
>
>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva
>> wrote:
>>
>>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
On Tue,
tfiala added a comment.
Ah nice. Thanks!
-Todd
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ah nice. Thanks!
-Todd
> On Oct 13, 2015, at 5:28 PM, Ed Maste wrote:
>
> emaste added a comment.
>
>> Can we get this fixed or reversed out? Thanks!
>
>
> It's already reverted.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13482
>
>
>
_
tfiala added a subscriber: tfiala.
tfiala added a comment.
This change appears to have broken quite a few builders.
Can we get this fixed or reversed out? Thanks!
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_build/7935/
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmak
tfiala added a comment.
Oh no worries, just wanted to make sure wasn't missed, that's all.
-Todd
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
This is breaking llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1358/steps/test/logs/stdio
On Tue, Oct 13, 2015 at 6:09 PM, Ekaterina Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kromanova
(and assert.h probably isn't the best example, since it is textual)
On Tue, Oct 13, 2015 at 7:00 PM, Sean Silva wrote:
>
>
> On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote:
>
>>
>>
>> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
>> wrote:
>>
>>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva
EricWF added a comment.
For the most part this looks good. I'm a touch concerned though about the
changes to the static initialization. The initializer is moved from within the
function body to outside it. Could you have somebody confirm this won't affect
the existing ABI?
Co
On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote:
>
>
> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
> wrote:
>
>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva
>> wrote:
>>
>>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
On
On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
wrote:
> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva wrote:
>
>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits <
>>> cfe-c
EricWF added a comment.
I'm not sure about this patch quite yet.
However I am sure windows still needs these even in an unstable build.
Repository:
rL LLVM
http://reviews.llvm.org/D13713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
EricWF created this revision.
EricWF added reviewers: mclow.lists, jroelofs, danalbert, eugenis, ed.
EricWF added a subscriber: cfe-commits.
This patch changes the tests to use the "__config_site" header if present
instead of manually configuring for each option. This patch also removes the
test
eugenis set the repository for this revision to rL LLVM.
eugenis updated this revision to Diff 37310.
eugenis added a comment.
Using new ABI version macros to enable this feature in unstable or future ABI
only.
PTAL.
Repository:
rL LLVM
http://reviews.llvm.org/D10677
Files:
include/__conf
Sorry for causing the trouble with the build. I will try to look later why my
partial rebuild didn't catch the issue.
I have fixed the error, rebuilt and ran the tests.
This is a very big patch. Please be understanding, because this patch has a big
impact. I apologize in advance if it causes som
eugenis created this revision.
eugenis added reviewers: mclow.lists, EricWF.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson.
ABI stability is not an issue when building for unstable ABI.
Other than that, always_
On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva wrote:
> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Hi Richard,
>>>
>>> this co
Author: kromanova
Date: Tue Oct 13 20:09:02 2015
New Revision: 250262
URL: http://llvm.org/viewvc/llvm-project?rev=250262&view=rev
Log:
I took care of the build problem in the commit 250252.
Resubmitting the patch.
This patch adds missing pieces to clang, including the PS4 toolchain
definition,
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/TreeTransform.h:9131
@@ -9130,2 +9130,3 @@
// it's a normal declaration name.
- if (!Old->hasExplicitTemplateArgs() && !TemplateKWLoc.isValid())
On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi Richard,
>>
>> this commit appears to break the module self-host on Darwin.
>>
>> When
eugenis closed this revision.
eugenis added a comment.
Landed as r250254, thanks for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D11740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
emaste added a comment.
> Can we get this fixed or reversed out? Thanks!
It's already reverted.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: ericwf
Date: Tue Oct 13 19:22:05 2015
New Revision: 250261
URL: http://llvm.org/viewvc/llvm-project?rev=250261&view=rev
Log:
Use __config_site when building libc++. Also cleanup ABI versioning doc
Added:
libcxx/trunk/docs/DesignDocs/ABIVersioning.rst
Removed:
libcxx/trunk/docs/Abi
rnk updated this revision to Diff 37303.
rnk added a comment.
- Remove duplicate tests, beef them up
http://reviews.llvm.org/D6700
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExprMember.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/using-decl-1.cpp
test/SemaTemplate/instantiate-using-de
emaste added a subscriber: emaste.
Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:4080
@@ +4079,3 @@
+ SmallString<512> PS4SDKDir;
+ if (const char *EnvValue = getenv("SCE_PS4_SDK_DIR"))
+if (!llvm::sys::fs::exists(EnvValue))
Looks like a missing { here
R
rnk updated this revision to Diff 37302.
rnk added a comment.
- Diagnose instance members rather than pretending to build an expr
http://reviews.llvm.org/D6700
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExprMember.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/using-decl-1.cpp
test/Sema
Author: kromanova
Date: Tue Oct 13 19:03:20 2015
New Revision: 250257
URL: http://llvm.org/viewvc/llvm-project?rev=250257&view=rev
Log:
reverting my patch, cause build problems
Removed:
cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/include/.keep
cfe/trunk/test/Driver/Inputs/scei-ps4_t
Author: ericwf
Date: Tue Oct 13 18:56:33 2015
New Revision: 250256
URL: http://llvm.org/viewvc/llvm-project?rev=250256&view=rev
Log:
Workaround -pedantic flag added by LLVM
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/l
On 13 October 2015 at 23:40, Ekaterina Romanova via cfe-commits
wrote:
> Author: kromanova
> Date: Tue Oct 13 18:40:02 2015
> New Revision: 250252
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250252&view=rev
> Log:
> This patch adds missing pieces to clang, including the PS4 toolchain
> defini
Looks like this doesn't even compile:
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/32311/steps/compile/logs/stdio
Can you revert?
On Tue, Oct 13, 2015 at 4:40 PM, Ekaterina Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kromanova
> Date: Tue Oct 13 1
Author: eugenis
Date: Tue Oct 13 18:48:28 2015
New Revision: 250254
URL: http://llvm.org/viewvc/llvm-project?rev=250254&view=rev
Log:
ABI versioning macros for libc++.
C++ macros and CMake options that specify the default ABI version of
the library, and can be overridden to pick up new ABI-changi
EricWF added a comment.
LGTM. We'll fix the libc++abi issue later.
Repository:
rL LLVM
http://reviews.llvm.org/D11740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks! I just committed the patch.
Katya.
> -Original Message-
> From: Jonathan Roelofs [mailto:jonat...@codesourcery.com]
> Sent: Tuesday, October 13, 2015 3:40 PM
> To: Romanova, Katya; al...@leftfield.org; Robinson, Paul;
> echri...@gmail.com; filcab+llvm.phabrica...@gmail.com;
> jonat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250252: This patch adds missing pieces to clang, including
the PS4 toolchain (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D13482?vs=37292&id=37301#toc
Repository:
rL LLVM
Author: kromanova
Date: Tue Oct 13 18:40:02 2015
New Revision: 250252
URL: http://llvm.org/viewvc/llvm-project?rev=250252&view=rev
Log:
This patch adds missing pieces to clang, including the PS4 toolchain
definition, added warnings, PS4 defaults, and Driver changes needed for
our compiler.
A patc
eugenis updated this revision to Diff 37299.
Repository:
rL LLVM
http://reviews.llvm.org/D11740
Files:
CMakeLists.txt
cmake/Modules/HandleLibcxxFlags.cmake
docs/Abi.rst
docs/BuildingLibcxx.rst
include/__config
include/__config_site.in
include/string
lib/CMakeLists.txt
test/CM
eugenis added inline comments.
Comment at: test/libcxx/test/config.py:444
@@ -442,1 +443,3 @@
+def configure_compile_flags_abi_version(self):
+abi_version = self.get_lit_conf('abi_version', '').strip()
EricWF wrote:
> Please allow abi_version to be o
On Tue, Oct 13, 2015 at 3:26 PM, Eric Fiselier wrote:
> This change LGTM. Let's hold off on the using "_Static_assert" until we
> understand how that would work with "-pedantic" when the macro is expanded
> in user code.
>
Committed as r250247, thanks.
> /Eric
>
> On Tue, Oct 13, 2015 at 4:19
Author: akirtzidis
Date: Tue Oct 13 18:27:34 2015
New Revision: 250250
URL: http://llvm.org/viewvc/llvm-project?rev=250250&view=rev
Log:
[Sema/objc] When checking for unimplemented methods treat methods from class
extensions as continuation of the class interface.
Modified:
cfe/trunk/lib/Sem
jroelofs added inline comments.
Comment at: include/__config_site.in:13
@@ -12,1 +12,3 @@
+#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@
+#cmakedefine _LIBCPP_ABI_UNSTABLE
jroelofs wrote:
> This doesn't look right to me. What do you want this to expand
Author: rsmith
Date: Tue Oct 13 18:12:22 2015
New Revision: 250247
URL: http://llvm.org/viewvc/llvm-project?rev=250247&view=rev
Log:
Fix use of libc++ headers from within an 'extern "C"' context in C++98.
Previously, this resulted in us declaring a template for static_assert
emulation within th
jroelofs added a subscriber: jroelofs.
Comment at: include/__config_site.in:13
@@ -12,1 +12,3 @@
+#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@
+#cmakedefine _LIBCPP_ABI_UNSTABLE
This doesn't look right to me. What do you want this to expand to when it
EricWF added inline comments.
Comment at: include/__config:370
@@ -369,2 +369,3 @@
#elif defined(__linux__)
-#include
+#if defined(__GLIBC__)
+# include
jroelofs wrote:
> EricWF wrote:
> > Where does the `__GLIBC__` macro definition come from? I thought it cam
Author: cbieneman
Date: Tue Oct 13 18:03:54 2015
New Revision: 250246
URL: http://llvm.org/viewvc/llvm-project?rev=250246&view=rev
Log:
[CMake]Getting rid of references to LLVM_SUBMIT_VERSION and
LLVM_SUBMIT_SUBVERSION in favor of LLVM_VERSION_MAJOR and LLVM_VERSION_MINOR.
LLVM_SUBMIT_VERSION an
EricWF added a comment.
This is fine as a temporary workaround but it's not complete. I would rather do
something better.
Repository:
rL LLVM
http://reviews.llvm.org/D13705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
EricWF added a comment.
Please address the inline comment. I think with that change we can hold off
modifying libc++abi.
Comment at: test/libcxx/test/config.py:444
@@ -442,1 +443,3 @@
+def configure_compile_flags_abi_version(self):
+abi_version = self.get_lit_conf
jroelofs added inline comments.
Comment at: include/__config:370
@@ -369,2 +369,3 @@
#elif defined(__linux__)
-#include
+#if defined(__GLIBC__)
+# include
EricWF wrote:
> Where does the `__GLIBC__` macro definition come from? I thought it came
> from the C li
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
One small suggestion. Otherwise, this still LGTM.
Comment at: lib/Driver/ToolChains.cpp:4078
@@ +4077,3 @@
+ // should be /host_tools/bin.
+ const char *EnvValue = getenv("SCE_PS4_S
eugenis updated this revision to Diff 37293.
eugenis marked an inline comment as done.
Repository:
rL LLVM
http://reviews.llvm.org/D11740
Files:
CMakeLists.txt
cmake/Modules/HandleLibcxxFlags.cmake
docs/Abi.rst
docs/BuildingLibcxx.rst
include/__config
include/__config_site.in
inc
eugenis added inline comments.
Comment at: include/__config:252
@@ -246,1 +251,3 @@
+defined(_LIBCPP_ALTERNATE_STRING_LAYOUT)
+#define _LIBCPP_ABI_ALTERNATE_STRING_LAYOUT
#endif
EricWF wrote:
> I think he's demonstrating the patches functionality and intended
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I don't think this is ready to go. Please don't commit yet. Sorry @jroelofs.
Comment at: CMakeLists.txt:309
@@ -307,1 +308,3 @@
+config_define_if(LIBCXX_LIBC_IS_MU
kromanova updated this revision to Diff 37292.
kromanova added a comment.
Updated the patch based on Jonathan's comments.
Jonathan, if you have a minute, please review.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/B
This change LGTM. Let's hold off on the using "_Static_assert" until we
understand how that would work with "-pedantic" when the macro is expanded
in user code.
/Eric
On Tue, Oct 13, 2015 at 4:19 PM, Richard Smith
wrote:
> On Tue, Oct 13, 2015 at 2:12 PM, Eric Fiselier via cfe-commits <
> cfe-c
Author: ericwf
Date: Tue Oct 13 17:22:42 2015
New Revision: 250238
URL: http://llvm.org/viewvc/llvm-project?rev=250238&view=rev
Log:
Fix whitespace in doc
Modified:
libcxx/trunk/docs/DesignDocs/CapturingConfigInfo.rst
Modified: libcxx/trunk/docs/DesignDocs/CapturingConfigInfo.rst
URL:
http:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250237: [analyzer] Don’t invalidate CXXThis when
conservatively evaluating const… (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D13099?vs=37084&id=37291#toc
Repository:
rL
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
http://reviews.llvm.org/D13407 has landed.
http://reviews.llvm.org/D13673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
On Tue, Oct 13, 2015 at 2:12 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I would rather not do this if possible but I understand why we need to do
> it.
>
> Richard is there a cost associated with the 'extern "C++"' construct? or
> by forcing the compiler to switch mod
On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard,
>
> this commit appears to break the module self-host on Darwin.
>
> When compiling the following program generated by clang’s own cmake script:
>
> > #undef NDEBUG
> > #include
> > #
EricWF added a comment.
http://reviews.llvm.org/D13407 has landed and this is good to go.
Repository:
rL LLVM
http://reviews.llvm.org/D11740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: rsmith
Date: Tue Oct 13 17:13:33 2015
New Revision: 250236
URL: http://llvm.org/viewvc/llvm-project?rev=250236&view=rev
Log:
Remove __config module to avoid #include cycle when libc headers include
libc++'s headers.
Modified:
libcxx/trunk/include/module.modulemap
Modified: libcxx/t
Author: ericwf
Date: Tue Oct 13 17:12:02 2015
New Revision: 250235
URL: http://llvm.org/viewvc/llvm-project?rev=250235&view=rev
Log:
[libcxx] Capture configuration information when installing the libc++ headers
Summary:
Hi all,
This patch is a successor to D11963. However it has changed dramatic
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Maintainers from Apple and FreeBSD gave this the thumbs up.
http://reviews.llvm.org/D13407
___
cfe-commits maili
rjmccall added a comment.
As a more general comment, I believe the rule is that we try to always make a
MemberExpr/UnresolvedMemberExpr whenever there *might* be a base, but that the
resulting distinction between an implicit-base UnresolvedMemberExpr and an
UnresolvedLookupExpr is not actually
rjmccall added inline comments.
Comment at: lib/Sema/TreeTransform.h:9135
@@ +9134,3 @@
+if (NamedDecl *D = R.getAsSingle()) {
+ D = D->getUnderlyingDecl();
+ if (isa(D) || isa(D) ||
getAsSingle already looks through to the underlying decl.
dcoughlin added a comment.
> There is a loss of precision for loops that need to be executed exactly
> maxBlockVisitOnPath times, as the loop body is executed with the widened
> state instead of the last iteration.
I think this is an acceptable loss of precision because, in general, it is
unl
I would rather not do this if possible but I understand why we need to do
it.
Richard is there a cost associated with the 'extern "C++"' construct? or by
forcing the compiler to switch modes in general?
On Mon, Oct 12, 2015 at 12:27 PM, Richard Smith
wrote:
> On Mon, Oct 12, 2015 at 9:41 AM,
Hi Richard,
this commit appears to break the module self-host on Darwin.
When compiling the following program generated by clang’s own cmake script:
> #undef NDEBUG
> #include
> #define NDEBUG
> #include
> int main() { assert(this code is not compiled); }
with clang++ -std=c++11 -fmodules -fc
rjmccall added a comment.
This is an inappropriate fix for this problem. If these runtime functions can
never throw, which seems to be the case, you should create the function type
with a no-throw exception specification, which will make EmitCall emit the call
with a CallInst. EST_BasicNoexce
Author: aaronballman
Date: Tue Oct 13 15:42:41 2015
New Revision: 250221
URL: http://llvm.org/viewvc/llvm-project?rev=250221&view=rev
Log:
Exposing an existing checker under the name cert-err61-cpp, as it corresponds
to the CERT C++ secure coding rule:
https://www.securecoding.cert.org/confluenc
rnk added inline comments.
Comment at: lib/Sema/TreeTransform.h:9138
@@ +9137,3 @@
+ isa(D))
+return getSema().BuildPossibleImplicitMemberExpr(
+SS, SourceLocation(), R, /*TemplateArgs=*/nullptr,
I believe this will always fail, so one
rnk updated this revision to Diff 37283.
rnk added a comment.
- Rebase
http://reviews.llvm.org/D6700
Files:
lib/Sema/TreeTransform.h
test/SemaTemplate/instantiate-using-decl.cpp
Index: test/SemaTemplate/instantiate-using-decl.cpp
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
What is preventing to add this check to Clang-tidy? Just found another piece of
fresh C++ code in LLDB with (void) as argument list...
http://reviews.llvm.org/D7639
rnk added a comment.
Richard suggested that maybe we formed the wrong AST while parsing the
template. I'm not sure that's the case. We have this very explicit logic that
controls what AST nodes we form in SemaExprMember.cpp
ClassifyImplicitMemberAccess:
bool isStaticContext = SemaRef.CXXThis
thakis added inline comments.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
comex wro
comex added inline comments.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
thakis wro
davidxl abandoned this revision.
davidxl added a comment.
The refactoring is done by a previous patch already.
http://reviews.llvm.org/D13326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
eugenis created this revision.
eugenis added reviewers: mclow.lists, EricWF.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
Libcxxabi tests are built against non-installed libc++ headers, and they need
to know the ABI version libc++ is configured
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added a subscriber: cfe-commits.
Two smallish patches in one. Happy to split into two (for review and/or commit)
if that's preferred.
In C, we allow (as an extension) incompatible pointer conve
Author: echristo
Date: Tue Oct 13 13:40:21 2015
New Revision: 250203
URL: http://llvm.org/viewvc/llvm-project?rev=250203&view=rev
Log:
Move the adc-builtins test to the pattern of the other builtins
tests by predefining _MM_MALLOC_H rather than use -ffreestanding.
Modified:
cfe/trunk/test/Cod
Author: echristo
Date: Tue Oct 13 13:40:17 2015
New Revision: 250202
URL: http://llvm.org/viewvc/llvm-project?rev=250202&view=rev
Log:
Add subtarget feature support for 3dnowa to the 3dnowa intrinsics.
Modified:
cfe/trunk/lib/Headers/mm3dnow.h
Modified: cfe/trunk/lib/Headers/mm3dnow.h
URL:
Author: cbieneman
Date: Tue Oct 13 13:17:30 2015
New Revision: 250196
URL: http://llvm.org/viewvc/llvm-project?rev=250196&view=rev
Log:
[CMake] When building clang as an external project we should pass through all
variables that start with COMPILER_RT
Modified:
cfe/trunk/runtime/CMakeLists.t
Author: aaronballman
Date: Tue Oct 13 13:13:10 2015
New Revision: 250194
URL: http://llvm.org/viewvc/llvm-project?rev=250194&view=rev
Log:
Updating the documentation for the
readability-inconsistent-declaration-parameter-name checker.
Patch by Piotr Dziwinski.
Modified:
clang-tools-extra/t
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1463
@@ +1462,3 @@
+ let Spellings = [GNU<"unique_instantiation">];
+ let Subjects = SubjectList<[Function, CXXRecord], ErrorDiag,
"ExpectedFunctionOrClass">;
+ let Documentation = [UniqueInstantiatio
kromanova added a comment.
Thank you! I will rebase and commit shortly
Katya.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a subscriber: echristo.
echristo added a comment.
(Jonathan's review here is fine, don't wait on me. Thanks! :)
-eric
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
(Jonathan's review here is fine, don't wait on me. Thanks! :)
-eric
On Tue, Oct 13, 2015 at 10:32 AM Jonathan Roelofs
wrote:
> jroelofs added a comment.
>
> Other than that, LGTM too.
>
>
>
> Comment at: lib/Driver/ToolChains.cpp:4081
> @@ +4080,3 @@
> +
> + std::string PS4SDK
jroelofs added a comment.
Other than that, LGTM too.
Comment at: lib/Driver/ToolChains.cpp:4081
@@ +4080,3 @@
+
+ std::string PS4SDKDir = (EnvValue ? EnvValue : getDriver().Dir + "/../..");
+
Use `llvm::sys::path::append` instead of `std::string::operator+` for
1 - 100 of 143 matches
Mail list logo
