jroelofs added inline comments. ================ Comment at: include/__config:370 @@ -369,2 +369,3 @@ #elif defined(__linux__) -#include <features.h> +#if defined(__GLIBC__) +# include <features.h> ---------------- EricWF wrote: > Where does the `__GLIBC__` macro definition come from? I thought it came > from the C library headers but we don't include any! No need for the check to look at __GLIBC__ anyway... `_LIBCXX_LIBC_IS_MUSL` would be available here, so you should be testing for: `!defined(_LIBCXX_LIBC_IS_MUSL)` instead (or however that flag ends up being named).
================ Comment at: include/support/musl/xlocale.h:10 @@ +9,3 @@ +//===----------------------------------------------------------------------===// +// This is a shared implementation of a shim to provide extended locale support +// on top of libc's that don't support it (like Android's bionic, and Newlib). ---------------- This comment was cargo-culted from `include/support/xlocale/xlocale.h`... Given that this is musl-specific, I don't think it makes sense to call this file "shared" in the same sense that the other one is. http://reviews.llvm.org/D13673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
