EricWF added inline comments.

================
Comment at: include/__config:370
@@ -369,2 +369,3 @@
 #elif defined(__linux__)
-#include <features.h>
+#if defined(__GLIBC__)
+# include <features.h>
----------------
jroelofs wrote:
> EricWF wrote:
> > Where does the `__GLIBC__`  macro definition come from? I thought it came 
> > from the C library headers but we don't include any!
> No need for the check to look at __GLIBC__ anyway... `_LIBCXX_LIBC_IS_MUSL` 
> would be available here, so you should be testing for: 
> `!defined(_LIBCXX_LIBC_IS_MUSL)` instead (or however that flag ends up being 
> named).
Sounds good to me.


http://reviews.llvm.org/D13673



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to