On Tue, Oct 13, 2015 at 11:40 PM, Eric Christopher <echri...@gmail.com> wrote:
> > > On Tue, Oct 13, 2015 at 11:38 PM Sean Silva <chisophu...@gmail.com> wrote: > >> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher <echri...@gmail.com> >> wrote: >> >>> It was already reverted, but I agree, let's get this fixed first. >>> >> >> It was reintroduced in r250252. It is breaking >> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1362 >> >> > Ah, I missed that. Yeah, please go ahead and revert for now. > reverted in r250273 (bot is back to green: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1363 ) Katya - remember to run the tests with LLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4 (and also remember to keep an eye on the bots after committing) -- Sean Silva > > Thanks! > > -eric > > >> -- Sean Silva >> >> >>> >>> Thanks! >>> >>> -eric >>> >>> On Tue, Oct 13, 2015 at 11:33 PM Sean Silva <chisophu...@gmail.com> >>> wrote: >>> >>>> On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova < >>>> katya_roman...@playstation.sony.com> wrote: >>>> >>>>> kromanova added a comment. >>>>> >>>>> Hi, >>>>> >>>>> The initial PS4 patch caused a test failure (debug-options.c) on the >>>>> PS4 bot. I suspect that I know why the problem happens, but I'm not sure >>>>> what will be the best way to handle it. If someone knows how to fix this >>>>> test more "elegantly", I would appreciate their advice. >>>>> >>>>> FAIL: Clang :: Driver/debug-options.c (3509 of 24708) >>>>> >>>>> - TEST 'Clang :: Driver/debug-options.c' FAILED ******************** >>>>> >>>>> Script: >>>>> ------- >>>>> >>>>> /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/./bin/clang >>>>> -### -c -g >>>>> /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/debug-options.c >>>>> -target x86_64-linux-gnu 2>&1 | >>>>> /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/./bin/FileCheck >>>>> -check-prefix=G /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei- >>>>> .... >>>>> >>>>> /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/./bin/clang >>>>> -### -g >>>>> /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/debug-options.c >>>>> 2>&1 | >>>>> /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/./bin/FileCheck >>>>> -check-prefix=CI >>>>> /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/debug-options.c >>>>> >>>>> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ >>>>> >>>>> Exit Code: 1 >>>>> >>>>> Command Output (stderr): >>>>> ------------------------ >>>>> >>>>> /home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/debug-options.c:139:8: >>>>> error: expected string not found in input >>>>> // CI: "-dwarf-column-info" >>>>> >>>>> ^ >>>>> >>>>> <stdin>:1:1: note: scanning from here >>>>> clang version 3.8.0 (trunk 250262) >>>>> ^ >>>>> <stdin>:5:438: note: possible intended match here >>>>> >>>>> "/home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/bin/clang-3.8" >>>>> "-cc1" "-triple" "x86_64-scei-ps4" "-emit-obj" "-mrelax-all" >>>>> "-disable-free" "-main-file-name" "debug-options.c" "-mrelocation-model" >>>>> "pic" "-pic-level" "2" "-mthread-model" "posix" "-mdisable-fp-elim" >>>>> "-masm-verbose" "-mconstructor-aliases" "-munwind-tables" "-target-cpu" >>>>> "btver2" "-momit-leaf-frame-pointer" "-debug-info-kind=limited" >>>>> "-dwarf-version=4" "-backend-option" "-generate-arange-section" >>>>> "-resource-dir" >>>>> "/home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/bin/../lib/clang/3.8.0" >>>>> "-fdebug-compilation-dir" >>>>> "/home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/test/Driver" >>>>> "-ferror-limit" "19" "-fmessage-length" "0" "-stack-protector" "2" >>>>> "-fdeclspec" "-fobjc-runtime=gnustep" "-fdiagnostics-show-option" "-o" >>>>> "/tmp/debug-options-1505f5.o" "-x" "c" >>>>> "/home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/test/Driver/debug-options.c" >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> ^ >>>>> >>>>> - >>>>> >>>>> The latest driver patch introduced a change, causing the PS4 driver >>>>> *not* to have -gcolumn-info enabled by default. >>>>> >>>>> Consequently, this generic line started to fail on the PS4 bot. >>>>> // RUN: %clang -### -g %s 2>&1 | FileCheck -check-prefix=CI %s >>>>> >>>>> Does someone know what will be the best way to run the test line for >>>>> all the platforms, except PS4? >>>>> >>>>> In the patch, we have added a couple of PS4 specific lines to this >>>>> test, to verify that the behavior on PS4 is correct: >>>>> >>>>> // RUN: %clang -### -c %s -g -target x86_64-scei-ps4 2>&1 \ >>>>> // RUN: | FileCheck -check-prefix=NOCI %s >>>>> >>>>> // RUN: %clang -### -c %s -g -gcolumn-info -target x86_64-scei-ps4 >>>>> 2>&1 \ >>>>> // RUN: | FileCheck -check-prefix=CI %s >>>>> >>>>> I do not want to make this test XFAIL for PS4 (though I might do it as >>>>> an interim solution). I would also prefer to avoid duplicating most of the >>>>> content of this file into a separate ps4-specific file. >>>>> Any ideas how to handle this issue "more elegantly"? >>>>> >>>>> If nobody objects, I will mark this test as XFAIL for PS4 for a time >>>>> being. >>>>> >>>> >>>> Please revert until you can solve the issue. >>>> >>>> -- Sean Silva >>>> >>>> >>>>> >>>>> Katya. >>>>> >>>>> >>>>> Repository: >>>>> rL LLVM >>>>> >>>>> http://reviews.llvm.org/D13482 >>>>> >>>>> >>>>> >>>>>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
