jroelofs added a comment. Other than that, LGTM too.
================ Comment at: lib/Driver/ToolChains.cpp:4081 @@ +4080,3 @@ + + std::string PS4SDKDir = (EnvValue ? EnvValue : getDriver().Dir + "/../.."); + ---------------- Use `llvm::sys::path::append` instead of `std::string::operator+` for path concatenation here, ================ Comment at: lib/Driver/ToolChains.cpp:4095 @@ +4094,3 @@ + + std::string PS4SDKIncludeDir = PrefixDir + "/target/include"; + if (!Args.hasArg(options::OPT_nostdinc) && ---------------- and here, ================ Comment at: lib/Driver/ToolChains.cpp:4105 @@ +4104,3 @@ + + std::string PS4SDKLibDir = PS4SDKDir + "/target/lib"; + if (!Args.hasArg(options::OPT_nostdlib) && ---------------- and here. Repository: rL LLVM http://reviews.llvm.org/D13482 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
