Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-14 Thread Kim Barrett
On Fri, 15 Nov 2024 05:33:57 GMT, Julian Waters wrote: >> I switched from my standard gcc 11.3.0 devkit to 13.2.1; build works nicely >> with it and jtreg HS :tier1 results look similar to what I get with gcc >> 11.3.0. >> I still get 90 of those ugly `warning: call to ‘vsnprintf’ declared wi

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread David Holmes
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread David Holmes
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-14 Thread Julian Waters
On Thu, 14 Nov 2024 14:08:39 GMT, Matthias Baesken wrote: >> My experience is quite different. As I've said previously, I'm not getting >> anywhere near through a build >> with gcc13.2. As far as I can tell, building with LTO is quite badly >> broken. It's bad enough, and other >> runtime is

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v57]

2024-11-14 Thread David Holmes
On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> previ

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Iris Clark
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-14 Thread Coleen Phillimore
On Wed, 13 Nov 2024 23:15:47 GMT, Calvin Cheung wrote: >> With this change, the compact object headers related CDS archives >> (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by >> default. If the user needs them, the user can specify the >> `--enable-cds-archive-coh=ye

Re: RFR: 8344191: Build code should not have classpath exception

2024-11-14 Thread Magnus Ihse Bursie
On Thu, 14 Nov 2024 15:23:35 GMT, Jonathan Gibbons wrote: > The policy has long been to use Classpath Exception in the src and make > directories, but not in the test directories. If you're changing the policy, > you might want to check and update any documentation where the policy might > be

Re: RFR: 8344128: Regression: make help broken after JDK-8340818

2024-11-14 Thread Nizar Benalla
On Wed, 13 Nov 2024 22:56:47 GMT, Nizar Benalla wrote: > I was not successful in writing a test to check to return value of `make > help`, but this patch should fix the current bug. > > > % make help >/dev/null; echo $? > >

Integrated: 8344128: Regression: make help broken after JDK-8340818

2024-11-14 Thread Nizar Benalla
On Wed, 13 Nov 2024 22:56:47 GMT, Nizar Benalla wrote: > I was not successful in writing a test to check to return value of `make > help`, but this patch should fix the current bug. > > > % make help >/dev/null; echo $? > >

Re: RFR: 8344093: Implementation of JEP XXX: Deprecate the 32-bit x86 Port for Removal [v2]

2024-11-14 Thread David Holmes
On Wed, 13 Nov 2024 15:39:42 GMT, Aleksey Shipilev wrote: >> WIP, as the JEP is still not targeted. We can review code meanwhile. >> >> Additional testing: >> - [x] Linux x86-32 build configure fails by default >> - [x] Linux x86-32 build configures well with >> `--enable-deprecated-ports=yes

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-14 Thread Matthias Baesken
On Thu, 14 Nov 2024 09:21:06 GMT, Julian Waters wrote: >>> And not under the rubric of a warnings fix. >> >> Maybe the title is a bit misleading, it is more about a build fix (lto build >> did not work for me with gcc 11.3.0; with this fix it works). >> If the lot stuff is broken and there is n

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-14 Thread Kim Barrett
On Thu, 14 Nov 2024 10:02:44 GMT, Matthias Baesken wrote: >> I would hope that LTO won't be removed. I plan to try making it viable, and >> I also use it downstream on Windows. I'm having trouble downgrading my gcc >> package on WSL to reproduce the warning, so might take me some time to find

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-14 Thread Julian Waters
On Thu, 14 Nov 2024 09:08:00 GMT, Matthias Baesken wrote: >> Hmmm ... I thought we had LTO enabled in the past for Java SE Embedded ... > >> And not under the rubric of a warnings fix. > > Maybe the title is a bit misleading, it is more about a build fix (lto build > did not work for me with gc

github repo hash in the binaries and hserr file ?

2024-11-14 Thread Baesken, Matthias
Hello, I wonder if there is / was already an attempt to compile the github repo hash into the binaries and later also output it in the hserr / hsinfo file ? I would consider the information helpful for identification of the matching sources (e.g. matching to the source files mentioned in the

Re: RFR: 8344056: Use markdown format for man pages

2024-11-14 Thread Daniel Fuchs
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote: > Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms o

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-14 Thread Kim Barrett
On Thu, 14 Nov 2024 08:58:09 GMT, Matthias Baesken wrote: >> make/hotspot/lib/JvmFeatures.gmk line 173: >> >>> 171: JVM_OPTIMIZATION := HIGHEST_JVM >>> 172: ifeq ($(call isCompiler, gcc), true) >>> 173: JVM_CFLAGS_FEATURES += -DINCLUDE_LTO=1 -flto=auto >>> -fuse-linker-plugin -fno-stric

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-14 Thread Matthias Baesken
On Thu, 14 Nov 2024 07:55:46 GMT, David Holmes wrote: >> There are quite a number of things in HotSpot that seemingly wouldn't work >> with LTO enabled. One notable example is os::current_stack_pointer, which on >> many platforms simply returns the frame pointer of os::current_stack_pointer >>

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-14 Thread David Holmes
On Thu, 14 Nov 2024 07:26:41 GMT, Julian Waters wrote: >> make/hotspot/lib/JvmOverrideFiles.gmk line 43: >> >>> 41: ifeq ($(call check-jvm-feature, link-time-opt), true) >>> 42: BUILD_LIBJVM_g1ParScanThreadState.cpp_CXXFLAGS := -fno-lto >>> 43: endif >> >> Even with this change I still

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-14 Thread Matthias Baesken
On Thu, 14 Nov 2024 07:08:08 GMT, Kim Barrett wrote: >> When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on >> Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into >> this error : >> >> .. tons of free and malloc related warnings ... >> >> >> i

Re: RFR: 8344093: Implementation of JEP XXX: Deprecate the 32-bit x86 Port for Removal [v2]

2024-11-14 Thread Aleksey Shipilev
On Thu, 14 Nov 2024 08:02:09 GMT, David Holmes wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> comm

Re: RFR: 8344191: Build code should not have classpath exception

2024-11-14 Thread Jonathan Gibbons
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote: > In several (most? all?) of the build system files, the copyright header > includes the classpath exception. This makes no sense, and should be removed. > > I have removed the classpath exception from makefiles, autoconf, shell > sc

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Magnus Ihse Bursie
> Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms of editing, we make changes to > the man pages in markdown and

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Magnus Ihse Bursie
On Wed, 13 Nov 2024 21:55:53 GMT, Iris Clark wrote: >> src/java.base/share/man/java.md line 9: >> >>> 7: # published by the Free Software Foundation. Oracle designates this >>> 8: # particular file as subject to the "Classpath" exception as provided >>> 9: # by Oracle in the LICENSE file that a

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Magnus Ihse Bursie
On Thu, 14 Nov 2024 12:29:38 GMT, Christian Stein wrote: > Now `CheckManPageOptions` finds the `.md` file (good) and its checks fail > (bad). *sigh* > A candidate for an ignore list as fixing it is out of scope of this PR? Let me have a look at it first. It seems the test has the indention t

RFR: 8344191: Build code should not have classpath exception

2024-11-14 Thread Magnus Ihse Bursie
In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build t

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Christian Stein
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344128: Regression: make help broken after JDK-8340818

2024-11-14 Thread Magnus Ihse Bursie
On Wed, 13 Nov 2024 22:56:47 GMT, Nizar Benalla wrote: > I was not successful in writing a test to check to return value of `make > help`, but this patch should fix the current bug. > > > % make help >/dev/null; echo $? > >

Re: RFR: 8343503: Problemlist support fastdebug/slowdebug build

2024-11-14 Thread SendaoYan
On Mon, 4 Nov 2024 03:31:40 GMT, SendaoYan wrote: > Hi all, > Sometimes some tests only fails or crash run by fastdebug/slowdebug jdk > binary, such as > `java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1` which has been > recorded by [JDK-8343244](https://bugs.openjdk.org/browse/JD

Withdrawn: 8343503: Problemlist support fastdebug/slowdebug build

2024-11-14 Thread SendaoYan
On Mon, 4 Nov 2024 03:31:40 GMT, SendaoYan wrote: > Hi all, > Sometimes some tests only fails or crash run by fastdebug/slowdebug jdk > binary, such as > `java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1` which has been > recorded by [JDK-8343244](https://bugs.openjdk.org/browse/JD

Re: RFR: 8344191: Build code should not have classpath exception

2024-11-14 Thread Abdelhak Zaaim
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote: > In several (most? all?) of the build system files, the copyright header > includes the classpath exception. This makes no sense, and should be removed. > > I have removed the classpath exception from makefiles, autoconf, shell > sc

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-14 Thread Matthias Baesken
On Thu, 14 Nov 2024 11:27:25 GMT, Kim Barrett wrote: >>> Hmmm ... I thought we had LTO enabled in the past for Java SE Embedded ... >> >> Hi Julian / David, I started the HS :tier1 tests with the lto-enabled JVM >> (linuxx86_64). >> Most tests work, but I get a number of errors too, mostly (

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-14 Thread Matthias Baesken
On Thu, 14 Nov 2024 09:06:46 GMT, Kim Barrett wrote: >> It was included because all JVM features have a related define (e.g. >> INCLUDE_JFR, INCLUDE_JVMCI) and I missed that one here. >> Or is it already available and I just missed the define related to >> link-time-optimization ? >> But in a w

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-14 Thread Matthias Baesken
On Wed, 13 Nov 2024 12:17:07 GMT, Matthias Baesken wrote: > When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on > Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into this > error : > > .. tons of free and malloc related warnings ... > > > inli

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-14 Thread Matthias Baesken
> When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on > Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into this > error : > > .. tons of free and malloc related warnings ... > > > inlined from 'pop_segment' at > src/hotspot/share/utilities/sta