On Thu, 14 Nov 2024 09:06:46 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> It was included because all JVM features have a related define (e.g. >> INCLUDE_JFR, INCLUDE_JVMCI) and I missed that one here. >> Or is it already available and I just missed the define related to >> link-time-optimization ? >> But in a way you are correct , currently the added define it not needed >> technically in this PR . >> And we might think about the naming (INCLUDE_LINK_TIME_OPTIMIZATION vs. >> INCLUDE_LTO). > > I'd prefer a more meaningful name. LTO seems a little generic and opaque. > If you know then you > know, but if you don't then you are puzzled. I renamed the define to INCLUDE_LINK_TIME_OPTIMIZATION. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22069#discussion_r1842289830
