On Thu, 14 Nov 2024 08:02:09 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Merge branch 'master' into JDK-8344093-x86-32-deprecation >> - Initial work > > .github/workflows/main.yml line 39: > >> 37: description: 'Platform(s) to execute on (comma separated, e.g. >> "linux-x64, macos, aarch64")' >> 38: required: true >> 39: default: 'linux-x64, linux-x64-variants, linux-cross-compile, >> alpine-linux-x64, macos-x64, macos-aarch64, windows-x64, windows-aarch64, >> docs' > > Why does deprecation imply we stop caring about it completely? Shouldn't we > continue to test until it is removed? I think in reverse: we have already stopped caring about 32-bit x86 completely, and now our build/test configs are catching up with reality :) We added 32-bit x86 GHA testing when there were active maintainers, and so to avoid simple breakages that help maintenance, at the expense of folks discovering and fixing build failures there. Today, there are no maintainers who are willing to continue. So, now saddling everyone with 32-bit x86 code build issues helps no one, and fixing issues in the code that is going away would be just extra work for no real gain. Whoever -- if anyone -- cares about 32-bit x86 port after this, would need to build and test the port themselves. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22062#discussion_r1841992023
