On Wed, 13 Nov 2024 15:39:42 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> WIP, as the JEP is still not targeted. We can review code meanwhile. >> >> Additional testing: >> - [x] Linux x86-32 build configure fails by default >> - [x] Linux x86-32 build configures well with >> `--enable-deprecated-ports=yes` >> - [ ] GHA > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into JDK-8344093-x86-32-deprecation > - Initial work .github/workflows/main.yml line 39: > 37: description: 'Platform(s) to execute on (comma separated, e.g. > "linux-x64, macos, aarch64")' > 38: required: true > 39: default: 'linux-x64, linux-x64-variants, linux-cross-compile, > alpine-linux-x64, macos-x64, macos-aarch64, windows-x64, windows-aarch64, > docs' Why does deprecation imply we stop caring about it completely? Shouldn't we continue to test until it is removed? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22062#discussion_r1841729240
