On Wed, 13 Nov 2024 23:15:47 GMT, Calvin Cheung <cche...@openjdk.org> wrote:

>> With this change, the compact object headers related CDS archives 
>> (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by 
>> default. If the user needs them, the user can specify the 
>> `--enable-cds-archive-coh=yes` build configure option.
>> This change also modified the TestDefaultArchiveLoading.java test.
>> 
>> Testing:
>> 
>> - default build config: classes*coh.jsa CDS archives are not generated
>> - build configured with `--enable-cds-archive-coh=yes`: classes*coh.jsa CDS 
>> archives are generated
>> - build configured with `--enable-cds-archive-coh=no`: classes*coh.jsa CDS 
>> archives are not generated
>> - passed tiers 1 and 3 tests
>
> Calvin Cheung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   @iklam comment

Looks good.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22051#pullrequestreview-2437333350

Reply via email to