On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjdk.org/browse/
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjdk.org/browse/
On Thu, 3 Apr 2025 12:55:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote:
> Refactor XMLSecurityPropertyManager.
> The Xerces and Xalan components each had its own XMLSecurityManager and
> XMLSecurityPropertyManager. In a previous fix, the former had been unified as
> part of that changeset. This change will allow fut
On Fri, 4 Apr 2025 16:12:56 GMT, Lance Andersen wrote:
>> As we checking entry uniqueness and the size match, and all LOC entries
>> should be in CEN, that would means all CEN entries in LOC.
>> But if we would like to be specific about the inconsistency, then we will
>
On Fri, 4 Apr 2025 16:01:40 GMT, Henry Jen wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line
>> 147:
>>
>>> 145: in incompatible public interfaces
>>> 146: warn.validator.duplicate.entry=\
>>> 147: Warning: More than one copy of {0} is detected
On Fri, 4 Apr 2025 16:06:07 GMT, Henry Jen wrote:
>> Is the ordering required by ZIP or Jar format? We can certainly do that if
>> that's under spec and not an implementation detail.
>
> As we checking entry uniqueness and the size match, and all LOC entries
> should be in CEN, that would mean
On Fri, 4 Apr 2025 00:39:04 GMT, Henry Jen wrote:
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Thank you for starting the wor
On Mon, 31 Mar 2025 19:18:58 GMT, Joe Wang wrote:
>> LGTM. Technically it is still March in PDT though
>
>> LGTM. Technically it is still March in PDT though
>
> Thanks. It is, tricky. Thought by the time it's out, it would be April.
@JoeWang-Java,
Can you confirm which Mach5 tiers have run wi
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.ope
On Fri, 21 Mar 2025 19:23:59 GMT, Hai-May Chao wrote:
>> The jarsigner -verify command currently performs verification by reading
>> from JarFile to navigate the central directory (CEN) headers. It is now
>> enhanced to include cross-validation of entries between JarFile (CEN-based)
>> and Jar
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Shema 1.0 DTDs.
>
> Joe Wang has updated the pull request incrementally with one addi
On Mon, 10 Mar 2025 21:11:15 GMT, Kevin Driver wrote:
>> test/jdk/sun/security/tools/jarsigner/MultiManifest.jar line 1:
>>
>>> 1: PKO�rY
>>> META-INF/��PKPKO�rYMETA-INF/MANIFEST.MF�M��LK-.�
>>
>> We usually do not include a binary file in the code repository. Can you
>>
On Mon, 10 Mar 2025 18:06:43 GMT, Roger Riggs wrote:
> Remove misleading/invalid diagnostic output from the JAR manifest test
> ValueUtf8Coding.java.
>
> The Manifest binary stream is not a well formed UTF-8 string due to the
> inserted continuation characters used for lines longer than 70 cha
On Mon, 3 Mar 2025 11:59:36 GMT, Eirik Bjørsnøs wrote:
> > Given the inputs from Alan, Eirik and Lance, I have now updated this PR
> > [...]
>
> > Does this look better?
>
> I like the structure this is shaping into, with the affected constructors
> linking into a note. I like that the note e
On Mon, 24 Feb 2025 05:50:40 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> an intermittent failure in the
> `test/jdk/java/util/zip/ZipFile/TestCleaner.java` test?
>
> This test does operations on Inflater/Deflater/ZipFile and closes
On Wed, 19 Feb 2025 00:16:13 GMT, Joe Wang wrote:
>> Fix an edge case in the patch for JDK-8207760.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add tests verifying invalid sequence; also add tests to verify cases where
> t
On Fri, 14 Feb 2025 19:09:53 GMT, Joe Wang wrote:
>> Fix an edge case in the patch for JDK-8207760.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> un-needed property removed
Marked as reviewed by lancea (Reviewer).
-
On Fri, 14 Feb 2025 00:56:03 GMT, Joe Wang wrote:
> Fix an edge case in the patch for JDK-8207760.
Marked as reviewed by lancea (Reviewer).
test/jaxp/javax/xml/jaxp/unittest/transform/JDK8207760.java line 125:
> 123: Transformer t = createTransformerFromInputstream(
> 124:
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
On Fri, 14 Feb 2025 07:41:26 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to properly close the
> `Inflater` instance used in
> `jdk.internal.jimage.decompressor.ZipDecompressor.decompress()` method? This
> addresses https://bugs.openjdk.org/browse/JDK-834
On Wed, 12 Feb 2025 15:45:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Fri, 7 Feb 2025 20:03:21 GMT, Joe Wang wrote:
> Fix an error handling where the XMLStreamReader impl throws EOFException
> instead of XMLStreamException as defined.
Looks OK Joe
I might suggest an RN to give a heads up on the change of Exception to match he
spec
-
Marked as r
On Thu, 6 Feb 2025 20:19:53 GMT, Joe Wang wrote:
>> Fix an issue where the translet-name is incorrectly set when the
>> package-name is also specified.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update test
Marked as rev
On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang wrote:
> Fix an issue where the translet-name is incorrectly set when the package-name
> is also specified.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23446#pullrequestreview-2599444141
On Fri, 19 Jul 2024 15:16:01 GMT, Lance Andersen wrote:
>>> I understand the request here, but is there a current use case for needing
>>> a custom Deflater?
>>
>> I think the primary use case is when you want to set a non-default
>> compression level, e.g.
On Thu, 23 Jan 2025 00:46:07 GMT, Joe Wang wrote:
>> Fix broken links in java.xml:
>>
>> Catalog: contacted Oasis. The standard page
>> (https://www.oasis-open.org/standard/xmlcatalogs/) now links to the PDF
>> version. That is what I'm using now, replacing the html pages. Not ideal,
>> but a
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Thu, 9 Jan 2025 00:27:15 GMT, Brian Burkhalter wrote:
> Change the test as done in #22957 for
> [JDK-8346671](https://bugs.openjdk.org/browse/JDK-8346671).
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22994#pullrequestreview-2540788054
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Tue, 7 Jan 2025 10:45:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Sun, 29 Dec 2024 14:51:06 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which improves the
> `test/jdk/java/util/zip/EntryCount64k.java` test code to allow for it to pass
> when the JVM logs any warning when launching an application through `java
> -jar ...`?
On Fri, 20 Dec 2024 14:15:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8302293?
>>
>> As noted in the issue, when creating a temporary file during the "jar
>> --create" operation, if the
On Thu, 19 Dec 2024 00:36:44 GMT, Brian Burkhalter wrote:
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Marked as reviewed by lancea (Reviewer).
Marke
On Wed, 18 Dec 2024 14:58:26 GMT, Roger Riggs wrote:
> Continuing SM removal cleanup of tests for test/jdk/java/beans and
> test/jdk/java/io/Serializable.
> Removing doPrivileged, Permissions, and SecurityException.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://gi
On Wed, 18 Dec 2024 14:58:26 GMT, Roger Riggs wrote:
> Continuing SM removal cleanup of tests for test/jdk/java/beans and
> test/jdk/java/io/Serializable.
> Removing doPrivileged, Permissions, and SecurityException.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://gi
ly do not suggest that we should define any kind of default for
this option. This should be entirely up to the user.
Feedback on this proposal is welcome. (I have a draft implementation around,
but let's focus on the merits of the proposal before we dive into any code)
Eirik.
[oracle_sig_
On Mon, 16 Dec 2024 20:33:38 GMT, Naoto Sato wrote:
> A very minor test fix.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22773#pullrequestreview-2507320144
On Mon, 16 Dec 2024 15:15:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8345506?
>>
>> The `jar` tool has several operations which take `--file` as a parameter.
>> The value for tha
On Sun, 15 Dec 2024 17:48:06 GMT, Lance Andersen wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [ab1dbd40](https://github.com/openjdk/jdk/commit/ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repositor
Hi all,
This pull request contains a backport of commit
[ab1dbd40](https://github.com/openjdk/jdk/commit/ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Lance Andersen on 15 Dec 2024
On Fri, 13 Dec 2024 16:54:05 GMT, Lance Andersen wrote:
> Please review this trivial PR which removes `(See below)` which was missed
> during the SQLPermission update as part of the updates for [JEP 486:
> Permanently Disable the Security Manager](https://openjdk.org/jeps/486)
&g
On Fri, 13 Dec 2024 20:21:49 GMT, Sean Mullan wrote:
> Can you add a `jep486` label to the bug? Otherwise, looks good.
Done, thank you Sean
-
PR Comment: https://git.openjdk.org/jdk/pull/22739#issuecomment-2542244627
Please review this trivial PR which removes `(See below)` which was missed
during the SQLPermission update as part of the updates for [JEP 486:
Permanently Disable the Security Manager](https://openjdk.org/jeps/486)
I have confirmed there are no issues with the build via a macht tier1 run
---
On Tue, 10 Dec 2024 15:31:08 GMT, Roger Riggs wrote:
> Backport this trivial fix to parsing of the system property
> "resource.bundle.debug" to jdk24.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22664#pullrequestreview-2500333810
On Tue, 10 Dec 2024 15:31:08 GMT, Roger Riggs wrote:
> Backport this trivial fix to parsing of the system property
> "resource.bundle.debug" to jdk24.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22664#pullrequestreview-2500333810
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 17:22:14 GMT, Roger Riggs wrote:
> Replace broken getProperty with Boolean.getBoolean.
>
> Manual testing confirms trace messages are enabled with
> `-Dresource.bundle.debug=true`
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk
On Mon, 9 Dec 2024 17:22:14 GMT, Roger Riggs wrote:
> Replace broken getProperty with Boolean.getBoolean.
>
> Manual testing confirms trace messages are enabled with
> `-Dresource.bundle.debug=true`
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk
On Fri, 6 Dec 2024 19:24:51 GMT, Brent Christian wrote:
>> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call
>> through `ReflectUtil.forName()`. When
>> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`,
>> it is doing so from `java.base`, and so u
On Fri, 6 Dec 2024 17:38:22 GMT, Brent Christian wrote:
>> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call
>> through `ReflectUtil.forName()`. When
>> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`,
>> it is doing so from `java.base`, and so u
On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Tue, 3 Dec 2024 02:22:15 GMT, Joe Wang wrote:
> Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
Looks OK. As this is a new test, I would have preferred this to be a junit
test, but lets get this back given where we are for 24 and can address
afterwards
-
Ma
On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang wrote:
> Disables XSLT and XPath Extension Functions by default, setting
> jdk.xml.enableExtensionFunctions to false.
>
> Adjusted tests accordingly.
Overall Looks good Joe
please see the comment below
test/jaxp/javax/xml/jaxp/unittest/transform/XSLT
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Changes Look Good Roger
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Changes Look Good Roger
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Changes Look Good Roger
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2
On Mon, 2 Dec 2024 20:13:55 GMT, Joe Wang wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> value unnecessary for the ternary expression
Marked
On Mon, 2 Dec 2024 04:19:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in the javadoc of
> `javax.sql.rowset.BaseRowSet#setBigDecimal()` method?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8345279, the javadoc
> incorrectly mentions `java.lang.BigDeci
On Sat, 30 Nov 2024 19:47:15 GMT, Joe Wang wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> list files vertically
Changes look good Joe
than
On Sat, 30 Nov 2024 19:47:15 GMT, Joe Wang wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> list files vertically
Changes look good Joe
than
On Tue, 26 Nov 2024 18:14:22 GMT, Joe Wang wrote:
>> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>>
>> Tests:
>> Updated the config test with the new settings.
>>
>> Removed obsolete tests Bug6309988.java and
>> Bug4674384_MAX_OCCURS_Test.java, and files used by
On Tue, 26 Nov 2024 12:13:20 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 19 Nov 2024 19:28:50 GMT, Stuart Marks wrote:
>> Thank you. It was an oversight that the original javadoc did not call out
>> the NPE, but now is our chance to get it right with a more reasonable
>> exception.
>
> Overall I agree with defining that IllegalStateException is thrown after
On Tue, 26 Nov 2024 07:28:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> spacing cha
On Fri, 22 Nov 2024 23:17:17 GMT, Joe Wang wrote:
> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>
> Tests:
> Updated the config test with the new settings.
>
> Removed obsolete tests Bug6309988.java and
> Bug4674384_MAX_OCCURS_Test.java, and files used by these
On Wed, 20 Nov 2024 21:03:33 GMT, Roger Riggs wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>>
>> Refresh of PR#22168 Including review comments made there.
>
> Roger Riggs has updated the pull request incrementally
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8344659: System.getPropert
On Wed, 20 Nov 2024 22:36:12 GMT, Brian Burkhalter wrote:
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
> #22132.
LGTM
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22285#pullrequestreview-2449890758
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote:
> Please review this PR which keeps the IANA language subtag registry data up
> to date with release _2024-11-19_.
>
> The changes are trivial and Locale tests pass as expected.
Marked as reviewed by lancea (Reviewer).
-
PR Revie
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote:
> Please review this PR which keeps the IANA language subtag registry data up
> to date with release _2024-11-19_.
>
> The changes are trivial and Locale tests pass as expected.
Marked as reviewed by lancea (Reviewer).
-
PR Revie
On Wed, 20 Nov 2024 09:38:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes SecurityManager
> usages from `jdk.jlink` module? This addresses
> https://bugs.openjdk.org/browse/JDK-8344524.
>
> The internal class `jdk.tools.jlink.internal.JlinkPermission` too
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Hi Brent,
There looks to be a lot of commented out code that should be removed as part of
your PR?
src/java.prefs/unix/classes/java/ut
On Mon, 18 Nov 2024 21:56:12 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 834
On Mon, 18 Nov 2024 21:56:12 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 834
On Mon, 18 Nov 2024 08:37:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato wrote:
> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
> after JEP486 integration.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439458103
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
Mar
On Sat, 16 Nov 2024 00:03:23 GMT, Justin Lu wrote:
>> Please review this PR which removes the lone `AccessController.doPrivileged`
>> call from the _java.scripting_ module after JEP486 integration.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the l
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
Mar
On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato wrote:
> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
> after JEP486 integration.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439458103
On Fri, 15 Nov 2024 11:19:43 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Deflater.java line 66:
>>
>>> 64: * usage with try-with-resources, this class implements {@link
>>> AutoCloseable}. The
>>> 65: * {@link #close()} method of this class calls {@code end()} to cle
On Thu, 14 Nov 2024 20:25:35 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 20:25:35 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 19:59:55 GMT, Sean Mullan wrote:
>> Yes, they are 96 and 98 chars long, which means I sympathise with both views
>> :)
>>
>> Unless hearing back from @seanjmullan I'll go with Roger's suggestion of one
>> line here.
>
> I think both are in the 90-100 range. Line length is a
On Thu, 14 Nov 2024 19:59:55 GMT, Sean Mullan wrote:
>> Yes, they are 96 and 98 chars long, which means I sympathise with both views
>> :)
>>
>> Unless hearing back from @seanjmullan I'll go with Roger's suggestion of one
>> line here.
>
> I think both are in the 90-100 range. Line length is a
On Thu, 14 Nov 2024 19:45:27 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/jar/JarFile.java line 182:
>>
>>> 180: }
>>> 181: RUNTIME_VERSION =
>>> Runtime.Version.parse(Integer.toString(runtimeVersion));
>>> 182: String enableMultiRelease =
>>> Sys
On Thu, 14 Nov 2024 19:45:27 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/jar/JarFile.java line 182:
>>
>>> 180: }
>>> 181: RUNTIME_VERSION =
>>> Runtime.Version.parse(Integer.toString(runtimeVersion));
>>> 182: String enableMultiRelease =
>>> Sys
On Thu, 14 Nov 2024 11:25:08 GMT, Alan Bateman wrote:
>> Remove the code for the now defunct SecurityManager execution mode from
>> ClassLoader and the built-in class loader implementations. The override of
>> getPermissions is removed from the application class loader, and from the
>> class l
On Thu, 14 Nov 2024 04:14:03 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Thu, 14 Nov 2024 14:43:50 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code following
>> JEP-486 integraion.
>>
>> * `ZipFileSystem` is updated to not perform `AccessController::doPrivileged`
>> * `ZipFileSystemProvider` is updated to not perfor
On Thu, 14 Nov 2024 14:11:57 GMT, Eirik Bjørsnøs wrote:
>> test/jdk/jdk/nio/zipfs/TestPosix.java line 224:
>>
>>> 222: } catch (IOException e) {
>>> 223: System.out.println("Caught " + e.getClass().getName() +
>>> "(" + e.getMessage() +
>>> 224: ") when r
1 - 100 of 1548 matches
Mail list logo
