On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang <jo...@openjdk.org> wrote: > Disables XSLT and XPath Extension Functions by default, setting > jdk.xml.enableExtensionFunctions to false. > > Adjusted tests accordingly.
Overall Looks good Joe please see the comment below test/jaxp/javax/xml/jaxp/unittest/transform/XSLTFunctionsTest.java line 162: > 160: * @param expectedResult Expected transformation result > 161: **/ > 162: //@Test(dataProvider = "document") Is there a reason you have this commented out? If the test is not needed, it should be removed or use the 'disable' element and add a comment as to why this is disabled ------------- Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22504#pullrequestreview-2475411763 PR Review Comment: https://git.openjdk.org/jdk/pull/22504#discussion_r1867567968
