Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Integrate ALT set-versions to improve ELF library dependency generation (Issue #3606)
pmatilai left a comment (rpm-software-management/rpm#3606) Hmm, GH fails to convert this into a discussion for some reason. I guess I'll retry later today/tomorrow. At any rate, this is absolutely not rpm 6 material. That ship sailed many, many moons ago. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3606#issuecomment-2693590486 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Integrate ALT set-versions to improve ELF library dependency generation (Issue #3606)
Reopened #3606. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3606#event-16530017177 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Bunch of man page formatting fixes + minor cleanups (PR #3607)
@pmatilai pushed 1 commit. 02505ac37669637a1799dbd766c462460a051c39 Drop invalid -d/--debug switch from rpm-misc(8) -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3607/files/ee40cb2d3e94062877b4344f370c1a3f77244a33..02505ac37669637a1799dbd766c462460a051c39 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Bunch of man page formatting fixes + minor cleanups (PR #3607)
Merged #3607 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3607#event-16530472351 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Integrate ALT set-versions to improve ELF library dependency generation (Issue #3606)
Reopened #3606. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3606#event-16529603320 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Move most rpm command man pages to section 1 (PR #3610)
These commands have absolutely nothing to do with system administration, move them to section 1 where they always belonged and update references. Of course, rpmkeys and even rpm itself are a bit borderline - both can be used as a regular user too. But, the system admistrator is the primary target audience, whereas the other tools are aimed at packagers. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3610 -- Commit Summary -- * Move most rpm command man pages to section 1 -- File Changes -- M docs/man/CMakeLists.txt (6) M docs/man/index.md (18) M docs/man/rpm-plugin-ima.8.scd (2) M docs/man/rpm.8.scd (6) R docs/man/rpm2archive.1.scd (4) R docs/man/rpm2cpio.1.scd (4) R docs/man/rpmbuild.1.scd (10) M docs/man/rpmdb.8.scd (4) R docs/man/rpmdeps.1.scd (4) R docs/man/rpmgraph.1.scd (2) M docs/man/rpmkeys.8.scd (4) R docs/man/rpmlua.1.scd (2) R docs/man/rpmsign.1.scd (6) R docs/man/rpmsort.1.scd (4) R docs/man/rpmspec.1.scd (6) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/3610.patch https://github.com/rpm-software-management/rpm/pull/3610.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3610 You are receiving this because you are subscribed to this thread. Message ID:___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Resurrect online rendering of man pages (Issue #3598)
pmatilai left a comment (rpm-software-management/rpm#3598) https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#creating-a-custom-github-actions-workflow-to-publish-your-site seems like the relevant part... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3598#issuecomment-2693839265 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Bunch of man page formatting fixes + minor cleanups (PR #3607)
@pmatilai pushed 6 commits. f77952323eb5c2e4a7dbe0d148a6c673e9eb4ae7 Use underlines for user-input parts in man pages, like deity intended 93a7b3a47d2484de226e14c28d9497a25b6139c0 Use underlines when referring to file names in manuals 3d26ef526b94f0039d87415243677addf8da927e Remove bolding from option placeholders like [select-options] 8f4a04bbb793bf50eea0d3d6cc476dab71d1566b Drop legacy note on executing rpmbuild, this is 20 years obsolete a908f61a504a7e0fab55e8c8be649792003ce49d Drop subsections from rpmbuild synopsis to make it clearer 6ed00392b2083b30b4646f487914bace86df62f3 Document rpm --specfile as obsolete, point to rpmspec -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3607/files/34a32cfde41681ffeea1b5419dd3e6ddfae32de3..6ed00392b2083b30b4646f487914bace86df62f3 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Bunch of man page formatting fixes + minor cleanups (PR #3607)
@pmatilai commented on this pull request.
>
## INSTALLING, UPGRADING, AND REMOVING PACKAGES
-*rpm* {*-i|--install*} [*install-options*] *PACKAGE_FILE ...*
+*rpm* {*-i*|*--install*} [install-options] _PACKAGE_FILE_ [...]
But, as soon as you start doing something like that it just feels so bloody
wrong... ended up fixing it all up afterall :laughing:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3607#discussion_r1977039552
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Bunch of man page formatting fixes + minor cleanups (PR #3607)
@pmatilai pushed 1 commit. ee40cb2d3e94062877b4344f370c1a3f77244a33 Drop couple of duplicates from rpm-misc(8) -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3607/files/6ed00392b2083b30b4646f487914bace86df62f3..ee40cb2d3e94062877b4344f370c1a3f77244a33 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for macro file format (Issue #3613)
pmatilai created an issue (rpm-software-management/rpm#3613) Our main configuration file format is not documented anywhere at all... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3613 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add a man page for runtime configuration (Issue #3620)
pmatilai created an issue (rpm-software-management/rpm#3620) Rpm's configuration knobs are scattered throughout the main macros file and code with no central place where you can look configuration up. There should be a man page covering all the runtime (think queries, transactions etc) configuration tunables. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3620 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add examples to rpm man page (Issue #3628)
pmatilai created an issue (rpm-software-management/rpm#3628) This is the big one, should have examples for all the major functionality: - install/update - erase - restore - verify - query -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3628 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add examples to rpmsign man page (Issue #3630)
pmatilai created an issue (rpm-software-management/rpm#3630) We have some example configuration in the rpmsign man page, but no cli usages. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3630 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add examples to man pages where missing (Issue #3627)
pmatilai created an issue (rpm-software-management/rpm#3627) We have a few examples in the newer man pages, but all the really important ones are missing them entirely. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3627 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for thorough macro syntax (Issue #3617)
pmatilai created an issue (rpm-software-management/rpm#3617) We have online docs for this, but it really belongs in a man page. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3617 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for queryformat (Issue #3618)
pmatilai created an issue (rpm-software-management/rpm#3618) Rpm's queryformat is complex enough that it's basically a mini-language. We have online docs for it, but this belongs to a man page where it's available without having to resort to a browser. It then also allows cross-referencing it from other man pages, as this is used and exposed in several different places and configurations. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3618 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for rpm format (Issue #3619)
pmatilai created an issue (rpm-software-management/rpm#3619) We have online docs for the rpm file format but it really belongs in a man page (or a few, to cover the different versions and all) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3619 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for spec format (Issue #3615)
pmatilai created an issue (rpm-software-management/rpm#3615) We have some online documentation for this, but it really belong in a man page that we'll then additionally make available on the web. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3615 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for rpm version comparison algorithm (Issue #3616)
pmatilai created an issue (rpm-software-management/rpm#3616) This comes up every now and then because it's such a major thing, yet we lack any documentation for it. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3616 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for dependency generator format/API (Issue #3622)
pmatilai created an issue (rpm-software-management/rpm#3622) We have an online doc for this but it should really be a man page. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3622 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for rpm design (Issue #3623)
pmatilai created an issue (rpm-software-management/rpm#3623) We now have an online doc (philosophy.md) for this but should really be a man page. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3623 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add man pages for all important parts of rpm (Issue #3612)
pmatilai left a comment (rpm-software-management/rpm#3612) @dmnks ask and you shall receive 😄 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3612#issuecomment-2694273318 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add examples to rpmbuild man page (Issue #3629)
pmatilai created an issue (rpm-software-management/rpm#3629) This is the other major tool in rpm, and the man page it has zero examples. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3629 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man pages for all important parts of rpm (Issue #3612)
pmatilai created an issue (rpm-software-management/rpm#3612) We currently have reasonable man page coverage for the commands and their switches, but the file formats and such are sorely missing. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3612 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: Make online documentation release specific (Issue #3611)
pmatilai created an issue (rpm-software-management/rpm#3611) Our docs in https://rpm.org/documentation.html are currently release agnostic, with the occasional "in >= 4.15" style note but public documentation should really be based on stable releases instead of what happens to be in git master at any given day. This goes for the main content, man pages, API docs and all. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3611 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for rpmrc format (Issue #3614)
pmatilai created an issue (rpm-software-management/rpm#3614) Our main arch configuration format is not documented anywhere at all -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3614 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for rpmbuild configuration (Issue #3621)
pmatilai created an issue (rpm-software-management/rpm#3621) Rpm's configuration knobs are scattered throughout the main macros file and code with no central place where you can look configuration up. There should be a man page covering all the build configuration tunables. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3621 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add man pages for all important parts of rpm (Issue #3612)
dmnks left a comment (rpm-software-management/rpm#3612) How about https://rpm-software-management.github.io/rpm/manual/philosophy.html (and perhaps naming the man page `rpm-design`)? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3612#issuecomment-2694250667 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add a man page for rpmuncompress (Issue #3624)
pmatilai created an issue (rpm-software-management/rpm#3624) This is considered kind of an internal tool, but as this is something packagers might want to use directly, we should have documentation for it. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3624 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add man page for elfdeps (Issue #3625)
pmatilai created an issue (rpm-software-management/rpm#3625) This is largerly an internal-only tool but since packagers may want/need to call it directly, we should have docs for it. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3625 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add a man page for build root policies (Issue #3626)
pmatilai created an issue (rpm-software-management/rpm#3626) Build root policies is a major subsystem in the build process that has absolutely zero documentation. Oops. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3626 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@ffesti pushed 4 commits. 62d1c736ae813bf33e6ac6cdeb738ea11696951f Move getKeystore to keystore module 8101bf17e8418b89e0c3b0b19d2221c938eb74b7 Open rpmdb when accessing the rpmdb keystore 13765ee545b5d43e9937399aa39ec3f557abe083 Add keystore::delete_store() bf635b57e6eb009a3c310f5af4983db8b86943b5 Implement rpmkeys --rebuild -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3562/files/e01b5990915c4d665a58132e7c000ec6f556f2a9..bf635b57e6eb009a3c310f5af4983db8b86943b5 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@ffesti commented on this pull request. > @@ -149,7 +155,8 @@ int main(int argc, char *argv[]) args = (ARGV_const_t) poptGetArgs(optCon); -if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY) +if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY && + mode != MODE_REBUILD) If I only could remember how to indent this properly... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978304369 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@ffesti commented on this pull request.
>
virtual ~keystore() = default;
+keystore(std::string n): name(n) {};
OK; for now I just moved the getKeystore to the keystore module and dropped
this whole name business. For some reason this just does not work as expected
with C++. I am all for the name being a static property but I could not make
this work with C++ as strings are just not static.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978306551
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@ffesti commented on this pull request.
> @@ -406,6 +406,50 @@ rpmRC rpmtsImportPubkey(const rpmts ts, const unsigned
> char * pkt, size_t pktlen
return rc;
}
+rpmRC rpmtsRebuildKeystore(rpmtxn txn, const char * from)
+{
+rpmts ts = rpmtxnTs(txn);
+rpmRC rc = RPMRC_OK;
+rpmKeyring keyring = rpmtsGetKeyring(ts, 1);
+keystore_fs ks_fs = {};
+keystore_rpmdb ks_rpmdb = {};
+keystore_openpgp_cert_d ks_opengpg = {};
+rpmKeyringIterator iter = NULL;
+
+if (rpmtsOpenDB(txn->ts, (O_RDWR|O_CREAT))) {
Fixed. There was quite a mess of part relying one the surrounding code opening
the rpmdb and part in the keystore opening the rpmdb themselves. All code paths
in the rpmdb key store should now open the rpmdb.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978308087
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@ffesti commented on this pull request.
> + for (keystore *ks : std::vector
+{&ks_fs, &ks_rpmdb, &ks_opengpg}) {
+ if (ks->name == from and ks->name != ts->keystore->name) {
+ ks->load_keys(txn, keyring);
+ found = true;
+ }
+ }
+ if (not found) {
+ rpmlog(RPMLOG_ERR, _("No key store backend %s"), from);
+ rc = RPMRC_FAIL;
+ goto exit;
+ }
+}
+for (keystore *ks : std::vector
+{&ks_fs, &ks_rpmdb, &ks_opengpg}) {
+ ks->delete_store(txn);
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978306805
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
ffesti left a comment (rpm-software-management/rpm#3562) > It's not a merge we want in --from mode, but move. Like with --rebuilddb. I > thought that was clear in the ticket but I guess not. And like said above, we > shouldn't be deleting anything we were not specifically asked to touch. Sure. My test cases now run into automatically generated keys for signing builds which are for some reason in the previously empty keystore. Well, were in the keystore... > rpmKeyringSize() is not used here and shouldn't be added without any tests. Dropped. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3562#issuecomment-2695672105 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@ffesti commented on this pull request. > @@ -149,7 +155,8 @@ int main(int argc, char *argv[]) args = (ARGV_const_t) poptGetArgs(optCon); -if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY) +if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY && + mode != MODE_REBUILD) OK, so the reason is that there are too many, all not so great options. Went with a) already. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978778074 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@pmatilai commented on this pull request. > @@ -149,7 +155,8 @@ int main(int argc, char *argv[]) args = (ARGV_const_t) poptGetArgs(optCon); -if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY) +if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY && + mode != MODE_REBUILD) Yeah a) and b) are mechanically applicable anywhere, c) requires thinking. As a reminder, CONTRIBUTING.md has advice too: > If in doubt, 'indent -kr' generally produces acceptable formatting. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978802177 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@pmatilai commented on this pull request.
>
virtual ~keystore() = default;
+keystore(std::string n): name(n) {};
Actually gcc gives a pretty helpful hint here when trying to add something like
`static std::string name = "fs";` to the keystore:
> /home/pmatilai/repos/rpm/lib/keystore.hh:22:30: error: ‘constexpr’ needed for
> in-class initialization of static data member ‘const std::string
> rpm::keystore_fs::name’ of non-integral type [-fpermissive]
22 | static const std::string name = "fs";
`static constexpr std::string name = "fs";` merrily compiles.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978598203
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)
@pmatilai commented on this pull request. > @@ -149,7 +155,8 @@ int main(int argc, char *argv[]) args = (ARGV_const_t) poptGetArgs(optCon); -if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY) +if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY && + mode != MODE_REBUILD) For crying out loud. It's not like you need to remember 21 digits of pi here. The issue is *ambiguity* due to identical indentation so to fix you just need to change how it ends up laid out, such as: a) indent the condition continuation deeper. b) put the opening brace on the next line (unlike the usual style), this provides the brain sufficient clue about the matter c) avoid the whole issue by moving part of the condition elsewhere, such as using an aptly named helper variable Quite often it's c) that makes for most readable code. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978688520 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
