@pmatilai commented on this pull request.
>
virtual ~keystore() = default;
+ keystore(std::string n): name(n) {};
Actually gcc gives a pretty helpful hint here when trying to add something like
`static std::string name = "fs";` to the keystore:
> /home/pmatilai/repos/rpm/lib/keystore.hh:22:30: error: ‘constexpr’ needed for
> in-class initialization of static data member ‘const std::string
> rpm::keystore_fs::name’ of non-integral type [-fpermissive]
22 | static const std::string name = "fs";
`static constexpr std::string name = "fs";` merrily compiles.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978598203
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3562/review/2655911...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
